summaryrefslogtreecommitdiff
path: root/sys/kern/vfs_bio.c
diff options
context:
space:
mode:
authorGrigoriy Orlov <gluk@cvs.openbsd.org>2001-04-06 19:10:50 +0000
committerGrigoriy Orlov <gluk@cvs.openbsd.org>2001-04-06 19:10:50 +0000
commit5c9d958f09d3a2dbbd3c745e2cad49c908e264ab (patch)
treebdefe12fef74facf60fab28dc3ac7e352bd71c72 /sys/kern/vfs_bio.c
parentfc49e03d2ce94c45ba8eaa2a8f4bd853e50998fe (diff)
Avoid a livelock problem where the buffer cache code would be
recycling B_AGE buffers with dependencies. >From NetBSD. costa@ ok.
Diffstat (limited to 'sys/kern/vfs_bio.c')
-rw-r--r--sys/kern/vfs_bio.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/sys/kern/vfs_bio.c b/sys/kern/vfs_bio.c
index 5ba80311513..7749cef7a09 100644
--- a/sys/kern/vfs_bio.c
+++ b/sys/kern/vfs_bio.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: vfs_bio.c,v 1.36 2001/03/30 10:30:26 art Exp $ */
+/* $OpenBSD: vfs_bio.c,v 1.37 2001/04/06 19:10:49 gluk Exp $ */
/* $NetBSD: vfs_bio.c,v 1.44 1996/06/11 11:15:36 pk Exp $ */
/*-
@@ -588,6 +588,10 @@ brelse(bp)
/*
* It has valid data. Put it on the end of the appropriate
* queue, so that it'll stick around for as long as possible.
+ * If buf is AGE, but has dependencies, must put it on last
+ * bufqueue to be scanned, ie LRU. This protects against the
+ * livelock where BQ_AGE only has buffers with dependencies,
+ * and we thus never get to the dependent buffers in BQ_LRU.
*/
if (ISSET(bp->b_flags, B_LOCKED))
/* locked in core */
@@ -598,7 +602,8 @@ brelse(bp)
numcleanbufs++;
if (ISSET(bp->b_flags, B_AGE))
/* stale but valid data */
- bufq = &bufqueues[BQ_AGE];
+ bufq = buf_countdeps(bp, 0, 1) ?
+ &bufqueues[BQ_LRU] : &bufqueues[BQ_AGE];
else
/* valid data */
bufq = &bufqueues[BQ_LRU];