diff options
author | Thorsten Lockert <tholo@cvs.openbsd.org> | 1996-10-27 08:02:33 +0000 |
---|---|---|
committer | Thorsten Lockert <tholo@cvs.openbsd.org> | 1996-10-27 08:02:33 +0000 |
commit | c5282514edf7aaddee639aa73f1c489085c5a68b (patch) | |
tree | 87252770b6cb9484b7adb3a57ccebcd775734a1f /sys/kern | |
parent | 9d0a3e37f9c2b4452bab3c04016898a68063948c (diff) |
Better error checking for lseek(2)
Diffstat (limited to 'sys/kern')
-rw-r--r-- | sys/kern/vfs_syscalls.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/sys/kern/vfs_syscalls.c b/sys/kern/vfs_syscalls.c index ecd14e06d0d..8598b025358 100644 --- a/sys/kern/vfs_syscalls.c +++ b/sys/kern/vfs_syscalls.c @@ -1,4 +1,4 @@ -/* $OpenBSD: vfs_syscalls.c,v 1.16 1996/10/26 07:27:01 tholo Exp $ */ +/* $OpenBSD: vfs_syscalls.c,v 1.17 1996/10/27 08:02:32 tholo Exp $ */ /* $NetBSD: vfs_syscalls.c,v 1.71 1996/04/23 10:29:02 mycroft Exp $ */ /* @@ -1134,6 +1134,7 @@ sys_lseek(p, v, retval) register struct filedesc *fdp = p->p_fd; register struct file *fp; struct vattr vattr; + struct vnode *vp; int error; if ((u_int)SCARG(uap, fd) >= fdp->fd_nfiles || @@ -1141,8 +1142,13 @@ sys_lseek(p, v, retval) return (EBADF); if (fp->f_type != DTYPE_VNODE) return (ESPIPE); + vp = (struct vnode *)fp->f_data; + if (vp->v_type == VFIFO) + return (ESPIPE); switch (SCARG(uap, whence)) { case L_INCR: + if (fp->f_offset + SCARG(uap, offset) < 0) + return (EINVAL); fp->f_offset += SCARG(uap, offset); break; case L_XTND: @@ -1150,9 +1156,13 @@ sys_lseek(p, v, retval) cred, p); if (error) return (error); + if (vattr.va_size + SCARG(uap, offset) < 0) + return (EINVAL); fp->f_offset = SCARG(uap, offset) + vattr.va_size; break; case L_SET: + if (SCARG(uap, offset) < 0) + return (EINVAL); fp->f_offset = SCARG(uap, offset); break; default: |