diff options
author | Marco Pfatschbacher <mpf@cvs.openbsd.org> | 2010-04-25 17:38:54 +0000 |
---|---|---|
committer | Marco Pfatschbacher <mpf@cvs.openbsd.org> | 2010-04-25 17:38:54 +0000 |
commit | 5423a7142fc3ef05c909fe26338c0f6914e80312 (patch) | |
tree | c58a5aade62001862e15f95d46e7e81748f8d9e1 /sys/net/if.c | |
parent | 083209be9a6b6859f96522362fd5cee27e5b10aa (diff) |
Properly adjust group demotion counters when groups are added or
removed. Extend carp demote logging to also show the reason for
the demote. Return EINVAL instead of ERANGE if a carpdemote request
is out range. Requested from otto.
OK mcbride, henning.
Diffstat (limited to 'sys/net/if.c')
-rw-r--r-- | sys/net/if.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sys/net/if.c b/sys/net/if.c index 64e34aafb64..2a8fe3c5268 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if.c,v 1.213 2010/04/17 18:31:41 stsp Exp $ */ +/* $OpenBSD: if.c,v 1.214 2010/04/25 17:38:53 mpf Exp $ */ /* $NetBSD: if.c,v 1.35 1996/05/07 05:26:04 thorpej Exp $ */ /* @@ -1512,10 +1512,10 @@ ifioctl(struct socket *so, u_long cmd, caddr_t data, struct proc *p) case SIOCAIFGROUP: if ((error = suser(p, 0))) return (error); - (*ifp->if_ioctl)(ifp, cmd, data); /* XXX error check */ ifgr = (struct ifgroupreq *)data; if ((error = if_addgroup(ifp, ifgr->ifgr_group))) return (error); + (*ifp->if_ioctl)(ifp, cmd, data); /* XXX error check */ break; case SIOCGIFGROUP: @@ -2000,7 +2000,7 @@ if_setgroupattribs(caddr_t data) demote = ifgr->ifgr_attrib.ifg_carp_demoted; if (demote + ifg->ifg_carp_demoted > 0xff || demote + ifg->ifg_carp_demoted < 0) - return (ERANGE); + return (EINVAL); ifg->ifg_carp_demoted += demote; |