summaryrefslogtreecommitdiff
path: root/sys/netinet
diff options
context:
space:
mode:
authorHakan Olsson <ho@cvs.openbsd.org>1999-11-04 11:24:25 +0000
committerHakan Olsson <ho@cvs.openbsd.org>1999-11-04 11:24:25 +0000
commit2256580ce20ac70744312c37d293482b4c5a5f46 (patch)
treec2b5eed934e505cdc00d3ce1e036698b3a23fb55 /sys/netinet
parent33d5222484aa34acf461785a9e6e9fad2ce6ee74 (diff)
Add comment about gettdb() and spl level.
Diffstat (limited to 'sys/netinet')
-rw-r--r--sys/netinet/tcp_input.c4
-rw-r--r--sys/netinet/tcp_output.c4
-rw-r--r--sys/netinet/udp_usrreq.c4
3 files changed, 9 insertions, 3 deletions
diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c
index 3105fbea9fd..142452d0849 100644
--- a/sys/netinet/tcp_input.c
+++ b/sys/netinet/tcp_input.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: tcp_input.c,v 1.49 1999/09/01 21:38:21 provos Exp $ */
+/* $OpenBSD: tcp_input.c,v 1.50 1999/11/04 11:24:23 ho Exp $ */
/* $NetBSD: tcp_input.c,v 1.23 1996/02/13 23:43:44 christos Exp $ */
/*
@@ -345,6 +345,8 @@ tcp_input(m, va_alist)
/* Save the last SA which was used to process the mbuf */
if ((m->m_flags & (M_CONF|M_AUTH)) && m->m_pkthdr.tdbi) {
struct tdb_ident *tdbi = m->m_pkthdr.tdbi;
+ /* XXX gettdb() should really be called at spltdb(). */
+ /* XXX this is splsoftnet(), currently they are the same. */
tdb = gettdb(tdbi->spi, &tdbi->dst, tdbi->proto);
free(m->m_pkthdr.tdbi, M_TEMP);
m->m_pkthdr.tdbi = NULL;
diff --git a/sys/netinet/tcp_output.c b/sys/netinet/tcp_output.c
index 7f79d2067a7..5324d78f931 100644
--- a/sys/netinet/tcp_output.c
+++ b/sys/netinet/tcp_output.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: tcp_output.c,v 1.21 1999/07/06 20:17:53 cmetz Exp $ */
+/* $OpenBSD: tcp_output.c,v 1.22 1999/11/04 11:24:24 ho Exp $ */
/* $NetBSD: tcp_output.c,v 1.16 1997/06/03 16:17:09 kml Exp $ */
/*
@@ -812,6 +812,8 @@ send:
#endif /* INET6 */
}
+ /* XXX gettdb() should really be called at spltdb(). */
+ * XXX this is splsoftnet(), currently they are the same. */
tdb = gettdb(0, &sa, IPPROTO_TCP);
if (tdb == NULL)
return (EPERM);
diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c
index d57e3faf7b3..644cecc7f98 100644
--- a/sys/netinet/udp_usrreq.c
+++ b/sys/netinet/udp_usrreq.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: udp_usrreq.c,v 1.27 1999/09/23 07:20:35 deraadt Exp $ */
+/* $OpenBSD: udp_usrreq.c,v 1.28 1999/11/04 11:24:24 ho Exp $ */
/* $NetBSD: udp_usrreq.c,v 1.28 1996/03/16 23:54:03 christos Exp $ */
/*
@@ -163,6 +163,8 @@ udp_input(m, va_alist)
/* Save the last SA which was used to process the mbuf */
if ((m->m_flags & (M_CONF|M_AUTH)) && m->m_pkthdr.tdbi) {
struct tdb_ident *tdbi = m->m_pkthdr.tdbi;
+ /* XXX gettdb() should really be called at spltdb(). */
+ /* XXX this is splsoftnet(), currently they are the same. */
tdb = gettdb(tdbi->spi, &tdbi->dst, tdbi->proto);
free(m->m_pkthdr.tdbi, M_TEMP);
m->m_pkthdr.tdbi = NULL;