diff options
| author | Miod Vallat <miod@cvs.openbsd.org> | 2006-11-29 12:24:19 +0000 |
|---|---|---|
| committer | Miod Vallat <miod@cvs.openbsd.org> | 2006-11-29 12:24:19 +0000 |
| commit | 83368008eb99b7d2d9cb6f221de83c9af517b654 (patch) | |
| tree | 0a2dbd431fbc167b1d69b949392ff3f47e6a82ef /sys/nfs/nfs_syscalls.c | |
| parent | e83961e1eb1bda3be0177245339cfd8037ed4c4a (diff) | |
Kernel stack can be swapped. This means that stuff that's on the stack
should never be referenced outside the context of the process to which
this stack belongs unless we do the PHOLD/PRELE dance. Loads of code
doesn't follow the rules here. Instead of trying to track down all
offenders and fix this hairy situation, it makes much more sense
to not swap kernel stacks.
From art@, tested by many some time ago.
Diffstat (limited to 'sys/nfs/nfs_syscalls.c')
| -rw-r--r-- | sys/nfs/nfs_syscalls.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/sys/nfs/nfs_syscalls.c b/sys/nfs/nfs_syscalls.c index 584ab092e68..25e956d0f8c 100644 --- a/sys/nfs/nfs_syscalls.c +++ b/sys/nfs/nfs_syscalls.c @@ -1,4 +1,4 @@ -/* $OpenBSD: nfs_syscalls.c,v 1.49 2006/10/04 12:04:40 pedro Exp $ */ +/* $OpenBSD: nfs_syscalls.c,v 1.50 2006/11/29 12:24:18 miod Exp $ */ /* $NetBSD: nfs_syscalls.c,v 1.19 1996/02/18 11:53:52 fvdl Exp $ */ /* @@ -520,7 +520,6 @@ nfssvc_nfsd(nsd, argp, p) TAILQ_INSERT_TAIL(&nfsd_head, nfsd, nfsd_chain); nfs_numnfsd++; } - PHOLD(p); /* * Loop getting rpc requests until SIGKILL. */ @@ -622,7 +621,6 @@ nfssvc_nfsd(nsd, argp, p) !copyout(nfsd->nfsd_verfstr, nsd->nsd_verfstr, nfsd->nfsd_verflen) && !copyout((caddr_t)nsd, argp, sizeof (*nsd))) { - PRELE(p); return (ENEEDAUTH); } cacherep = RC_DROPIT; @@ -747,7 +745,6 @@ nfssvc_nfsd(nsd, argp, p) } } done: - PRELE(p); TAILQ_REMOVE(&nfsd_head, nfsd, nfsd_chain); splx(s); free((caddr_t)nfsd, M_NFSD); @@ -934,7 +931,6 @@ nfssvc_iod(p) return (EBUSY); nfs_asyncdaemon[myiod] = p; nfs_numasync++; - PHOLD(p); /* * Just loop around doin our stuff until SIGKILL */ @@ -982,7 +978,6 @@ nfssvc_iod(p) } while ((bp = nbp) != NULL); } if (error) { - PRELE(p); nfs_asyncdaemon[myiod] = NULL; nfs_numasync--; return (error); |