diff options
author | Paul Irofti <pirofti@cvs.openbsd.org> | 2013-11-15 10:17:40 +0000 |
---|---|---|
committer | Paul Irofti <pirofti@cvs.openbsd.org> | 2013-11-15 10:17:40 +0000 |
commit | 28f7f0e0c022cf25c6540bfb311267b7ba09cbfa (patch) | |
tree | 2473d6a60fdc1896c5a5237afaa36089484f7f9f /sys | |
parent | 3ab67e413a613e17c0a2eb67b3dbf371317b313a (diff) |
Clean-up usbd_abort_pipe() usage.
This function never fails. So change it's return type to void and
adjust the copy-pasted callers that were checking the return.
"If it compiles, ok" mpi@
Diffstat (limited to 'sys')
-rw-r--r-- | sys/dev/usb/if_atu.c | 14 | ||||
-rw-r--r-- | sys/dev/usb/if_aue.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_axe.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_axen.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_cdce.c | 17 | ||||
-rw-r--r-- | sys/dev/usb/if_cue.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_kue.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_mos.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_smsc.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_udav.c | 17 | ||||
-rw-r--r-- | sys/dev/usb/if_upl.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/if_url.c | 17 | ||||
-rw-r--r-- | sys/dev/usb/if_urndis.c | 12 | ||||
-rw-r--r-- | sys/dev/usb/if_wi_usb.c | 20 | ||||
-rw-r--r-- | sys/dev/usb/ubsa.c | 8 | ||||
-rw-r--r-- | sys/dev/usb/uchcom.c | 7 | ||||
-rw-r--r-- | sys/dev/usb/umbg.c | 12 | ||||
-rw-r--r-- | sys/dev/usb/umct.c | 7 | ||||
-rw-r--r-- | sys/dev/usb/umodem.c | 7 | ||||
-rw-r--r-- | sys/dev/usb/umsm.c | 8 | ||||
-rw-r--r-- | sys/dev/usb/uplcom.c | 7 | ||||
-rw-r--r-- | sys/dev/usb/usbdi.c | 8 | ||||
-rw-r--r-- | sys/dev/usb/usbdi.h | 4 | ||||
-rw-r--r-- | sys/dev/usb/uticom.c | 7 | ||||
-rw-r--r-- | sys/dev/usb/uvscom.c | 8 |
25 files changed, 78 insertions, 262 deletions
diff --git a/sys/dev/usb/if_atu.c b/sys/dev/usb/if_atu.c index 70591778acc..d8ead0cc0d7 100644 --- a/sys/dev/usb/if_atu.c +++ b/sys/dev/usb/if_atu.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_atu.c,v 1.103 2013/04/15 09:23:01 mglocker Exp $ */ +/* $OpenBSD: if_atu.c,v 1.104 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2003, 2004 * Daan Vreeken <Danovitsch@Vitsch.net>. All rights reserved. @@ -2301,11 +2301,7 @@ atu_stop(struct ifnet *ifp, int disable) /* Stop transfers. */ if (sc->atu_ep[ATU_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->atu_ep[ATU_ENDPT_RX]); - if (err) { - DPRINTF(("%s: abort rx pipe failed: %s\n", - sc->atu_dev.dv_xname, usbd_errstr(err))); - } + usbd_abort_pipe(sc->atu_ep[ATU_ENDPT_RX]); err = usbd_close_pipe(sc->atu_ep[ATU_ENDPT_RX]); if (err) { DPRINTF(("%s: close rx pipe failed: %s\n", @@ -2315,11 +2311,7 @@ atu_stop(struct ifnet *ifp, int disable) } if (sc->atu_ep[ATU_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->atu_ep[ATU_ENDPT_TX]); - if (err) { - DPRINTF(("%s: abort tx pipe failed: %s\n", - sc->atu_dev.dv_xname, usbd_errstr(err))); - } + usbd_abort_pipe(sc->atu_ep[ATU_ENDPT_TX]); err = usbd_close_pipe(sc->atu_ep[ATU_ENDPT_TX]); if (err) { DPRINTF(("%s: close tx pipe failed: %s\n", diff --git a/sys/dev/usb/if_aue.c b/sys/dev/usb/if_aue.c index b2704672956..e360f27e4f9 100644 --- a/sys/dev/usb/if_aue.c +++ b/sys/dev/usb/if_aue.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_aue.c,v 1.89 2013/11/05 10:20:04 mpi Exp $ */ +/* $OpenBSD: if_aue.c,v 1.90 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: if_aue.c,v 1.82 2003/03/05 17:37:36 shiba Exp $ */ /* * Copyright (c) 1997, 1998, 1999, 2000 @@ -1604,11 +1604,7 @@ aue_stop(struct aue_softc *sc) /* Stop transfers. */ if (sc->aue_ep[AUE_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->aue_ep[AUE_ENDPT_RX]); - if (err) { - printf("%s: abort rx pipe failed: %s\n", - sc->aue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->aue_ep[AUE_ENDPT_RX]); err = usbd_close_pipe(sc->aue_ep[AUE_ENDPT_RX]); if (err) { printf("%s: close rx pipe failed: %s\n", @@ -1618,11 +1614,7 @@ aue_stop(struct aue_softc *sc) } if (sc->aue_ep[AUE_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->aue_ep[AUE_ENDPT_TX]); - if (err) { - printf("%s: abort tx pipe failed: %s\n", - sc->aue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->aue_ep[AUE_ENDPT_TX]); err = usbd_close_pipe(sc->aue_ep[AUE_ENDPT_TX]); if (err) { printf("%s: close tx pipe failed: %s\n", @@ -1632,11 +1624,7 @@ aue_stop(struct aue_softc *sc) } if (sc->aue_ep[AUE_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->aue_ep[AUE_ENDPT_INTR]); - if (err) { - printf("%s: abort intr pipe failed: %s\n", - sc->aue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->aue_ep[AUE_ENDPT_INTR]); err = usbd_close_pipe(sc->aue_ep[AUE_ENDPT_INTR]); if (err) { printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_axe.c b/sys/dev/usb/if_axe.c index 0e9a4fec315..4f76747b292 100644 --- a/sys/dev/usb/if_axe.c +++ b/sys/dev/usb/if_axe.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_axe.c,v 1.122 2013/08/07 01:06:41 bluhm Exp $ */ +/* $OpenBSD: if_axe.c,v 1.123 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2005, 2006, 2007 Jonathan Gray <jsg@openbsd.org> @@ -1500,11 +1500,7 @@ axe_stop(struct axe_softc *sc) /* Stop transfers. */ if (sc->axe_ep[AXE_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->axe_ep[AXE_ENDPT_RX]); - if (err) { - printf("axe%d: abort rx pipe failed: %s\n", - sc->axe_unit, usbd_errstr(err)); - } + usbd_abort_pipe(sc->axe_ep[AXE_ENDPT_RX]); err = usbd_close_pipe(sc->axe_ep[AXE_ENDPT_RX]); if (err) { printf("axe%d: close rx pipe failed: %s\n", @@ -1514,11 +1510,7 @@ axe_stop(struct axe_softc *sc) } if (sc->axe_ep[AXE_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->axe_ep[AXE_ENDPT_TX]); - if (err) { - printf("axe%d: abort tx pipe failed: %s\n", - sc->axe_unit, usbd_errstr(err)); - } + usbd_abort_pipe(sc->axe_ep[AXE_ENDPT_TX]); err = usbd_close_pipe(sc->axe_ep[AXE_ENDPT_TX]); if (err) { printf("axe%d: close tx pipe failed: %s\n", @@ -1528,11 +1520,7 @@ axe_stop(struct axe_softc *sc) } if (sc->axe_ep[AXE_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->axe_ep[AXE_ENDPT_INTR]); - if (err) { - printf("axe%d: abort intr pipe failed: %s\n", - sc->axe_unit, usbd_errstr(err)); - } + usbd_abort_pipe(sc->axe_ep[AXE_ENDPT_INTR]); err = usbd_close_pipe(sc->axe_ep[AXE_ENDPT_INTR]); if (err) { printf("axe%d: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_axen.c b/sys/dev/usb/if_axen.c index fea45f86472..becc3d71d3c 100644 --- a/sys/dev/usb/if_axen.c +++ b/sys/dev/usb/if_axen.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_axen.c,v 1.3 2013/10/21 10:10:22 yuo Exp $ */ +/* $OpenBSD: if_axen.c,v 1.4 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2013 Yojiro UO <yuo@openbsd.org> @@ -1510,11 +1510,7 @@ axen_stop(struct axen_softc *sc) /* Stop transfers. */ if (sc->axen_ep[AXEN_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->axen_ep[AXEN_ENDPT_RX]); - if (err) { - printf("axen%d: abort rx pipe failed: %s\n", - sc->axen_unit, usbd_errstr(err)); - } + usbd_abort_pipe(sc->axen_ep[AXEN_ENDPT_RX]); err = usbd_close_pipe(sc->axen_ep[AXEN_ENDPT_RX]); if (err) { printf("axen%d: close rx pipe failed: %s\n", @@ -1524,11 +1520,7 @@ axen_stop(struct axen_softc *sc) } if (sc->axen_ep[AXEN_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->axen_ep[AXEN_ENDPT_TX]); - if (err) { - printf("axen%d: abort tx pipe failed: %s\n", - sc->axen_unit, usbd_errstr(err)); - } + usbd_abort_pipe(sc->axen_ep[AXEN_ENDPT_TX]); err = usbd_close_pipe(sc->axen_ep[AXEN_ENDPT_TX]); if (err) { printf("axen%d: close tx pipe failed: %s\n", @@ -1538,11 +1530,7 @@ axen_stop(struct axen_softc *sc) } if (sc->axen_ep[AXEN_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->axen_ep[AXEN_ENDPT_INTR]); - if (err) { - printf("axen%d: abort intr pipe failed: %s\n", - sc->axen_unit, usbd_errstr(err)); - } + usbd_abort_pipe(sc->axen_ep[AXEN_ENDPT_INTR]); err = usbd_close_pipe(sc->axen_ep[AXEN_ENDPT_INTR]); if (err) { printf("axen%d: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_cdce.c b/sys/dev/usb/if_cdce.c index 927b8ad09da..e7d0e3a9a94 100644 --- a/sys/dev/usb/if_cdce.c +++ b/sys/dev/usb/if_cdce.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_cdce.c,v 1.56 2013/11/11 12:38:16 pirofti Exp $ */ +/* $OpenBSD: if_cdce.c,v 1.57 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 1997, 1998, 1999, 2000-2003 Bill Paul <wpaul@windriver.com> @@ -463,10 +463,7 @@ cdce_stop(struct cdce_softc *sc) ifp->if_flags &= ~(IFF_RUNNING | IFF_OACTIVE); if (sc->cdce_bulkin_pipe != NULL) { - err = usbd_abort_pipe(sc->cdce_bulkin_pipe); - if (err) - printf("%s: abort rx pipe failed: %s\n", - sc->cdce_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->cdce_bulkin_pipe); err = usbd_close_pipe(sc->cdce_bulkin_pipe); if (err) printf("%s: close rx pipe failed: %s\n", @@ -475,10 +472,7 @@ cdce_stop(struct cdce_softc *sc) } if (sc->cdce_bulkout_pipe != NULL) { - err = usbd_abort_pipe(sc->cdce_bulkout_pipe); - if (err) - printf("%s: abort tx pipe failed: %s\n", - sc->cdce_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->cdce_bulkout_pipe); err = usbd_close_pipe(sc->cdce_bulkout_pipe); if (err) printf("%s: close tx pipe failed: %s\n", @@ -487,10 +481,7 @@ cdce_stop(struct cdce_softc *sc) } if (sc->cdce_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->cdce_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->cdce_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->cdce_intr_pipe); err = usbd_close_pipe(sc->cdce_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", diff --git a/sys/dev/usb/if_cue.c b/sys/dev/usb/if_cue.c index 27ea1cc4a7f..6fcb27fd496 100644 --- a/sys/dev/usb/if_cue.c +++ b/sys/dev/usb/if_cue.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_cue.c,v 1.63 2013/11/05 10:20:04 mpi Exp $ */ +/* $OpenBSD: if_cue.c,v 1.64 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: if_cue.c,v 1.40 2002/07/11 21:14:26 augustss Exp $ */ /* * Copyright (c) 1997, 1998, 1999, 2000 @@ -1190,11 +1190,7 @@ cue_stop(struct cue_softc *sc) /* Stop transfers. */ if (sc->cue_ep[CUE_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->cue_ep[CUE_ENDPT_RX]); - if (err) { - printf("%s: abort rx pipe failed: %s\n", - sc->cue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->cue_ep[CUE_ENDPT_RX]); err = usbd_close_pipe(sc->cue_ep[CUE_ENDPT_RX]); if (err) { printf("%s: close rx pipe failed: %s\n", @@ -1204,11 +1200,7 @@ cue_stop(struct cue_softc *sc) } if (sc->cue_ep[CUE_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->cue_ep[CUE_ENDPT_TX]); - if (err) { - printf("%s: abort tx pipe failed: %s\n", - sc->cue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->cue_ep[CUE_ENDPT_TX]); err = usbd_close_pipe(sc->cue_ep[CUE_ENDPT_TX]); if (err) { printf("%s: close tx pipe failed: %s\n", @@ -1218,11 +1210,7 @@ cue_stop(struct cue_softc *sc) } if (sc->cue_ep[CUE_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->cue_ep[CUE_ENDPT_INTR]); - if (err) { - printf("%s: abort intr pipe failed: %s\n", - sc->cue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->cue_ep[CUE_ENDPT_INTR]); err = usbd_close_pipe(sc->cue_ep[CUE_ENDPT_INTR]); if (err) { printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_kue.c b/sys/dev/usb/if_kue.c index 711ebf5b406..fe62c56eeae 100644 --- a/sys/dev/usb/if_kue.c +++ b/sys/dev/usb/if_kue.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_kue.c,v 1.70 2013/11/11 12:38:39 pirofti Exp $ */ +/* $OpenBSD: if_kue.c,v 1.71 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: if_kue.c,v 1.50 2002/07/16 22:00:31 augustss Exp $ */ /* * Copyright (c) 1997, 1998, 1999, 2000 @@ -1154,11 +1154,7 @@ kue_stop(struct kue_softc *sc) /* Stop transfers. */ if (sc->kue_ep[KUE_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->kue_ep[KUE_ENDPT_RX]); - if (err) { - printf("%s: abort rx pipe failed: %s\n", - sc->kue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->kue_ep[KUE_ENDPT_RX]); err = usbd_close_pipe(sc->kue_ep[KUE_ENDPT_RX]); if (err) { printf("%s: close rx pipe failed: %s\n", @@ -1168,11 +1164,7 @@ kue_stop(struct kue_softc *sc) } if (sc->kue_ep[KUE_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->kue_ep[KUE_ENDPT_TX]); - if (err) { - printf("%s: abort tx pipe failed: %s\n", - sc->kue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->kue_ep[KUE_ENDPT_TX]); err = usbd_close_pipe(sc->kue_ep[KUE_ENDPT_TX]); if (err) { printf("%s: close tx pipe failed: %s\n", @@ -1182,11 +1174,7 @@ kue_stop(struct kue_softc *sc) } if (sc->kue_ep[KUE_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->kue_ep[KUE_ENDPT_INTR]); - if (err) { - printf("%s: abort intr pipe failed: %s\n", - sc->kue_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->kue_ep[KUE_ENDPT_INTR]); err = usbd_close_pipe(sc->kue_ep[KUE_ENDPT_INTR]); if (err) { printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_mos.c b/sys/dev/usb/if_mos.c index 15cb4f3d5da..c6eb77065ab 100644 --- a/sys/dev/usb/if_mos.c +++ b/sys/dev/usb/if_mos.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_mos.c,v 1.21 2013/08/07 01:06:41 bluhm Exp $ */ +/* $OpenBSD: if_mos.c,v 1.22 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2008 Johann Christian Rode <jcrode@gmx.net> @@ -1378,11 +1378,7 @@ mos_stop(struct mos_softc *sc) /* Stop transfers. */ if (sc->mos_ep[MOS_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->mos_ep[MOS_ENDPT_RX]); - if (err) { - printf("%s: abort rx pipe failed: %s\n", - sc->mos_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->mos_ep[MOS_ENDPT_RX]); err = usbd_close_pipe(sc->mos_ep[MOS_ENDPT_RX]); if (err) { printf("%s: close rx pipe failed: %s\n", @@ -1392,11 +1388,7 @@ mos_stop(struct mos_softc *sc) } if (sc->mos_ep[MOS_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->mos_ep[MOS_ENDPT_TX]); - if (err) { - printf("%s: abort tx pipe failed: %s\n", - sc->mos_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->mos_ep[MOS_ENDPT_TX]); err = usbd_close_pipe(sc->mos_ep[MOS_ENDPT_TX]); if (err) { printf("%s: close tx pipe failed: %s\n", @@ -1406,11 +1398,7 @@ mos_stop(struct mos_softc *sc) } if (sc->mos_ep[MOS_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->mos_ep[MOS_ENDPT_INTR]); - if (err) { - printf("%s: abort intr pipe failed: %s\n", - sc->mos_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->mos_ep[MOS_ENDPT_INTR]); err = usbd_close_pipe(sc->mos_ep[MOS_ENDPT_INTR]); if (err) { printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_smsc.c b/sys/dev/usb/if_smsc.c index 37e4635c1c4..30e8abec6a3 100644 --- a/sys/dev/usb/if_smsc.c +++ b/sys/dev/usb/if_smsc.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_smsc.c,v 1.9 2013/08/07 01:06:42 bluhm Exp $ */ +/* $OpenBSD: if_smsc.c,v 1.10 2013/11/15 10:17:39 pirofti Exp $ */ /* $FreeBSD: src/sys/dev/usb/net/if_smsc.c,v 1.1 2012/08/15 04:03:55 gonzo Exp $ */ /*- * Copyright (c) 2012 @@ -670,11 +670,7 @@ smsc_stop(struct smsc_softc *sc) /* Stop transfers. */ if (sc->sc_ep[SMSC_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->sc_ep[SMSC_ENDPT_RX]); - if (err) { - printf("%s: abort rx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->sc_ep[SMSC_ENDPT_RX]); err = usbd_close_pipe(sc->sc_ep[SMSC_ENDPT_RX]); if (err) { printf("%s: close rx pipe failed: %s\n", @@ -684,11 +680,7 @@ smsc_stop(struct smsc_softc *sc) } if (sc->sc_ep[SMSC_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->sc_ep[SMSC_ENDPT_TX]); - if (err) { - printf("%s: abort tx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->sc_ep[SMSC_ENDPT_TX]); err = usbd_close_pipe(sc->sc_ep[SMSC_ENDPT_TX]); if (err) { printf("%s: close tx pipe failed: %s\n", @@ -698,11 +690,7 @@ smsc_stop(struct smsc_softc *sc) } if (sc->sc_ep[SMSC_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->sc_ep[SMSC_ENDPT_INTR]); - if (err) { - printf("%s: abort intr pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->sc_ep[SMSC_ENDPT_INTR]); err = usbd_close_pipe(sc->sc_ep[SMSC_ENDPT_INTR]); if (err) { printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_udav.c b/sys/dev/usb/if_udav.c index 0847dbe7146..b65ac2d2c27 100644 --- a/sys/dev/usb/if_udav.c +++ b/sys/dev/usb/if_udav.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_udav.c,v 1.63 2013/08/07 01:06:42 bluhm Exp $ */ +/* $OpenBSD: if_udav.c,v 1.64 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: if_udav.c,v 1.3 2004/04/23 17:25:25 itojun Exp $ */ /* $nabe: if_udav.c,v 1.3 2003/08/21 16:57:19 nabe Exp $ */ /* @@ -1274,10 +1274,7 @@ udav_stop(struct ifnet *ifp, int disable) /* Stop transfers */ /* RX endpoint */ if (sc->sc_pipe_rx != NULL) { - err = usbd_abort_pipe(sc->sc_pipe_rx); - if (err) - printf("%s: abort rx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_pipe_rx); err = usbd_close_pipe(sc->sc_pipe_rx); if (err) printf("%s: close rx pipe failed: %s\n", @@ -1287,10 +1284,7 @@ udav_stop(struct ifnet *ifp, int disable) /* TX endpoint */ if (sc->sc_pipe_tx != NULL) { - err = usbd_abort_pipe(sc->sc_pipe_tx); - if (err) - printf("%s: abort tx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_pipe_tx); err = usbd_close_pipe(sc->sc_pipe_tx); if (err) printf("%s: close tx pipe failed: %s\n", @@ -1302,10 +1296,7 @@ udav_stop(struct ifnet *ifp, int disable) /* XXX: Interrupt endpoint is not yet supported!! */ /* Interrupt endpoint */ if (sc->sc_pipe_intr != NULL) { - err = usbd_abort_pipe(sc->sc_pipe_intr); - if (err) - printf("%s: abort intr pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_pipe_intr); err = usbd_close_pipe(sc->sc_pipe_intr); if (err) printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_upl.c b/sys/dev/usb/if_upl.c index a9dabdde94e..916144a1512 100644 --- a/sys/dev/usb/if_upl.c +++ b/sys/dev/usb/if_upl.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_upl.c,v 1.54 2013/11/06 17:33:26 pirofti Exp $ */ +/* $OpenBSD: if_upl.c,v 1.55 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: if_upl.c,v 1.19 2002/07/11 21:14:26 augustss Exp $ */ /* * Copyright (c) 2000 The NetBSD Foundation, Inc. @@ -886,11 +886,7 @@ upl_stop(struct upl_softc *sc) /* Stop transfers. */ if (sc->sc_ep[UPL_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->sc_ep[UPL_ENDPT_RX]); - if (err) { - printf("%s: abort rx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->sc_ep[UPL_ENDPT_RX]); err = usbd_close_pipe(sc->sc_ep[UPL_ENDPT_RX]); if (err) { printf("%s: close rx pipe failed: %s\n", @@ -900,11 +896,7 @@ upl_stop(struct upl_softc *sc) } if (sc->sc_ep[UPL_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->sc_ep[UPL_ENDPT_TX]); - if (err) { - printf("%s: abort tx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->sc_ep[UPL_ENDPT_TX]); err = usbd_close_pipe(sc->sc_ep[UPL_ENDPT_TX]); if (err) { printf("%s: close tx pipe failed: %s\n", @@ -914,11 +906,7 @@ upl_stop(struct upl_softc *sc) } if (sc->sc_ep[UPL_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->sc_ep[UPL_ENDPT_INTR]); - if (err) { - printf("%s: abort intr pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->sc_ep[UPL_ENDPT_INTR]); err = usbd_close_pipe(sc->sc_ep[UPL_ENDPT_INTR]); if (err) { printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_url.c b/sys/dev/usb/if_url.c index 2fe3f704b60..f2ba13e006d 100644 --- a/sys/dev/usb/if_url.c +++ b/sys/dev/usb/if_url.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_url.c,v 1.67 2013/08/07 01:06:43 bluhm Exp $ */ +/* $OpenBSD: if_url.c,v 1.68 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: if_url.c,v 1.6 2002/09/29 10:19:21 martin Exp $ */ /* * Copyright (c) 2001, 2002 @@ -1138,10 +1138,7 @@ url_stop(struct ifnet *ifp, int disable) /* Stop transfers */ /* RX endpoint */ if (sc->sc_pipe_rx != NULL) { - err = usbd_abort_pipe(sc->sc_pipe_rx); - if (err) - printf("%s: abort rx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_pipe_rx); err = usbd_close_pipe(sc->sc_pipe_rx); if (err) printf("%s: close rx pipe failed: %s\n", @@ -1151,10 +1148,7 @@ url_stop(struct ifnet *ifp, int disable) /* TX endpoint */ if (sc->sc_pipe_tx != NULL) { - err = usbd_abort_pipe(sc->sc_pipe_tx); - if (err) - printf("%s: abort tx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_pipe_tx); err = usbd_close_pipe(sc->sc_pipe_tx); if (err) printf("%s: close tx pipe failed: %s\n", @@ -1166,10 +1160,7 @@ url_stop(struct ifnet *ifp, int disable) /* XXX: Interrupt endpoint is not yet supported!! */ /* Interrupt endpoint */ if (sc->sc_pipe_intr != NULL) { - err = usbd_abort_pipe(sc->sc_pipe_intr); - if (err) - printf("%s: abort intr pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_pipe_intr); err = usbd_close_pipe(sc->sc_pipe_intr); if (err) printf("%s: close intr pipe failed: %s\n", diff --git a/sys/dev/usb/if_urndis.c b/sys/dev/usb/if_urndis.c index fb3a1ed3142..6c8fc23e6e6 100644 --- a/sys/dev/usb/if_urndis.c +++ b/sys/dev/usb/if_urndis.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_urndis.c,v 1.42 2013/11/08 10:12:20 pirofti Exp $ */ +/* $OpenBSD: if_urndis.c,v 1.43 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2010 Jonathan Armani <armani@openbsd.org> @@ -1129,10 +1129,7 @@ urndis_stop(struct urndis_softc *sc) ifp->if_flags &= ~(IFF_RUNNING | IFF_OACTIVE); if (sc->sc_bulkin_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_bulkin_pipe); - if (err) - printf("%s: abort rx pipe failed: %s\n", - DEVNAME(sc), usbd_errstr(err)); + usbd_abort_pipe(sc->sc_bulkin_pipe); err = usbd_close_pipe(sc->sc_bulkin_pipe); if (err) printf("%s: close rx pipe failed: %s\n", @@ -1141,10 +1138,7 @@ urndis_stop(struct urndis_softc *sc) } if (sc->sc_bulkout_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_bulkout_pipe); - if (err) - printf("%s: abort tx pipe failed: %s\n", - DEVNAME(sc), usbd_errstr(err)); + usbd_abort_pipe(sc->sc_bulkout_pipe); err = usbd_close_pipe(sc->sc_bulkout_pipe); if (err) printf("%s: close tx pipe failed: %s\n", diff --git a/sys/dev/usb/if_wi_usb.c b/sys/dev/usb/if_wi_usb.c index 46fbb4c9aa5..ef36d18a5f6 100644 --- a/sys/dev/usb/if_wi_usb.c +++ b/sys/dev/usb/if_wi_usb.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if_wi_usb.c,v 1.59 2013/11/11 15:00:35 pirofti Exp $ */ +/* $OpenBSD: if_wi_usb.c,v 1.60 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2003 Dale Rahn. All rights reserved. @@ -442,11 +442,7 @@ wi_usb_detach(struct device *self, int flags) } if (sc->wi_usb_ep[WI_USB_ENDPT_INTR] != NULL) { - err = usbd_abort_pipe(sc->wi_usb_ep[WI_USB_ENDPT_INTR]); - if (err) { - printf("%s: abort intr pipe failed: %s\n", - sc->wi_usb_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->wi_usb_ep[WI_USB_ENDPT_INTR]); err = usbd_close_pipe(sc->wi_usb_ep[WI_USB_ENDPT_INTR]); if (err) { printf("%s: close intr pipe failed: %s\n", @@ -455,11 +451,7 @@ wi_usb_detach(struct device *self, int flags) sc->wi_usb_ep[WI_USB_ENDPT_INTR] = NULL; } if (sc->wi_usb_ep[WI_USB_ENDPT_TX] != NULL) { - err = usbd_abort_pipe(sc->wi_usb_ep[WI_USB_ENDPT_TX]); - if (err) { - printf("%s: abort tx pipe failed: %s\n", - sc->wi_usb_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->wi_usb_ep[WI_USB_ENDPT_TX]); err = usbd_close_pipe(sc->wi_usb_ep[WI_USB_ENDPT_TX]); if (err) { printf("%s: close tx pipe failed: %s\n", @@ -468,11 +460,7 @@ wi_usb_detach(struct device *self, int flags) sc->wi_usb_ep[WI_USB_ENDPT_TX] = NULL; } if (sc->wi_usb_ep[WI_USB_ENDPT_RX] != NULL) { - err = usbd_abort_pipe(sc->wi_usb_ep[WI_USB_ENDPT_RX]); - if (err) { - printf("%s: abort rx pipe failed: %s\n", - sc->wi_usb_dev.dv_xname, usbd_errstr(err)); - } + usbd_abort_pipe(sc->wi_usb_ep[WI_USB_ENDPT_RX]); err = usbd_close_pipe(sc->wi_usb_ep[WI_USB_ENDPT_RX]); if (err) { printf("%s: close rx pipe failed: %s\n", diff --git a/sys/dev/usb/ubsa.c b/sys/dev/usb/ubsa.c index 52db4218839..9d543a2f589 100644 --- a/sys/dev/usb/ubsa.c +++ b/sys/dev/usb/ubsa.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ubsa.c,v 1.59 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: ubsa.c,v 1.60 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: ubsa.c,v 1.5 2002/11/25 00:51:33 fvdl Exp $ */ /*- * Copyright (c) 2002, Alexander Kabaev <kan.FreeBSD.org>. @@ -645,11 +645,7 @@ ubsa_close(void *addr, int portno) DPRINTF(("ubsa_close: close\n")); if (sc->sc_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->sc_dev.dv_xname, - usbd_errstr(err)); + usbd_abort_pipe(sc->sc_intr_pipe); err = usbd_close_pipe(sc->sc_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", diff --git a/sys/dev/usb/uchcom.c b/sys/dev/usb/uchcom.c index 1f2ac628219..8f92ebe0b5b 100644 --- a/sys/dev/usb/uchcom.c +++ b/sys/dev/usb/uchcom.c @@ -1,4 +1,4 @@ -/* $OpenBSD: uchcom.c,v 1.18 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: uchcom.c,v 1.19 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: uchcom.c,v 1.1 2007/09/03 17:57:37 tshiozak Exp $ */ /* @@ -895,10 +895,7 @@ uchcom_close_intr_pipe(struct uchcom_softc *sc) return; if (sc->sc_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_intr_pipe); err = usbd_close_pipe(sc->sc_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", diff --git a/sys/dev/usb/umbg.c b/sys/dev/usb/umbg.c index 74a365a0443..3d84cf65bb6 100644 --- a/sys/dev/usb/umbg.c +++ b/sys/dev/usb/umbg.c @@ -1,4 +1,4 @@ -/* $OpenBSD: umbg.c,v 1.21 2013/04/15 09:23:02 mglocker Exp $ */ +/* $OpenBSD: umbg.c,v 1.22 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2007 Marc Balmer <mbalmer@openbsd.org> @@ -298,10 +298,7 @@ umbg_detach(struct device *self, int flags) usb_rem_task(sc->sc_udev, &sc->sc_task); if (sc->sc_bulkin_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_bulkin_pipe); - if (err) - printf("%s: abort rx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_bulkin_pipe); err = usbd_close_pipe(sc->sc_bulkin_pipe); if (err) printf("%s: close rx pipe failed: %s\n", @@ -309,10 +306,7 @@ umbg_detach(struct device *self, int flags) sc->sc_bulkin_pipe = NULL; } if (sc->sc_bulkout_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_bulkout_pipe); - if (err) - printf("%s: abort tx pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_bulkout_pipe); err = usbd_close_pipe(sc->sc_bulkout_pipe); if (err) printf("%s: close tx pipe failed: %s\n", diff --git a/sys/dev/usb/umct.c b/sys/dev/usb/umct.c index 680568f27d3..6fc031809c3 100644 --- a/sys/dev/usb/umct.c +++ b/sys/dev/usb/umct.c @@ -1,4 +1,4 @@ -/* $OpenBSD: umct.c,v 1.38 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: umct.c,v 1.39 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: umct.c,v 1.10 2003/02/23 04:20:07 simonb Exp $ */ /* * Copyright (c) 2001 The NetBSD Foundation, Inc. @@ -565,10 +565,7 @@ umct_close(void *addr, int portno) DPRINTF(("umct_close: close\n")); if (sc->sc_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_intr_pipe); err = usbd_close_pipe(sc->sc_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", diff --git a/sys/dev/usb/umodem.c b/sys/dev/usb/umodem.c index 06ec7d42bdf..6cff78aa6fb 100644 --- a/sys/dev/usb/umodem.c +++ b/sys/dev/usb/umodem.c @@ -1,4 +1,4 @@ -/* $OpenBSD: umodem.c,v 1.52 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: umodem.c,v 1.53 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: umodem.c,v 1.45 2002/09/23 05:51:23 simonb Exp $ */ /* @@ -437,10 +437,7 @@ umodem_close(void *addr, int portno) DPRINTF(("umodem_close: sc=%p\n", sc)); if (sc->sc_notify_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_notify_pipe); - if (err) - printf("%s: abort notify pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_notify_pipe); err = usbd_close_pipe(sc->sc_notify_pipe); if (err) printf("%s: close notify pipe failed: %s\n", diff --git a/sys/dev/usb/umsm.c b/sys/dev/usb/umsm.c index 755c3d83bac..dbb35630f7b 100644 --- a/sys/dev/usb/umsm.c +++ b/sys/dev/usb/umsm.c @@ -1,4 +1,4 @@ -/* $OpenBSD: umsm.c,v 1.94 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: umsm.c,v 1.95 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2008 Yojiro UO <yuo@nui.org> @@ -486,11 +486,7 @@ umsm_close(void *addr, int portno) return; if (sc->sc_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->sc_dev.dv_xname, - usbd_errstr(err)); + usbd_abort_pipe(sc->sc_intr_pipe); err = usbd_close_pipe(sc->sc_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", diff --git a/sys/dev/usb/uplcom.c b/sys/dev/usb/uplcom.c index 3de4b2f4525..ec0454c5909 100644 --- a/sys/dev/usb/uplcom.c +++ b/sys/dev/usb/uplcom.c @@ -1,4 +1,4 @@ -/* $OpenBSD: uplcom.c,v 1.61 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: uplcom.c,v 1.62 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: uplcom.c,v 1.29 2002/09/23 05:51:23 simonb Exp $ */ /* * Copyright (c) 2001 The NetBSD Foundation, Inc. @@ -747,10 +747,7 @@ uplcom_close(void *addr, int portno) DPRINTF(("uplcom_close: close\n")); if (sc->sc_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_intr_pipe); err = usbd_close_pipe(sc->sc_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", diff --git a/sys/dev/usb/usbdi.c b/sys/dev/usb/usbdi.c index 8c5ca8027ce..8104133ee6b 100644 --- a/sys/dev/usb/usbdi.c +++ b/sys/dev/usb/usbdi.c @@ -1,4 +1,4 @@ -/* $OpenBSD: usbdi.c,v 1.66 2013/11/13 13:48:08 pirofti Exp $ */ +/* $OpenBSD: usbdi.c,v 1.67 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: usbdi.c,v 1.103 2002/09/27 15:37:38 provos Exp $ */ /* $FreeBSD: src/sys/dev/usb/usbdi.c,v 1.28 1999/11/17 22:33:49 n_hibma Exp $ */ @@ -529,7 +529,7 @@ usbd_interface2endpoint_descriptor(struct usbd_interface *iface, u_int8_t index) return (iface->endpoints[index].edesc); } -usbd_status +void usbd_abort_pipe(struct usbd_pipe *pipe) { struct usbd_xfer *xfer; @@ -538,7 +538,7 @@ usbd_abort_pipe(struct usbd_pipe *pipe) #ifdef DIAGNOSTIC if (pipe == NULL) { printf("usbd_abort_pipe: pipe==NULL\n"); - return (USBD_NORMAL_COMPLETION); + return; } #endif s = splusb(); @@ -558,8 +558,6 @@ usbd_abort_pipe(struct usbd_pipe *pipe) } pipe->aborting = 0; splx(s); - - return (USBD_NORMAL_COMPLETION); } usbd_status diff --git a/sys/dev/usb/usbdi.h b/sys/dev/usb/usbdi.h index acac65d1111..ceb1d09245a 100644 --- a/sys/dev/usb/usbdi.h +++ b/sys/dev/usb/usbdi.h @@ -1,4 +1,4 @@ -/* $OpenBSD: usbdi.h,v 1.58 2013/11/13 13:48:08 pirofti Exp $ */ +/* $OpenBSD: usbdi.h,v 1.59 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: usbdi.h,v 1.62 2002/07/11 21:14:35 augustss Exp $ */ /* $FreeBSD: src/sys/dev/usb/usbdi.h,v 1.18 1999/11/17 22:33:49 n_hibma Exp $ */ @@ -102,7 +102,7 @@ void usbd_get_xfer_status(struct usbd_xfer *xfer, void **priv, void **buffer, u_int32_t *count, usbd_status *status); usb_endpoint_descriptor_t *usbd_interface2endpoint_descriptor( struct usbd_interface *iface, u_int8_t address); -usbd_status usbd_abort_pipe(struct usbd_pipe *pipe); +void usbd_abort_pipe(struct usbd_pipe *pipe); usbd_status usbd_clear_endpoint_stall(struct usbd_pipe *pipe); usbd_status usbd_clear_endpoint_stall_async(struct usbd_pipe *pipe); void usbd_clear_endpoint_toggle(struct usbd_pipe *pipe); diff --git a/sys/dev/usb/uticom.c b/sys/dev/usb/uticom.c index 9beddabfdbc..eeb649afff1 100644 --- a/sys/dev/usb/uticom.c +++ b/sys/dev/usb/uticom.c @@ -1,4 +1,4 @@ -/* $OpenBSD: uticom.c,v 1.22 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: uticom.c,v 1.23 2013/11/15 10:17:39 pirofti Exp $ */ /* * Copyright (c) 2005 Dmitry Komissaroff <dxi@mail.ru>. * @@ -782,10 +782,7 @@ uticom_close(void *addr, int portno) DPRINTF(("%s: uticom_close: close\n", sc->sc_dev.dv_xname)); if (sc->sc_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->sc_dev.dv_xname, usbd_errstr(err)); + usbd_abort_pipe(sc->sc_intr_pipe); err = usbd_close_pipe(sc->sc_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", diff --git a/sys/dev/usb/uvscom.c b/sys/dev/usb/uvscom.c index 2fb1d9c81fb..56900b76299 100644 --- a/sys/dev/usb/uvscom.c +++ b/sys/dev/usb/uvscom.c @@ -1,4 +1,4 @@ -/* $OpenBSD: uvscom.c,v 1.29 2013/11/15 08:25:31 pirofti Exp $ */ +/* $OpenBSD: uvscom.c,v 1.30 2013/11/15 10:17:39 pirofti Exp $ */ /* $NetBSD: uvscom.c,v 1.9 2003/02/12 15:36:20 ichiro Exp $ */ /*- * Copyright (c) 2001-2002, Shunsuke Akiyama <akiyama@jp.FreeBSD.org>. @@ -773,11 +773,7 @@ uvscom_close(void *addr, int portno) uvscom_shutdown(sc); if (sc->sc_intr_pipe != NULL) { - err = usbd_abort_pipe(sc->sc_intr_pipe); - if (err) - printf("%s: abort interrupt pipe failed: %s\n", - sc->sc_dev.dv_xname, - usbd_errstr(err)); + usbd_abort_pipe(sc->sc_intr_pipe); err = usbd_close_pipe(sc->sc_intr_pipe); if (err) printf("%s: close interrupt pipe failed: %s\n", |