diff options
| author | Alexander Bluhm <bluhm@cvs.openbsd.org> | 2016-07-19 21:28:44 +0000 |
|---|---|---|
| committer | Alexander Bluhm <bluhm@cvs.openbsd.org> | 2016-07-19 21:28:44 +0000 |
| commit | 8609142de031d423133ac5b7a7d236324959c8f3 (patch) | |
| tree | 8944287710d211dd8a69946f67886f05b18553ab /sys | |
| parent | 732cbba36a2f84f1e76551b3b51ad71fdb3bb455 (diff) | |
Plug an mbuf leak in the error path of tcp signature in tcp_output().
OK claudio@ henning@
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/netinet/tcp_output.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/sys/netinet/tcp_output.c b/sys/netinet/tcp_output.c index bf67b1bf383..77e2321ec84 100644 --- a/sys/netinet/tcp_output.c +++ b/sys/netinet/tcp_output.c @@ -1,4 +1,4 @@ -/* $OpenBSD: tcp_output.c,v 1.117 2016/06/13 21:24:43 bluhm Exp $ */ +/* $OpenBSD: tcp_output.c,v 1.118 2016/07/19 21:28:43 bluhm Exp $ */ /* $NetBSD: tcp_output.c,v 1.16 1997/06/03 16:17:09 kml Exp $ */ /* @@ -931,12 +931,16 @@ send: tdb = gettdbbysrcdst(rtable_l2(tp->t_inpcb->inp_rtableid), 0, &src, &dst, IPPROTO_TCP); - if (tdb == NULL) + if (tdb == NULL) { + m_freem(m); return (EPERM); + } if (tcp_signature(tdb, tp->pf, m, th, iphlen, 0, - mtod(m, caddr_t) + hdrlen - optlen + sigoff) < 0) + mtod(m, caddr_t) + hdrlen - optlen + sigoff) < 0) { + m_freem(m); return (EINVAL); + } } #endif /* TCP_SIGNATURE */ |