diff options
| author | Claudio Jeker <claudio@cvs.openbsd.org> | 2006-04-26 17:02:14 +0000 |
|---|---|---|
| committer | Claudio Jeker <claudio@cvs.openbsd.org> | 2006-04-26 17:02:14 +0000 |
| commit | a52e4194c3e078719dfae4b3a3d4091b0448e5a7 (patch) | |
| tree | 14fa19cd23cb7f3ad0b25facccb42631b2c00fa5 /sys | |
| parent | f636952fb4f2bf6ca36384b06adf5421523df192 (diff) | |
Missed the goto in the error path. This resulted in an access to a NULL
pointer and a panic later on. Be more careful Claudio! OK henning@
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/net/route.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/sys/net/route.c b/sys/net/route.c index 59ec31519d9..f028152f8b5 100644 --- a/sys/net/route.c +++ b/sys/net/route.c @@ -1,4 +1,4 @@ -/* $OpenBSD: route.c,v 1.71 2006/04/22 19:43:06 claudio Exp $ */ +/* $OpenBSD: route.c,v 1.72 2006/04/26 17:02:13 claudio Exp $ */ /* $NetBSD: route.c,v 1.14 1996/02/13 22:00:46 christos Exp $ */ /* @@ -368,6 +368,7 @@ rtredirect(struct sockaddr *dst, struct sockaddr *gateway, u_int32_t *stat = NULL; struct rt_addrinfo info; struct ifaddr *ifa; + struct ifnet *ifp = NULL; splassert(IPL_SOFTNET); @@ -376,6 +377,7 @@ rtredirect(struct sockaddr *dst, struct sockaddr *gateway, error = ENETUNREACH; goto out; } + ifp = ifa->ifa_ifp; rt = rtalloc1(dst, 0); /* * If the redirect isn't from our current router for this dst, @@ -455,7 +457,7 @@ out: info.rti_info[RTAX_GATEWAY] = gateway; info.rti_info[RTAX_NETMASK] = netmask; info.rti_info[RTAX_AUTHOR] = src; - rt_missmsg(RTM_REDIRECT, &info, flags, ifa->ifa_ifp, error); + rt_missmsg(RTM_REDIRECT, &info, flags, ifp, error); } /* |