diff options
| author | Artur Grabowski <art@cvs.openbsd.org> | 2008-07-14 15:17:09 +0000 |
|---|---|---|
| committer | Artur Grabowski <art@cvs.openbsd.org> | 2008-07-14 15:17:09 +0000 |
| commit | be44fb7c92a794ed0f763df30622ddcc5cfcf310 (patch) | |
| tree | c0ca3eee5d3632c0972f8529cb92ffd1867c914f /sys | |
| parent | a8ecea4e8b9e95881ca47660e4e7c35dc7694f0a (diff) | |
Don't lock timeouts in db_show_callout.
All cpus are stopped and this cpu blocks all interrupts. It doesn't make
sense to grab locks that ddb can then jump past with longjmp.
Noticed by Pierre Riteau. I just forgot about the bug until reminded
today.
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/kern/kern_timeout.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/sys/kern/kern_timeout.c b/sys/kern/kern_timeout.c index 5916de193a8..9a8afbf2c55 100644 --- a/sys/kern/kern_timeout.c +++ b/sys/kern/kern_timeout.c @@ -1,4 +1,4 @@ -/* $OpenBSD: kern_timeout.c,v 1.27 2008/07/11 14:18:39 blambert Exp $ */ +/* $OpenBSD: kern_timeout.c,v 1.28 2008/07/14 15:17:08 art Exp $ */ /* * Copyright (c) 2001 Thomas Nordin <nordin@openbsd.org> * Copyright (c) 2000-2001 Artur Grabowski <art@openbsd.org> @@ -354,10 +354,8 @@ db_show_callout(db_expr_t addr, int haddr, db_expr_t count, char *modif) db_printf("ticks now: %d\n", ticks); db_printf(" ticks wheel arg func\n"); - mtx_enter(&timeout_mutex); db_show_callout_bucket(&timeout_todo); for (b = 0; b < BUCKETS; b++) db_show_callout_bucket(&timeout_wheel[b]); - mtx_leave(&timeout_mutex); } #endif |