diff options
| author | Angelos D. Keromytis <angelos@cvs.openbsd.org> | 2000-05-15 03:38:41 +0000 |
|---|---|---|
| committer | Angelos D. Keromytis <angelos@cvs.openbsd.org> | 2000-05-15 03:38:41 +0000 |
| commit | ce823177133fc4819905a133ea19cb1d19d359b1 (patch) | |
| tree | 66315cfca0a2286bbb4295f56bded3e460ef5a1f /sys | |
| parent | 6641f33fef6e1cfff30446fdf7b45a17eb053213 (diff) | |
Add comment on input MSS calculation based on previous PMTUD results,
as per TCP-imply IETF WG draft(s). The correct approach is to just use
the relevant interface's MTU.
Diffstat (limited to 'sys')
| -rw-r--r-- | sys/netinet/tcp_input.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/sys/netinet/tcp_input.c b/sys/netinet/tcp_input.c index 1ed40938e1b..ee7650e0487 100644 --- a/sys/netinet/tcp_input.c +++ b/sys/netinet/tcp_input.c @@ -1,4 +1,4 @@ -/* $OpenBSD: tcp_input.c,v 1.60 2000/04/28 00:31:48 itojun Exp $ */ +/* $OpenBSD: tcp_input.c,v 1.61 2000/05/15 03:38:40 angelos Exp $ */ /* $NetBSD: tcp_input.c,v 1.23 1996/02/13 23:43:44 christos Exp $ */ /* @@ -2790,6 +2790,13 @@ tcp_mss(tp, offer) * if there's an mtu associated with the route and we support * path MTU discovery for the underlying protocol family, use it. */ + /* + * XXX It's wrong to use PMTU values to determine the MSS we + * are going to advertise; we should only use the input interface's + * MTU instead (see draft-ietf-tcpimpl-pmtud-03.txt). tcp_mss() + * should be changed to be aware whether it's called for input or + * output MSS calculation, and act accordingly. + */ if (rt->rt_rmx.rmx_mtu) { /* * One may wish to lower MSS to take into account options, |