diff options
| author | Theo de Raadt <deraadt@cvs.openbsd.org> | 2019-06-28 13:35:06 +0000 |
|---|---|---|
| committer | Theo de Raadt <deraadt@cvs.openbsd.org> | 2019-06-28 13:35:06 +0000 |
| commit | 61656abc7ff84215165af1bd464bc053b3b66158 (patch) | |
| tree | c7eabb0c4fa9faa024e724e99c240c40da07ca42 /usr.bin/look | |
| parent | 18603ebf99fbb890ae9666cb0c4aa9f879e7edaa (diff) | |
When system calls indicate an error they return -1, not some arbitrary
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
Diffstat (limited to 'usr.bin/look')
| -rw-r--r-- | usr.bin/look/look.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/usr.bin/look/look.c b/usr.bin/look/look.c index baf3486d852..fa0b7353bc2 100644 --- a/usr.bin/look/look.c +++ b/usr.bin/look/look.c @@ -1,4 +1,4 @@ -/* $OpenBSD: look.c,v 1.22 2018/08/11 11:00:34 mestre Exp $ */ +/* $OpenBSD: look.c,v 1.23 2019/06/28 13:35:01 deraadt Exp $ */ /* $NetBSD: look.c,v 1.7 1995/08/31 22:41:02 jtc Exp $ */ /*- @@ -118,7 +118,7 @@ main(int argc, char *argv[]) if (termchar != '\0' && (p = strchr(string, termchar)) != NULL) *++p = '\0'; - if ((fd = open(file, O_RDONLY, 0)) < 0 || fstat(fd, &sb)) + if ((fd = open(file, O_RDONLY, 0)) == -1 || fstat(fd, &sb) == -1) err(2, "%s", file); if (sb.st_size > SIZE_MAX) errc(2, EFBIG, "%s", file); |