diff options
author | Ingo Schwarze <schwarze@cvs.openbsd.org> | 2010-08-20 00:53:36 +0000 |
---|---|---|
committer | Ingo Schwarze <schwarze@cvs.openbsd.org> | 2010-08-20 00:53:36 +0000 |
commit | 1d54fff5bbfd9a3e9b14412f6c71f7da02b8016e (patch) | |
tree | 4710e10697d4d628a74dae5b159b265d7848aca4 /usr.bin/mandoc/mdoc_validate.c | |
parent | 4028699c62453407e9248e833fbfbcc4dab7be21 (diff) |
Implement a simple, consistent user interface for error handling.
We now have sufficient practical experience to know what we want,
so this is intended to be final:
- provide -Wlevel (warning, error or fatal) to select what you care about
- provide -Wstop to stop after parsing a file with warnings you care about
- provide consistent exit status codes for those warnings you care about
- fully document what warnings, errors and fatal errors mean
- remove all other cruft from the user interface, less is more:
- remove all -f knobs along with the whole -f option
- remove the old -Werror because calling warnings "fatal" is silly
- always finish parsing each file, unless fatal errors prevent that
This commit also includes a couple of related simplifications behind
the scenes regarding error handling.
Feedback and OK kristaps@; Joerg Sonnenberger (NetBSD) and
Sascha Wildner (DragonFly BSD) agree with the general direction.
Diffstat (limited to 'usr.bin/mandoc/mdoc_validate.c')
-rw-r--r-- | usr.bin/mandoc/mdoc_validate.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/usr.bin/mandoc/mdoc_validate.c b/usr.bin/mandoc/mdoc_validate.c index 7fed23dc8b2..228df954fac 100644 --- a/usr.bin/mandoc/mdoc_validate.c +++ b/usr.bin/mandoc/mdoc_validate.c @@ -1,4 +1,4 @@ -/* $Id: mdoc_validate.c,v 1.67 2010/07/31 21:43:07 schwarze Exp $ */ +/* $Id: mdoc_validate.c,v 1.68 2010/08/20 00:53:35 schwarze Exp $ */ /* * Copyright (c) 2008, 2009, 2010 Kristaps Dzonsons <kristaps@bsd.lv> * @@ -477,12 +477,8 @@ check_text(struct mdoc *m, int ln, int pos, char *p) if (c) { p += c - 1; pos += c - 1; - continue; - } - - c = mdoc_pmsg(m, ln, pos, MANDOCERR_BADESCAPE); - if ( ! (MDOC_IGN_ESCAPE & m->pflags) && ! c) - return(c); + } else + mdoc_pmsg(m, ln, pos, MANDOCERR_BADESCAPE); } return(1); |