diff options
| author | Damien Miller <djm@cvs.openbsd.org> | 2022-01-14 03:32:53 +0000 |
|---|---|---|
| committer | Damien Miller <djm@cvs.openbsd.org> | 2022-01-14 03:32:53 +0000 |
| commit | c6069cd1c4354387b6da68e0ecac662641fad237 (patch) | |
| tree | d936eff30089fb4069e626d9518ecd6eef36d581 /usr.bin/ssh | |
| parent | b187b775482589aa3cec0239f4be21a7db658fd7 (diff) | |
sshsk_sign: trim call to sshkey_fingerprint()
the resulting fingerprint doesn't appear to be used for anything,
and we end up leaking it.
from Pedro Martelletto; ok dtucker & me
Diffstat (limited to 'usr.bin/ssh')
| -rw-r--r-- | usr.bin/ssh/ssh-sk-client.c | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/usr.bin/ssh/ssh-sk-client.c b/usr.bin/ssh/ssh-sk-client.c index afd808025fc..71d639e9571 100644 --- a/usr.bin/ssh/ssh-sk-client.c +++ b/usr.bin/ssh/ssh-sk-client.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ssh-sk-client.c,v 1.10 2021/10/28 02:54:18 djm Exp $ */ +/* $OpenBSD: ssh-sk-client.c,v 1.11 2022/01/14 03:32:52 djm Exp $ */ /* * Copyright (c) 2019 Google LLC * @@ -230,7 +230,6 @@ sshsk_sign(const char *provider, struct sshkey *key, u_int compat, const char *pin) { int oerrno, r = SSH_ERR_INTERNAL_ERROR; - char *fp = NULL; struct sshbuf *kbuf = NULL, *req = NULL, *resp = NULL; *sigp = NULL; @@ -256,12 +255,6 @@ sshsk_sign(const char *provider, struct sshkey *key, goto out; } - if ((fp = sshkey_fingerprint(key, SSH_FP_HASH_DEFAULT, - SSH_FP_DEFAULT)) == NULL) { - error_f("sshkey_fingerprint failed"); - r = SSH_ERR_ALLOC_FAIL; - goto out; - } if ((r = client_converse(req, &resp, SSH_SK_HELPER_SIGN)) != 0) goto out; |