If trimming menu item text, show key if it would take up less than a

quarter of the space; from Alexis Hildebrandt.

Also new sentence, new line in tmux.1, from jmc.

1 files changed, 15 insertions, 11 deletions

diff --git a/usr.bin/tmux/menu.c b/usr.bin/tmux/menu.c
index 2ed80a5a21b..bb0d6c574a5 100644
--- a/usr.bin/tmux/menu.c
+++ b/usr.bin/tmux/menu.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: menu.c,v 1.40 2021/10/22 17:12:50 nicm Exp $ */
+/* $OpenBSD: menu.c,v 1.41 2021/11/11 09:22:33 nicm Exp $ */
 
 /*
  * Copyright (c) 2019 Nicholas Marriott <nicholas.marriott@gmail.com>
@@ -89,22 +89,26 @@ menu_add_item(struct menu *menu, const struct menu_item *item,
 		keylen = strlen(key) + 3; /* 3 = space and two brackets */
 
 		/*
-		 * Only add the key if there is space for the entire item text
-		 * and the key.
+		 * Add the key if it is shorter than a quarter of the available
+		 * space or there is space for the entire item text and the
+		 * key.
 		 */
-		if (keylen >= max_width || slen >= max_width - keylen)
+		if (keylen <= max_width / 4)
+			max_width -= keylen;
+		else if (keylen >= max_width || slen >= max_width - keylen)
 			key = NULL;
 	}
 
+	if (slen > max_width) {
+		max_width--;
+		suffix = ">";
+	}
 	if (key != NULL)
-		xasprintf(&name, "%s#[default] #[align=right](%s)", s, key);
-	else {
-		if (slen > max_width) {
-			max_width--;
-			suffix = ">";
-		}
+		xasprintf(&name, "%.*s%s#[default] #[align=right](%s)",
+		    (int)max_width, s, suffix, key);
+	else
 		xasprintf(&name, "%.*s%s", (int)max_width, s, suffix);
-	}
+
 	new_item->name = name;
 	free(s);