summaryrefslogtreecommitdiff
path: root/usr.bin/w/w.c
diff options
context:
space:
mode:
authorAngelos D. Keromytis <angelos@cvs.openbsd.org>2002-06-08 22:57:35 +0000
committerAngelos D. Keromytis <angelos@cvs.openbsd.org>2002-06-08 22:57:35 +0000
commitb7c4485ea2d19d61893a97c9ee0692081c06d5e2 (patch)
treeefd7393efab9949567efa45c1a9408d3ec1bac49 /usr.bin/w/w.c
parent584d6525b38474e6be80ccab62474bbea6f34171 (diff)
No need to be setgid kmem anymore.
Diffstat (limited to 'usr.bin/w/w.c')
-rw-r--r--usr.bin/w/w.c23
1 files changed, 8 insertions, 15 deletions
diff --git a/usr.bin/w/w.c b/usr.bin/w/w.c
index f3acb102a78..2a03fbbb55e 100644
--- a/usr.bin/w/w.c
+++ b/usr.bin/w/w.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: w.c,v 1.36 2002/02/19 18:38:02 mpech Exp $ */
+/* $OpenBSD: w.c,v 1.37 2002/06/08 22:57:34 angelos Exp $ */
/*-
* Copyright (c) 1980, 1991, 1993, 1994
@@ -43,7 +43,7 @@ static char copyright[] =
#if 0
static char sccsid[] = "@(#)w.c 8.4 (Berkeley) 4/16/94";
#else
-static char *rcsid = "$OpenBSD: w.c,v 1.36 2002/02/19 18:38:02 mpech Exp $";
+static char *rcsid = "$OpenBSD: w.c,v 1.37 2002/06/08 22:57:34 angelos Exp $";
#endif
#endif /* not lint */
@@ -178,21 +178,14 @@ main(argc, argv)
argc -= optind;
argv += optind;
- /*
- * Discard setgid privileges if not the running kernel so that bad
- * guys can't print interesting stuff from kernel memory.
- */
- if (nlistf != NULL || memf != NULL) {
- setegid(getgid());
- setgid(getgid());
+ if (nlistf == NULL && memf == NULL) {
+ if ((kd = kvm_openfiles(nlistf, memf, NULL, KVM_NO_FILES, errbuf)) == NULL)
+ errx(1, "%s", errbuf);
+ } else {
+ if ((kd = kvm_openfiles(nlistf, memf, NULL, O_RDONLY, errbuf)) == NULL)
+ errx(1, "%s", errbuf);
}
- if ((kd = kvm_openfiles(nlistf, memf, NULL, O_RDONLY, errbuf)) == NULL)
- errx(1, "%s", errbuf);
-
- setegid(getgid());
- setgid(getgid());
-
(void)time(&now);
if ((ut = fopen(_PATH_UTMP, "r")) == NULL)
err(1, "%s", _PATH_UTMP);