diff options
author | Scott Soule Cheloha <cheloha@cvs.openbsd.org> | 2022-12-04 23:50:52 +0000 |
---|---|---|
committer | Scott Soule Cheloha <cheloha@cvs.openbsd.org> | 2022-12-04 23:50:52 +0000 |
commit | 7119931719c16b3e14f3ca5213b351e777080528 (patch) | |
tree | db01a02e50effc999803525fd4173a9bc9a2646f /usr.bin/xargs | |
parent | 45b7e652cd98369e756e28db16f4aad0626aec0d (diff) |
userspace: remove vestigial '?' cases from top-level getopt(3) loops
getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument. We can
handle this case with the "default" failure case with no loss of
legibility. Hence, remove all the redundant "case '?':" lines.
Prompted by dlg@. With help from dlg@ and millert@.
Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2
ok naddy@ millert@ dlg@
Diffstat (limited to 'usr.bin/xargs')
-rw-r--r-- | usr.bin/xargs/xargs.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/usr.bin/xargs/xargs.c b/usr.bin/xargs/xargs.c index a7c5c89988b..ff17caaf436 100644 --- a/usr.bin/xargs/xargs.c +++ b/usr.bin/xargs/xargs.c @@ -1,4 +1,4 @@ -/* $OpenBSD: xargs.c,v 1.35 2020/07/19 13:19:25 schwarze Exp $ */ +/* $OpenBSD: xargs.c,v 1.36 2022/12/04 23:50:50 cheloha Exp $ */ /* $FreeBSD: xargs.c,v 1.51 2003/05/03 19:09:11 obrien Exp $ */ /*- @@ -169,10 +169,9 @@ main(int argc, char *argv[]) case '0': zflag = 1; break; - case '?': default: usage(); - } + } argc -= optind; argv += optind; |