diff options
| author | Alexandre Ratchov <ratchov@cvs.openbsd.org> | 2012-12-01 12:13:35 +0000 |
|---|---|---|
| committer | Alexandre Ratchov <ratchov@cvs.openbsd.org> | 2012-12-01 12:13:35 +0000 |
| commit | d3f9dc4666ce23b58b1f59f228377a61f548a86f (patch) | |
| tree | bcacbb531d7a49a0cd16a69f6b2c7c2e21ee3e25 /usr.bin | |
| parent | 884d87fdc2aed6a786b094d8557a14de9fc4318c (diff) | |
remove misleading XXXs and TODOs
Diffstat (limited to 'usr.bin')
| -rw-r--r-- | usr.bin/sndiod/dsp.c | 4 | ||||
| -rw-r--r-- | usr.bin/sndiod/midi.c | 11 | ||||
| -rw-r--r-- | usr.bin/sndiod/sock.c | 8 |
3 files changed, 5 insertions, 18 deletions
diff --git a/usr.bin/sndiod/dsp.c b/usr.bin/sndiod/dsp.c index cd76acf292a..91b3ec68bdf 100644 --- a/usr.bin/sndiod/dsp.c +++ b/usr.bin/sndiod/dsp.c @@ -1,4 +1,4 @@ -/* $OpenBSD: dsp.c,v 1.1 2012/11/23 07:03:28 ratchov Exp $ */ +/* $OpenBSD: dsp.c,v 1.2 2012/12/01 12:13:34 ratchov Exp $ */ /* * Copyright (c) 2008-2012 Alexandre Ratchov <alex@caoua.org> * @@ -570,7 +570,7 @@ cmap_add(struct cmap *p, void *in, void *out, int vol, int todo) istart = p->istart; inext = p->inext; nch = p->nch; - v = vol; /* XXX */ + v = vol; /* * map/mix input on the output diff --git a/usr.bin/sndiod/midi.c b/usr.bin/sndiod/midi.c index cdb5800e7d9..1b7717aac17 100644 --- a/usr.bin/sndiod/midi.c +++ b/usr.bin/sndiod/midi.c @@ -1,4 +1,4 @@ -/* $OpenBSD: midi.c,v 1.5 2012/11/30 22:26:34 ratchov Exp $ */ +/* $OpenBSD: midi.c,v 1.6 2012/12/01 12:13:34 ratchov Exp $ */ /* * Copyright (c) 2008-2012 Alexandre Ratchov <alex@caoua.org> * @@ -14,12 +14,6 @@ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ -/* - * TODO - * - * use shadow variables (to save NRPNs, LSB of controller) - * in the midi merger - */ #include <stdio.h> #include <stdlib.h> #include <string.h> @@ -216,7 +210,7 @@ midi_tag(struct midi *ep, unsigned int tag) } /* - * broadcast the given message to other members of the thru box + * broadcast the given message to other endpoints */ void midi_send(struct midi *iep, unsigned char *msg, int size) @@ -256,7 +250,6 @@ midi_send(struct midi *iep, unsigned char *msg, int size) } } - /* * determine if we have gained more input tickets, and if so call the * fill() call-back to notify the i/o layer that it can send more data diff --git a/usr.bin/sndiod/sock.c b/usr.bin/sndiod/sock.c index 456a297ad94..9e614f3515a 100644 --- a/usr.bin/sndiod/sock.c +++ b/usr.bin/sndiod/sock.c @@ -1,4 +1,4 @@ -/* $OpenBSD: sock.c,v 1.3 2012/11/30 20:48:00 ratchov Exp $ */ +/* $OpenBSD: sock.c,v 1.4 2012/12/01 12:13:34 ratchov Exp $ */ /* * Copyright (c) 2008-2012 Alexandre Ratchov <alex@caoua.org> * @@ -925,7 +925,6 @@ sock_hello(struct sock *f) } s->mix.maxweight = f->opt->maxweight; s->dup = f->opt->dup; - /* XXX: must convert to slot rate */ f->slot = s; return 1; } @@ -1398,7 +1397,6 @@ sock_buildmsg(struct sock *f) } if (f->midi != NULL && f->midi->obuf.used > 0) { - /* XXX: use tickets */ size = f->midi->obuf.used; if (size > AMSG_DATAMAX) size = AMSG_DATAMAX; @@ -1518,7 +1516,6 @@ sock_read(struct sock *f) f->wtodo = sizeof(struct amsg); f->rstate = SOCK_RMSG; f->rtodo = sizeof(struct amsg); - /* XXX: call sock_wmsg() ? */ #ifdef DEBUG if (log_level >= 4) { sock_log(f); @@ -1555,9 +1552,6 @@ sock_write(struct sock *f) f->wtodo = 0xdeadbeef; break; } - /* - * XXX: why not set f->wtodo in sock_wmsg() ? - */ f->wstate = SOCK_WDATA; f->wsize = f->wtodo = ntohl(f->wmsg.u.data.size); /* PASSTHROUGH */ |