diff options
| author | Philip Guenther <guenther@cvs.openbsd.org> | 2013-10-27 18:49:26 +0000 |
|---|---|---|
| committer | Philip Guenther <guenther@cvs.openbsd.org> | 2013-10-27 18:49:26 +0000 |
| commit | 16dd0bc9233cb54f0ec67d3a15ed34cf0c0622a4 (patch) | |
| tree | b74c439451aba73beacdde390768247ffee4f15a /usr.sbin/httpd | |
| parent | ce610d8a76997841f3ea191357ab19c1dbcdd968 (diff) | |
If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.
ok deraadt@
Diffstat (limited to 'usr.sbin/httpd')
| -rw-r--r-- | usr.sbin/httpd/src/modules/keynote/mod_keynote.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/usr.sbin/httpd/src/modules/keynote/mod_keynote.c b/usr.sbin/httpd/src/modules/keynote/mod_keynote.c index cd382992a0d..4ef5ae8c3e6 100644 --- a/usr.sbin/httpd/src/modules/keynote/mod_keynote.c +++ b/usr.sbin/httpd/src/modules/keynote/mod_keynote.c @@ -459,7 +459,7 @@ keynote_fake_assertion(request_rec *r, int sessid, X509 *cert, EVP_PKEY *pkey, X char *akey, *ikey, *buf, *stext, *itext; char before[15], after[15]; char *timecomp, *timecomp2; - char *fmt = "Authorizer: \"%s%s\"\nLicensees: \"%s%s\"\n" + static const char fmt[] = "Authorizer: \"%s%s\"\nLicensees: \"%s%s\"\n" "Conditions: %s >= \"%s\" && %s <= \"%s\";\n"; if (pkey && pkey->type != EVP_PKEY_RSA && pkey->type != EVP_PKEY_DSA) { |