refactor classes in PackingElement to share more code.

- all files go through FileBase, all directories go through DirBase.
- dirclass() is used to switch classes based on final /, so that
@sample, @extra, and @file  all take directories as well.
- set NoDuplicateNames() more thoroughly.
- make sure all no-default-conflict objects are correct.

compute_fullname() checks for absolute paths, allowed for @sample and
@extra.

lastfile only gets set for actual files.

special names like INSTALL are only checked for normal files.

add a CVSTag class for @comment $OpenBSD$, so that these get sorted first.

Changes for make-plist rewrite:

clone() method that can create copies of all hash objects, to specialize
if needed.

add_object() method so that add() is now new() followed by add_object()
for most objects (useful for cloned objects).

Check that plist has a name in pkg_create, allowing PackingList to write
unnamed plists.

1 files changed, 2 insertions, 2 deletions

diff --git a/usr.sbin/pkg_add/TODO b/usr.sbin/pkg_add/TODO
index bea481b2e49..60804231756 100644
--- a/usr.sbin/pkg_add/TODO
+++ b/usr.sbin/pkg_add/TODO
@@ -3,8 +3,8 @@
 + handle package dependencies to the level of the old implementation
 + handle chmod/chown to the level of the old implementation
 + handle PKGPATH
++ replace symlinks with @symlink commands at pkg_create time
++ basic validation of packing list at end of reading it...
 - add better error handling
 - let package delete log files it cannot delete
-- replace symlinks with @symlink commands at pkg_create time
 - smart package dependency handling
-- basic validation of packing list at end of reading it...