summaryrefslogtreecommitdiff
path: root/usr.sbin/sa
diff options
context:
space:
mode:
authorScott Soule Cheloha <cheloha@cvs.openbsd.org>2022-12-04 23:50:52 +0000
committerScott Soule Cheloha <cheloha@cvs.openbsd.org>2022-12-04 23:50:52 +0000
commit7119931719c16b3e14f3ca5213b351e777080528 (patch)
treedb01a02e50effc999803525fd4173a9bc9a2646f /usr.sbin/sa
parent45b7e652cd98369e756e28db16f4aad0626aec0d (diff)
userspace: remove vestigial '?' cases from top-level getopt(3) loops
getopt(3) returns '?' when it encounters a flag not present in the in the optstring or if a flag is missing its option argument. We can handle this case with the "default" failure case with no loss of legibility. Hence, remove all the redundant "case '?':" lines. Prompted by dlg@. With help from dlg@ and millert@. Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2 ok naddy@ millert@ dlg@
Diffstat (limited to 'usr.sbin/sa')
-rw-r--r--usr.sbin/sa/main.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/usr.sbin/sa/main.c b/usr.sbin/sa/main.c
index fa7cb2fde79..eb30ae0a5dc 100644
--- a/usr.sbin/sa/main.c
+++ b/usr.sbin/sa/main.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: main.c,v 1.18 2022/02/22 17:22:29 deraadt Exp $ */
+/* $OpenBSD: main.c,v 1.19 2022/12/04 23:50:51 cheloha Exp $ */
/*
* Copyright (c) 1994 Christopher G. Demetriou
* All rights reserved.
@@ -164,7 +164,6 @@ main(int argc, char **argv)
if (errstr)
errx(1, "-v %s: %s", optarg, errstr);
break;
- case '?':
default:
(void)fprintf(stderr,
"usage: %s [-abcDdfijKklmnqrstu] [-v cutoff]"