diff options
| author | Claudio Jeker <claudio@cvs.openbsd.org> | 2020-05-02 14:12:18 +0000 |
|---|---|---|
| committer | Claudio Jeker <claudio@cvs.openbsd.org> | 2020-05-02 14:12:18 +0000 |
| commit | 58e74cce8f5d68c5542608f80ef9fb0ebad9d340 (patch) | |
| tree | 9fe9e9c6f60ebd183ff99904b7089a14fb33aca1 /usr.sbin | |
| parent | 92e9a22b1e51680e5aa684b40c95354f1e6f056f (diff) | |
The warning "bad AGGREGATOR, AS 0 not allowed ..." is not very helpful.
Make it a log_debug() instead to reduce the noise seen on most full feeds.
The DFZ is currently not clean enough to properly drop AS 0 in that case.
OK job@ deraadt@
Diffstat (limited to 'usr.sbin')
| -rw-r--r-- | usr.sbin/bgpd/rde.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/usr.sbin/bgpd/rde.c b/usr.sbin/bgpd/rde.c index 0fb3c618b91..2d5a6639887 100644 --- a/usr.sbin/bgpd/rde.c +++ b/usr.sbin/bgpd/rde.c @@ -1,4 +1,4 @@ -/* $OpenBSD: rde.c,v 1.501 2020/02/12 10:33:56 claudio Exp $ */ +/* $OpenBSD: rde.c,v 1.502 2020/05/02 14:12:17 claudio Exp $ */ /* * Copyright (c) 2003, 2004 Henning Brauer <henning@openbsd.org> @@ -1678,8 +1678,10 @@ bad_flags: /* 4-byte ready server take the default route */ if (memcmp(p, &zero, sizeof(u_int32_t)) == 0) { /* As per RFC7606 use "attribute discard" here. */ - log_peer_warnx(&peer->conf, "bad AGGREGATOR, " - "AS 0 not allowed, attribute discarded"); + char *pfmt = log_fmt_peer(&peer->conf); + log_debug("%s: bad AGGREGATOR, " + "AS 0 not allowed, attribute discarded", pfmt); + free(pfmt); plen += attr_len; break; } |