summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-07Add FALLTHROUGH comments where appropriate. Patch from jjelen at redhatDarren Tucker
via bz#2687.
2018-09-07clarify that goto error in alloc_all_endpoints_fixed_ep() always returnsmiko
USBD_INVAL. ok mpi@
2018-09-07move initial jack count to alloc_all_endpoints(), and reset count to zeromiko
in free_all_jacks(). ok stsp@ ratchov@
2018-09-07ssh -MM requires confirmation for all operations that change theDamien Miller
multiplexing state, not just new sessions. mention that confirmation is checked via ssh-askpass
2018-09-07Add retguard macros to cpu_switchto, setjmp, longjmp.mortimer
ok kettenis@
2018-09-06Use getline() for the network bulk code. Also make the parser better byClaudio Jeker
doing tokenizing on spaces and correctly ignore comments. This should make this feature in general more robust. OK benno@
2018-09-06Drop SSL_CIPHER_ALGORITHM2_AEAD flag.Joel Sing
All of our algorithm_mac == SSL_AEAD cipher suites use EVP_AEAD, so we can condition on that rather than having a separate redundant flag. ok tb@
2018-09-06get rid of a temp file, noted by claudio@Sebastian Benoit
2018-09-06If we cannot stop the endpoint when aborting a transfer assume thatMartin Pieuchot
the device is gone and give back the descriptor to the stack. Without this usbd_abort_pipe() could end up in an infinite loop. Issue reported by Tom Murphy.
2018-09-06when people update /etc/example/bgpd.conf, the forget to update theSebastian Benoit
regression test. - make bgpd-example just check the config file we ship, to make sure the config is not broken - make bgpd-printconf checks a config file, writes the parsed output to a file and checks if that file is parsable config, i.e. this check makes sure that the config printer produces parsable configuration. This way we still have to update the regression tests when the syntax changes, and we fail if the commited example is bad, but we do not fail just because someone forgot to update a file here. ok claudio
2018-09-06Remove unused af argument from unmask()kn
This has been unused for years. While here, zap the duplicate function signature from pfctl.h (already present in pfctl_parser.h); spotted by sashan, thanks. OK sashan
2018-09-06Fill netmask AF-independently in print_host()kn
Instead of masking the host address in two different ways, just fill it no matter the address family. In case of AF_INET, setting the extra 96 bit does not hurt. While here, stop resetting `af' for no reason and move up the variable declaration. OK benno sashan
2018-09-06Do not close the socket twice in netcat.Alexander Bluhm
from Nan Xiao; OK tb@
2018-09-06fix whitespaceJonathan Gray
2018-09-06Implement 64-bit DMA support in sdhc(4).Patrick Wildt
tested in snaps ok kettenis@
2018-09-06execute the same code for failure of assign_all_jacks_automatically()miko
and attach_all_mididevs(). this ensures unbind_all_jacks() and usbd_deactivate() happen for both cases. ok ratchov@
2018-09-06sync icmp_mtudisc_clone() with icmp6_mtudisc_clone(); prompted by bluhm@miko
2018-09-05Move AF-specific mask logic from callers into set_ipmask()kn
Instead of doing the same dance with every caller, check for user provided mask or address familiy specific maximum inside the function itself. Feedback and OK claudio
2018-09-05synchronize resolver code with smtpdEric Faurot
2018-09-05Implement most prefixlen operations as OP_RANGE (prefixlen A - B).Claudio Jeker
Simplify the RDE logic this way and make it possible to load such ranges into a much faster lookup trie for prefix-sets. When printing the config bgpd tries to use the nices way to express the rule: e.g. match from any prefix 18.0.0.0/8 prefixlen 8 - 32 becomes match from any prefix 18.0.0.0/8 or-longer Apart from that there is no user visible change because of this. OK sthen@
2018-09-05Use the newer/more sensible names for EVP_MD_CTX_* functions.Joel Sing
EVP_MD_CTX_create -> EVP_MD_CTX_new EVP_MD_CTX_destroy -> EVP_MD_CTX_free This should make the intent more obvious and reduce head scratching during code reviews. Raised by tb@
2018-09-05Correctly clear the current cipher state, when changing cipher state.Joel Sing
When a renegotiation results in a change of cipher suite, the renegotation would fail if it switched from AEAD to non-AEAD or vice versa. This is due to the fact that the previous EVP_AEAD or EVP_CIPHER state remained, resulting in incorrect logic that caused MAC failures. Rename ssl_clear_cipher_ctx() to ssl_clear_cipher_state() and split it into separate read/write components, then call these functions from the appropriate places when a ChangeCipherSpec message is being processed. Also, remove the separate ssl_clear_hash_ctx() calls and fold these into the ssl_clear_cipher_{read,write}_state() functions. Issue reported by Bernard Spil, who also tested this diff. ok tb@
2018-09-05Back out 1.4, it broke thingsJoshua Stein
2018-09-05Serialize synchronous commands with a rwlock.Martin Pieuchot
Prevent triggering an assert if two drivers try to submit a command at the same time. Issue reported by Tom Murphy.
2018-04-27Import lpd, a re-implementation of the lpr daemon following the latestEric Faurot
OpenBSD coding practices (fork+exec/privsep/pledge/...). It is only intended to replace the lpd(8) daemon for the moment, not the lpr(1), lprm(1), lpq(1) and lpc(8) commands. This is a work in progress. The server part should be fairly functionnal, but the printer part is not complete: remote printers should work, for local printers it depends on the setup. Anyway, at this point it's better in the tree than rotting on my disk. ok deraadt@
2018-09-05rename flagEric Faurot
ok gilles@
2018-09-05Adjust after change of struct filter_as.Claudio Jeker
OK phessler@
2018-09-05Change the way as_compare() and aspath_match() handle 'neighbor-as'. InsteadClaudio Jeker
of doing the condition before calling aspath_match() just pass the neighbor-as down to as_compare() which then has all needed data for the lookup. While doing this also remove one of the as fields in struct filter_as since the min/max fields can be reused for unary operations. OK denis@ phessler@
2018-09-05factor error code in icmp6_mtudisc_clone(); ok kn@ florian@miko
2018-09-05Add "op" column for CP_SPIN. Diff from fukaumi at soum.co.jpYASUOKA Masahiko
ok solene
2018-09-05rename token to match naming conventionGilles Chehade
ok eric@
2018-09-05Use error label in host_if()kn
This brings it in line with host() and host_dns(). OK sashan miko
2018-09-05Change verification of communities a bit. Move the flag checking first sinceClaudio Jeker
it is currently terminal and then do the length check. If that one triggers do a treat-as-withdraw but at the same time drop the bad attribute since it is better to not have invalid attributes in the Adj-RIB-In since most code does not expect that. OK benno@
2018-09-05some text improvements from matt schwartz; ok gillesJason McIntyre
2018-09-05do not use the literal string "label" as our example label; ok gillesJason McIntyre
2018-09-05rework the text about "label" somewhat for clarity; ok ericJason McIntyre
2018-09-05Add defines for dealing with PCID support in cr3Philip Guenther
ok mlarkin@
2018-09-05use timing-safe compares for checking results in signature verificationDamien Miller
(there are no known attacks, this is just inexpensive prudence) feedback and ok tb@ jsing@
2018-09-04Forgot to rename pf_frent_holes() prototype in previous commit.Alexander Bluhm
2018-09-04Avoid traversing the list of fragment entris to check whether theAlexander Bluhm
pf(4) reassembly is complete. Instead count the holes that are created when inserting a fragment. If there are no holes left, the fragments are continuous. idea from claudio@; OK claudio@ sashan@
2018-09-04remove useless session flagEric Faurot
ok gilles@
2018-09-04move readmes detection to find_extractible, so that only changed/new readmesMarc Espie
are recorded. Be more specific and list those readmes in alphabetic order at end.
2018-09-04document PKGSTEM changesMarc Espie
2018-09-04upon mda failure, smtpd would assume tempfail and retry. this is at oddsGilles Chehade
with the other MTA which assume a permfail unless the exit status is one of a specific set. make smtpd honour the same exit statuses as postfix. note that all errors that occur before the user mda is executed (fork, pipe and related) are still considered tempfail, only errors coming from the mda itself are handled as permfail. this commit is a temporary solution as i believe the SIGCHLD handler is way more complex than it should be and we'll simplify it after 6.4 is out. ok eric@
2018-09-04Correct usbd_abort_pipe() signature.Martin Pieuchot
From Artturi Alm.
2018-09-04Introduce inet4applymask() which does the same as inet6applymask() andClaudio Jeker
can be used instead of doing direct fiddling around with struct in_addr. Use it in a few cases where it makes the code more similar between INET and INET6 case. OK denis@
2018-09-04Instead of bzero() use an assinment to zero struct in_addr.Claudio Jeker
2018-09-04remove unused flagsEric Faurot
2018-09-04kevent: Don't poll for nonzero timeouts < 1us.cheloha
Instead of truncating nanosecond timeouts to zero here and polling, we should round up to a delay of at least a tick, just like all the other timespec syscalls. Fixed in NetBSD kern_event.c v1.62 and FreeBSD r247804. ok millert@ visa@
2018-09-03Remove bits about MODMONO_NANT in the lang/mono section; devel/nant doesBrian Callahan
not exist anymore. ok jca@ daniel@