summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-04-19altq includes are goneHenning Brauer
yes, we normally leave this for theo, but this triggered my final "any altq bits left" check and I had to wait for a build anyway...
2014-04-19stop installing altq includesHenning Brauer
2014-04-19now that if_snd is a proper ifqueue, this cast diesHenning Brauer
2014-04-19ifnet's if_snd becomes a regular ifqueue instead of ifaltq, the need toHenning Brauer
keep ifqueue and ifaltq in sync is gone and thus the comment obsolete, and finally there is no more need to include if_altq.h either
2014-04-19minus altq tentacles, plus missing IF_DROP here as wellHenning Brauer
2014-04-19Try to be clear why struct mrt_config nodes are allocated andClaudio Jeker
assigned to struct mrt pointers. I may need to rethink this later but lets hope this does not confuse more people and analyzers.
2014-04-19Fix some serious pointer-arithmatic-magic-number-unchecked-return eyebleedBob Beck
that I stumbled into here and got stuck with. If modern society can get past selling daughters for cows, surely we can decide to write modern C code in an "application" that is probably 3 lines of shell/python/cgi away from talking to the internet in a lot of places.. (This file still needs a lot more love though) "oh god yuck" deraadt@ ok tedu@
2014-04-19KNF.Joel Sing
2014-04-19syncTheo de Raadt
2014-04-19Repair some indent to be more KNF, and break instead of fallthrough toTheo de Raadt
default which does break
2014-04-19one small tweak to avoid ever going off the end of a string.Ted Unangst
2014-04-19improved checking for invalid hashes. from solar designerTed Unangst
2014-04-19Once great men lived here... giants... gods... once, but long ago.Ted Unangst
2014-04-19the valkyries have come for rsh as wellTed Unangst
2014-04-19Delete futile calls to RAND_seed. ok djmTed Unangst
2014-04-19sigh, another driver fiddling with altq outside #ifdef ALTQHenning Brauer
2014-04-19kill altq bits here as wellHenning Brauer
2014-04-19(void) cast strlcpy() call that uses truncation as part of its parsingGilles Chehade
logic to extract at most sizeof buf - 1 bytes from source
2014-04-19More KNF.Joel Sing
2014-04-19(void) cast a strlcpy that cannot truncateGilles Chehade
2014-04-19(void) cast strlcpy/strlcat/snprintf calls that cannot truncateGilles Chehade
2014-04-19remove altq bits here, tooHenning Brauer
(i was convinced i committed that yesterday already, hrm)
2014-04-19(void) cast strlcpy() calls that cannot truncateGilles Chehade
2014-04-19(void) cast strlcat() and snprintf() that cannot truncateGilles Chehade
be a bit more strict with an strlcat() truncation by causing it to fail in table_create() instead of later in parse.y - in both cases, this would cause smtpd to fatal() at startup if a table has a config file too large
2014-04-19(void) cast strlcpy() calls that cannot truncateGilles Chehade
2014-04-19(void) cast a snprintf() call that can't possibly truncate unless weGilles Chehade
suddenly supported a cipher with a name that's > 200 bytes long ... ... in which case harmless truncation would occur and we'd have to readjust our buffer
2014-04-19Fix display of destination IP when host is an IP address.Florian Obser
Pointed out by and OK benno@
2014-04-19(void) cast snprintf calls that cannot truncateGilles Chehade
2014-04-19(void) cast a strlcpy() that cannot truncateGilles Chehade
(void) cast a few snprintf()/strlcat() that cannot truncate and that would be harmless if they could
2014-04-19(cast) void two strlcpy() and a snprintf() that cannot truncateGilles Chehade
2014-04-19(void) cast strlcpy/strlcat/snprintf calls that cannot truncate (and wouldGilles Chehade
be harmless in this case if they could)
2014-04-19kill a stray \Theo de Raadt
2014-04-19(void) cast strlcpy/strlcat/snprintf that cannot truncateGilles Chehade
2014-04-19(void) cast strlcpy() and snprintf() that cannot truncateGilles Chehade
2014-04-19(void) cast snprintf() and strlcat() calls that cannot truncateGilles Chehade
2014-04-19(void) cast strlcpy() / strlcat() / snprintf() that cannot truncateGilles Chehade
(void) cast a few calls that are ok to truncate because they are not used in anything critical / unsafe, but just to make some debug/info logs a bit more informative
2014-04-19Lacking a proof that--for this implementation--exposure of MontgomeryPhilip Guenther
multiplication or RSA blinding parameters doesn't permit retroactive timing analysis of the secrets, we'll do the stupidly cheap thing and cleanse them before freeing them. ok deraadt@
2014-04-19More KNF.Joel Sing
2014-04-19(void) cast some strlcat() calls that cannot truncateGilles Chehade
add a few fatalx() calls at places where it shouldn't fail, we'll assess which one may be relaxed later as this code is not finished nor plugged yet.
2014-04-19Remove hacky workaround for Cray T3E.Theo de Raadt
ok guenther
2014-04-19More KNF.Joel Sing
2014-04-19oops, typo got into changeTheo de Raadt
2014-04-19add missing checks to strlcpy() when copying envelope "destination" bufferGilles Chehade
to the mda delivery buffer. we should never hit these unless we mistakenly change the value of a define, better be safe than sorry. (void) cast strlcpy/strlcat that cannot truncate or that we know and want to truncate rather than lose (informative data not used by smtpd but intended to help the human reading the log)
2014-04-19shrink pf by 445 lines.Henning Brauer
while there, get rid of the altq ioctls and assciated now obsolete code
2014-04-19when receiving mail for user+tag@ and maildir is setup, we create a .tagGilles Chehade
subdirectory in the maildir, add missing check to strlcat() so that if path with .tag exceeds SMTPD_MAXPATHLEN we fail instead of creating a .tag dir that's truncated. (void) cast strlcpy()/strlcat() that cannot truncate
2014-04-19More KNF.Joel Sing
2014-04-19(void) cast strlcat(), they can't truncateGilles Chehade
2014-04-19unchecked strlcat() call in expand_to_text() may cause aliases expansion toGilles Chehade
fail later, make it fail early. (void) cast other calls, they are detected and handled correctly later
2014-04-19Add missing man page descriptions for the following IPv6 sysctls:logan
-maxdynroutes -maxifprefixes -maxifdefrouters -neighborgcthresh OK from sthen@, claudio@ and henning@
2014-04-19malloc + strlcpy -> strdupTheo de Raadt