summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-04-19(void) cast strlcpy() and snprintf() that cannot truncateGilles Chehade
2014-04-19(void) cast snprintf() and strlcat() calls that cannot truncateGilles Chehade
2014-04-19(void) cast strlcpy() / strlcat() / snprintf() that cannot truncateGilles Chehade
(void) cast a few calls that are ok to truncate because they are not used in anything critical / unsafe, but just to make some debug/info logs a bit more informative
2014-04-19Lacking a proof that--for this implementation--exposure of MontgomeryPhilip Guenther
multiplication or RSA blinding parameters doesn't permit retroactive timing analysis of the secrets, we'll do the stupidly cheap thing and cleanse them before freeing them. ok deraadt@
2014-04-19More KNF.Joel Sing
2014-04-19(void) cast some strlcat() calls that cannot truncateGilles Chehade
add a few fatalx() calls at places where it shouldn't fail, we'll assess which one may be relaxed later as this code is not finished nor plugged yet.
2014-04-19Remove hacky workaround for Cray T3E.Theo de Raadt
ok guenther
2014-04-19More KNF.Joel Sing
2014-04-19oops, typo got into changeTheo de Raadt
2014-04-19add missing checks to strlcpy() when copying envelope "destination" bufferGilles Chehade
to the mda delivery buffer. we should never hit these unless we mistakenly change the value of a define, better be safe than sorry. (void) cast strlcpy/strlcat that cannot truncate or that we know and want to truncate rather than lose (informative data not used by smtpd but intended to help the human reading the log)
2014-04-19shrink pf by 445 lines.Henning Brauer
while there, get rid of the altq ioctls and assciated now obsolete code
2014-04-19when receiving mail for user+tag@ and maildir is setup, we create a .tagGilles Chehade
subdirectory in the maildir, add missing check to strlcat() so that if path with .tag exceeds SMTPD_MAXPATHLEN we fail instead of creating a .tag dir that's truncated. (void) cast strlcpy()/strlcat() that cannot truncate
2014-04-19More KNF.Joel Sing
2014-04-19(void) cast strlcat(), they can't truncateGilles Chehade
2014-04-19unchecked strlcat() call in expand_to_text() may cause aliases expansion toGilles Chehade
fail later, make it fail early. (void) cast other calls, they are detected and handled correctly later
2014-04-19Add missing man page descriptions for the following IPv6 sysctls:logan
-maxdynroutes -maxifprefixes -maxifdefrouters -neighborgcthresh OK from sthen@, claudio@ and henning@
2014-04-19malloc + strlcpy -> strdupTheo de Raadt
2014-04-19(void) cast strlcpy(), it cannot truncateGilles Chehade
(void) cast strlcat(), they are detected and handled later
2014-04-19remove the altq enable/attach and disable/detach bitsHenning Brauer
2014-04-19bye bye altq bitsHenning Brauer
2014-04-19(void) cast this strlcpy(), it cannot truncateGilles Chehade
2014-04-19another questionable "optimization": de used tulip_ifstart_one insteadHenning Brauer
of tulip_ifstart if the sendqueue was empty, but only if altq wasn't compiled in (i. e., that's a _compile time_ decision and not based on wether altq was actually used). just use tulip_ifstart all the time, as before in our regular kernels. kill tulip_ifstart_one completely. makes sense to sthen
2014-04-19unifdef ENOTDIR, everyone has itTheo de Raadt
2014-04-19remove very questionable altq "optimization" - claudio and I can'tHenning Brauer
convince ourselves that that was right to begin with. anyway, begone.
2014-04-19all I wanted to do is removing the altq special casing, but then it turnedHenning Brauer
out the entire codepath is unreachable. glad I'm not our ppp maintainer, he has work to do. kill that unreachable code, with & ok claudio
2014-04-19remove altq special casing.Henning Brauer
big WTF regarding the fastq use there while verifying w/ claudio, but that's for the ppp maintainer and unrelated
2014-04-19Don't panic if we're trying to disestablish an MSI but the hardware is gone.Mark Kettenis
tested by & ok mlarkin@
2014-04-19We'll interpret a (void) cast on snprintf() to mean it's been verified thatPhilip Guenther
truncation is either desirable, not an issue, or is detected and handled later ok deraadt@
2014-04-19We'll interpret a (void) cast on snprintf() to mean it's been verified thatPhilip Guenther
truncation is either desirable, not an issue, or is detected and handled later ok deraadt@
2014-04-19these strlcpy can't truncate, the copy is from a buffer to a buffer of sameGilles Chehade
size and the first buffer handles the truncation already
2014-04-19bye byeHenning Brauer
2014-04-19cast (void) this strlcpy(), it can't fail copying a small constant stringGilles Chehade
into a much larger buffer
2014-04-19Use somewhat harsher language and better examples; demonstrate thatTheo de Raadt
non-dangerous use functions is difficult. ok guenther
2014-04-19when copying socket path, check that we didnt truncate it which would causeGilles Chehade
the following connect() to fail.
2014-04-19the altq versions of the IFQ_* macros can finally go. chances of thisHenning Brauer
file becoming readable increase.
2014-04-19Demonstrate correct usage of snprintf (regarding overflow detection)Theo de Raadt
ok guenther
2014-04-19Split inet(3) into three pages by decade: 1980s -> inet_lnaof(3),Philip Guenther
1990s -> inet_addr(3), 2000s and beyond -> inet_ntop(3). ok tedu@ (who also noted the timeline) deraadt@ jmc@
2014-04-19it's ok for strlcpy to fail here though it can't, cast voidGilles Chehade
2014-04-19egd is goneTheo de Raadt
2014-04-19 /*Henning Brauer
* altq for loop is just for debugging. * only used when called for loop interface (not for * a simplex interface). */ bye bye!
2014-04-19The internal ssl2_* functions and variables are gonePhilip Guenther
2014-04-19More KNF.Joel Sing
2014-04-19Add SSL_OP_NO_TLSv1_1 and SSL_OP_NO_TLSv1_2Philip Guenther
Document that SSL_OP_NO_SSLv2 is a no-op now
2014-04-19-option ALTQHenning Brauer
ALTQ has served us well for years and was extremely important not just for us, but for the entire bandwidth management arena. Back when we got altq, the subject was not yet well researched and understood, which is why altq is the framework with pluggable schedulers it is. Kenjiro Cho (kjc@) did an amazing job there. Now, more than 10 years later, we do have a good understanding and can use a simpler framework with just one priority queueing and one bandwidth shaping mechanism each - the new queueing subsystem. Last not least because it is incredibly painful to maintain both in parallel, it is time for altq to depart. Farewell, thanks for many years of good service. Everybody using any form of "not just fifo" queueing owes Kenjiro a lot. At least buy him a beer when you meet him. And, allow me this personal note, thanks Kenjiro, working with you on the topic has always been a great pleasure and I learned a lot from you. Thanks!
2014-04-19use an appropriate name for this variable.Igor Sobrado
ok millert@
2014-04-19do not mark od(1) as deprecated.Igor Sobrado
ok jmc@, millert@
2014-04-19More KNF and style consistency tweaksPhilip Guenther
2014-04-19tiny fix: Remove duplicate rows, they appeared after importing less 444Alexandr Shadchin
suggested Daniel Dickman
2014-04-19More KNF.Joel Sing
2014-04-19More KNF.Joel Sing