Age | Commit message (Collapse) | Author |
|
|
|
|
|
(void) cast a few calls that are ok to truncate because they are not used
in anything critical / unsafe, but just to make some debug/info logs a bit
more informative
|
|
multiplication or RSA blinding parameters doesn't permit retroactive
timing analysis of the secrets, we'll do the stupidly cheap thing and
cleanse them before freeing them.
ok deraadt@
|
|
|
|
add a few fatalx() calls at places where it shouldn't fail, we'll assess
which one may be relaxed later as this code is not finished nor plugged
yet.
|
|
ok guenther
|
|
|
|
|
|
to the mda delivery buffer. we should never hit these unless we mistakenly
change the value of a define, better be safe than sorry.
(void) cast strlcpy/strlcat that cannot truncate or that we know and want
to truncate rather than lose (informative data not used by smtpd but
intended to help the human reading the log)
|
|
while there, get rid of the altq ioctls and assciated now obsolete code
|
|
subdirectory in the maildir, add missing check to strlcat() so that if path
with .tag exceeds SMTPD_MAXPATHLEN we fail instead of creating a .tag dir
that's truncated.
(void) cast strlcpy()/strlcat() that cannot truncate
|
|
|
|
|
|
fail later, make it fail early.
(void) cast other calls, they are detected and handled correctly later
|
|
-maxdynroutes
-maxifprefixes
-maxifdefrouters
-neighborgcthresh
OK from sthen@, claudio@ and henning@
|
|
|
|
(void) cast strlcat(), they are detected and handled later
|
|
|
|
|
|
|
|
of tulip_ifstart if the sendqueue was empty, but only if altq wasn't
compiled in (i. e., that's a _compile time_ decision and not based on
wether altq was actually used).
just use tulip_ifstart all the time, as before in our regular kernels.
kill tulip_ifstart_one completely.
makes sense to sthen
|
|
|
|
convince ourselves that that was right to begin with. anyway, begone.
|
|
out the entire codepath is unreachable. glad I'm not our ppp maintainer, he
has work to do.
kill that unreachable code, with & ok claudio
|
|
big WTF regarding the fastq use there while verifying w/ claudio, but
that's for the ppp maintainer and unrelated
|
|
tested by & ok mlarkin@
|
|
truncation is either desirable, not an issue, or is detected and handled later
ok deraadt@
|
|
truncation is either desirable, not an issue, or is detected and handled later
ok deraadt@
|
|
size and the first buffer handles the truncation already
|
|
|
|
into a much larger buffer
|
|
non-dangerous use functions is difficult.
ok guenther
|
|
the following connect() to fail.
|
|
file becoming readable increase.
|
|
ok guenther
|
|
1990s -> inet_addr(3), 2000s and beyond -> inet_ntop(3).
ok tedu@ (who also noted the timeline) deraadt@ jmc@
|
|
|
|
|
|
* altq for loop is just for debugging.
* only used when called for loop interface (not for
* a simplex interface).
*/
bye bye!
|
|
|
|
|
|
Document that SSL_OP_NO_SSLv2 is a no-op now
|
|
ALTQ has served us well for years and was extremely important not just for
us, but for the entire bandwidth management arena. Back when we got altq,
the subject was not yet well researched and understood, which is why altq
is the framework with pluggable schedulers it is. Kenjiro Cho (kjc@) did an
amazing job there.
Now, more than 10 years later, we do have a good understanding and can use
a simpler framework with just one priority queueing and one bandwidth
shaping mechanism each - the new queueing subsystem. Last not least because
it is incredibly painful to maintain both in parallel, it is time for altq
to depart. Farewell, thanks for many years of good service. Everybody
using any form of "not just fifo" queueing owes Kenjiro a lot. At least
buy him a beer when you meet him.
And, allow me this personal note, thanks Kenjiro, working with you on the
topic has always been a great pleasure and I learned a lot from you. Thanks!
|
|
ok millert@
|
|
ok jmc@, millert@
|
|
|
|
suggested Daniel Dickman
|
|
|
|
|