summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-07-09Be more strict in RSA_padding_check_X931(), and thus avoid a possibleMiod Vallat
memcpy() with a negative size. ok tedu@
2014-07-09In the old days (not in this century), SSLeay 0.4.5 would create X.509 RSAMiod Vallat
signatures using the wrong oid for the signature type. The signature verification code has thus been modified to allow these signatures to be accepted, with a printf to stderr to notify the user something was fishy. Remove this chunk; these signatures will no longer get accepted. ok deraadt@ guenther@ jsing@ tedu@
2014-07-09Remove RSA_memory_lock(). This undocumented function sort-of serializes yourMiod Vallat
RSA components to memory and clears them, but there is no unserializing function, so its usefulness is close to zero. A grep through the ports tree sources show that it is only present in ports embedding their own openssl copy, and never used otherwise. ok jsing@
2014-07-09remove unused dynamic_cmd_defns_empty structure.Brent Cook
ok miod@ deraadt@ guenther@
2014-07-09RSA_NULL used to be a compile option allowing the RSA interfaces to beMiod Vallat
compiled-in, with nonfunctional code, to be able to cope with the RSA patent. However, we don't use this option, and the RSA patent has expired more than 10 years ago, so just drop this piece.
2014-07-09KNFMiod Vallat
2014-07-08Mark the weakened 40-bit export ciphers as invalid - no one in their rightJoel Sing
mind should be using them. ok deraadt@ miod@
2014-07-08Remove SSL_FIPS.Joel Sing
ok deraadt@ miod@
2014-07-08Nuke SSL_NOT_EXP since it does nothing.Joel Sing
ok deraadt@ miod@
2014-07-08replace malloc(strlen())/strlcpy with strdupBrent Cook
ok beck@ jsing@
2014-07-08Define SMALL_REGISTER_BANK on arm and vax, for it generates faster code forMiod Vallat
these systems (vax being 30% faster!). (surprisingly, the prime candidate for SMALL_REGISTER_BANK, SuperH, runs actually slower in that case)
2014-07-08Remove undocumented _des_crypt() interface and its companion header file,Miod Vallat
which had never been installed, so it's unlikely something ever used this in the last 15~20 years. ok deraadt@ jsing@ beck@
2014-07-08pedantic avoidance of division by zero, likely not actuallyBob Beck
possible to hit for real. ok miod@ jsing@
2014-07-08add missing stdint. include for uint32_t, etc.Brent Cook
ok beck@ jsing@
2014-07-08We do not care about broken Borland C pre-processors.Joel Sing
ok beck@ deraadt@
2014-07-08Pretty much everything has SO_REUSEADDR - nuke the #ifdefs.Joel Sing
ok beck@
2014-07-08We have EAI_FAMILY - remove the #ifdefs.Joel Sing
ok beck@
2014-07-08getentropy for osx and solaris. will be needed for a portable releaseBob Beck
2014-07-08More KNF.Joel Sing
2014-07-08Avoid locking in BIO_get_port() by using getservbyname_r() instead ofJoel Sing
getservbyname(). While here, provide a common/single return path. ok deraadt@
2014-07-08fix oops, accidental delete.. darn copying of files between machinesBob Beck
2014-07-08j should be an int, like repeatBob Beck
2014-07-08KNF.Joel Sing
2014-07-08KNF.Joel Sing
2014-07-08unbreak last commit - but same intent, make re-seed less expensiveBob Beck
2014-07-08More KNF.Joel Sing
2014-07-08Simplify various BIO_sock_* fuctions - less code, better variable names,Joel Sing
correct types and fewer casts. ok deraadt@ miod@
2014-07-08repeat calls to getentrypy() with the same pid likely indicate reseeds.Theo de Raadt
Since we assume the PRNG above is doing "something old, something new" folding, shortcut and do fewer repeats through the timing loop. ok beck
2014-07-03Memory-leak-in-error-path of the day in X509_ATTRIBUTE_set1_data().Miod Vallat
ok logan@ beck@
2014-07-02Memory leak in error path of the day, from clang via dhill@bitrig;Miod Vallat
ok dhill@bitrig
2014-07-02pk7_doit.c r1.20 introduced a NULL check that ensures that the signatureJoel Sing
contents are not NULL, however this breaks detached signature processing. Fix this by allowing the signature contents to be NULL when operating with a detached signature. Found the hard way by sthen@. ok sthen@
2014-07-02Remove more unused cruft.Joel Sing
No objection from the usual suspects.
2014-07-02KNF.Joel Sing
2014-07-01Avoid a NULL deref in i2d_ECPrivateKey() when an EC_KEY lacks the public keyMiod Vallat
member (which is perfectly acceptable). From BoringSSL (Adam Langley), commit f71a27920a903c9c36bcb31e68781b17674d3fd2
2014-06-30simplify and unobfuscate a variable to fix a mem leak.Ted Unangst
original diff by logan
2014-06-30fix the identical leak in three different files.Ted Unangst
reported by Brent Cook, original diff by logan
2014-06-29Remove yet another unused file... a backup copy (minus copyright andJoel Sing
includes) follows this commit message:
2014-06-29KNF.Joel Sing
I just spent too long chasing a bug in here and really should have done this first. Gem of the day... is it an if test or a for loop? No, it is a super ifloop! if (!(flags & PKCS7_NOVERIFY)) for (k = 0; k < sk_X509_num(signers); k++) {
2014-06-29Remove another unused source file - I got suspicious when I found aJoel Sing
function that ended with: if (ret & 0x01) if (ret & V_ASN1_CONSTRUCTED) }
2014-06-29More KNF.Joel Sing
2014-06-29correct issetugid sense as spotted by Stijn van Drongelen.Theo de Raadt
Substantially expand the conditional to reduce potential for error.
2014-06-28Add a missing word.Jeremie Courreges-Anglas
2014-06-28Fix a memory leak and another one that occurs in the error paths.Loganaden Velvindron
(Thanks to Brent Cook) OK from tedu@
2014-06-28Fix 9 memory leaks.Loganaden Velvindron
(Thanks to Brent Cook) With help from tedu@ OK from tedu@
2014-06-28Fix 2 memory leaks.Loganaden Velvindron
(Thanks to Brent Cook) OK from tedu@
2014-06-27When building a BN on the stack in BN_div(), make sure to initialize all itsMiod Vallat
fields (i.e. the flags field) before using it. This is currently harmless, but might not be if we end up invoking other BN functions checking for constant-time processing requirement in the future.
2014-06-27save_errno botch; spotted by miodTheo de Raadt
2014-06-27hand-KNF macro the do { } while loopsTheo de Raadt
2014-06-27hand-KNF the remaining bitsTheo de Raadt
2014-06-27Remove M_ASN1_New* macros which are only used in X509_PKEY_new() are obfuscateMiod Vallat
it to hide memory leaks in the error paths, and fix aforementioned memory leaks. ok jsing@ logan@ deraadt@