Age | Commit message (Collapse) | Author |
|
now it asks the mbuf layer for the 9k from its pools.
a question from chris@ made me go look at the chip doco again and i
realised that the chip only requires 4 byte alignment for rx buffers,
no 4k alignment for jumbo buffers.
i also found that the chip is supposed to be able to rx up to 9400
bytes instead of 9000. ill fix that later though.
|
|
The RTS threshold should be good enough and applies to all modes.
A similar change was made in iwm(4) not long ago.
tested by myself and benno@
|
|
ok jca@, reyk@
|
|
function.
ok reyk@
|
|
might want to use it. For buffered packets we probably need to save that
somehow else, but we don't support it now.
ok reyk@
|
|
and avoid problems.
ok jca@
|
|
(problem pointed out by Petr, fix proposed by Dilli) _at_ oracle
|
|
Triggered by an incorrect patch from Jan Stary.
Feedback and OK jmc@, OK millert@.
|
|
Triggered by an incorrect patch from Jan Stary.
While here, add an .Xr to cut(1).
OK millert@ jmc@
|
|
Patches from Jan Stary <hans at stare dot cz>, tweaked by me and tb@.
While here, apply some simple style improvements:
Sort headers, static void __dead usage(), return from main(),
zap case '?', drop /* NOTREACHED */, drop break after usage(), ...
OK tb@ millert@
|
|
|
|
verbose error()s to debug()s, include PKCS#11 provider name and slot
in log messages where possible.
bz#2610, based on patch from Jakub Jelen
|
|
pf functions. That means less parameters, more consistency and
later we can call functions that need a pd from pf_route().
OK sashan@
|
|
reference to eddep in the kernel Makefile I could find is in 4.3BSD,
released some 30 years ago.
ok tb millert
|
|
OK mikeb@ mlarkin@
|
|
20 years ago. While there, eliminate two dead assignments.
ok natano
|
|
ok natano
|
|
Make sure to hold the ring buffer lock for the complete duration
of a channel ring I/O operation. For read operations this means
peeking and reading is done uninterrupted and for both reads and
writes this places the buffer space availability check under the
same lock as well.
|
|
Use vis(3) to safely print ifname and stop at IFNAMSIZ bytes.
Found with afl by jsg@. OK jsg@
|
|
without it.
|
|
|
|
no need to wait until the first program using it breaks...
"could make sense" semarie@ (and thanks for the cluestick)
OK deraadt@
|
|
swofp_flow_entry_delete() call frees the memory pointed to by the swfe
variable which was used later in the loop.
ok rzalamena@
|
|
|
|
ncpus is used on half the architectures to indicate the number of
cpus that have been hatched, and is used on them in things like ddb
to figure out how many cpus to shut down again.
ncpusfound is incremented during autoconf on MP machines to show
how big ncpus will probably become. percpu is initted after autoconf
but before cpus are hatched, so this works well.
|
|
IANA moved the Large Communities attribute to 32, which is a nice pun on
the problem it is solving.
|
|
|
|
|
|
fixes percpu allocations, like visa@ just did on mips64.
|
|
From Michael W. Bombardieri <mb at ii.net>
|
|
|
|
the most important change is that if the requested data is already
in the first mbuf in the chain, return quickly.
if that isnt true, the code will try to use the first mbuf to fit
the requested data.
if that isnt true, it will prepend an mbuf, and maybe a cluster,
to fit the requested data.
m_pullup will now try to maintain the alignment of the original
payload, even when prepending a new mbuf for it.
ok mikeb@
|
|
this means that the ethernet header and therefore its payload will
be aligned correctly for the stack. without this em and ix are
sufferring a 30 to 40 percent hit in forwarding performance because
the ethernet stack expects to be able to prepend 8 bytes for an
ethernet header so it can gaurantee its alignment. because em and
ix only had 6 bytes where the ethernet header was, it always prepends
an mbuf which turns out to be expensive. this way the prepend will
be cheap because the 8 byte space will exist.
2k+ETHER_ALIGN clusters will end up using the newly created mcl2k2
pool.
the regression was isolated and the fix tested by hrvoje popovski.
ok mikeb@
|
|
a certain vendor likes to make chips that specify the rx buffer
sizes in kilobyte increments. unfortunately it places the ethernet
header on the start of the rx buffer, which means if you give it a
mcl2k cluster, the ethernet header will not be ETHER_ALIGNed cos
mcl2k clusters are always allocated on 2k boundarys (cos they pack
into pages well). that in turn means the ip header wont be aligned
correctly.
the current workaround on these chips has been to let non-strict
alignment archs just use the normal 2k cluster, but use whatever
cluster can fit 2k + 2 on strict archs. that turns out to be the
4k cluster, meaning we waste nearly 2k of space on every packet.
properly aligning the ethernet header and ip headers gives a
performance boost, even on non-strict archs.
|
|
pfvar_priv.h. The pf_headers had to be defined in multiple .c files
before. In pfvar.h it would have unknown storage size, this file
is included in too many places. The idea is to have a private pf
header that is only included in the pf part of the kernel. For now
it contains pf_pdesc and pf_headers, it may be extended later.
discussion, input and OK henning@ procter@ sashan@
|
|
that ICMP Time Exceeded packets are generated. Traceroute output
from packets forwarded through pf and a router must contain 3 hops
and every hop must respond.
Do not test with af-to and reply-to rules as this does not work
right now.
|
|
|
|
|
|
"twenty four", arguing, i think, that the internet is wrong; well
seemingly i'm wrong, and you should hyphenate numbers when spelled out
- who'd have thought it. apologies to florian and the diff submitter
(and the internet);
still, what i should have advised, and what i've done here, is use "24",
which is much simpler, fits the surrounding text, and agrees with oed
style advice;
|
|
|
|
|
|
|
|
as broadcast address. The kernel does not consider this a broadcast
address and ifconfig(8) has a check to exclude it. Use the same
check in pfctl(8).
Found by regress/sbin/pfctl pfi2; OK mikeb@
|
|
CHRP hardware.
|
|
|
|
debugging easier. Handle EINPROGRESS connect(2) error correctly.
Perl pack Q fails on 32 bit machines, add workaround. Restore
interfaces in END block, works also if script dies.
OK florian@
|
|
addition of a MAC we need at least 24 bytes packet size these days to
show timing information.
Pointed out by Tamas Horvath, thanks!
OK jmc
|
|
that percpu data areas get allocated properly on mips64 platforms. It is
too late to set the value during launch of secondary CPUs.
ok jasper@ kettenis@ dlg@
|
|
|
|
|