Age | Commit message (Collapse) | Author |
|
woken up by a wakeup, but only by the actual timeout expiry. On
architectures which share a kva upage area between processes, we would
not want an accidental wakeup (too short).
discussed with various
|
|
the : and uid components out -- otherwise these two programs will work
poorly.
|
|
ok jakob@
|
|
than the column containing it, the TERMP_HANG flag is required,
but avoid the flag when we know that the HEAD is shorter,
because in that case, the flag might ruin the alignment.
Problem originally reported by jmc@, who also spotted a regression
in an earlier version of this patch.
"feel free to commit" kristaps@
|
|
those ruined the alignment of columns.
Tested by jmc@, and kristaps@ agrees with the direction.
|
|
|
|
|
|
Okay deraadt@, millert@ and all around general approval.
|
|
Okay deraadt@, millert@ and all around general approval.
|
|
curproc. A bunch of callers were passing in 0 (not even NULL, 0) as this
pointer, which was fine until the called vnode function tried to do
something with it. Typically, this code was then copy/pasted to various
parts of the tree.
Accept the facts of life and switch all of these over to passing curproc
for now until the argument can be removed.
Discovered by stsp trying to create a softraid on top of a vnd, which
crashed with a NULL deref in vndioctl.
softraid bits tested by mikeb and jsing. raidframe bits tested by pea,
matthieu and naddy. The rest tested by at least thib, jsing and myself.
ok thib@, jsing@.
|
|
fail it is still good practise to either check the return value or to
provide a flag that won't (to avoid copy pasted code that gets it
wrong).
So change LK_EXCLUSIVE to LK_EXCLUSIVE | LK_RETRY, removing the one
caller of vn_lock in the tree that doesn't either pass LK_RETRY or check
the return value.
ok thib@, jsing@ as part of a larger diff.
|
|
/* something */
if (error) {
VOP_UNLOCK();
return;
}
VOP_UNLOCK();
to the clearer and shorter:
VOP_UNLOCK();
if (error)
return;
ok thib@, jsing@ as part of a larger diff.
|
|
feedback/ok kili@
|
|
|
|
diff from Michael W Bombardieri in PR 6398.
tested by & ok jasper
|
|
ok me stsp
|
|
|
|
the device driver which has DEACTIVATE processing seems to no need to
set dying flag in the detach() function because the flag will be set
in the DEACTIVATE process before detach().
ok jsg@, ok for experiment deraadt@
|
|
with an offset equal to the actual data length.
ok henning blambert
|
|
ok deraadt@
|
|
|
|
|
|
|
|
from vacation(8);
ok millert
|
|
|
|
ok deraadt@
|
|
ok deraadt@
|
|
from Douglas Berry, freebsd pr misc/150504
|
|
|
|
behaviour consistent between IPv4 and IPv6.
From martin.pelikan@gmail.com
|
|
Okay miod@.
|
|
|
|
a disklabel UID. Based on a diff from josh@elsasser.org. Resolves PR6471.
ok krw@
|
|
uid_print() function.
ok krw@
|
|
|
|
|
|
ok krw@
|
|
ok deraadt@ krw@
|
|
providing the DKF_NOLABELREAD flag is not set. This provides the kernel
with the actual disklabel which includes the disklabel UID.
ok deraadt@ miod@ krw@
|
|
automatic reading of disklabel on attach.
ok deraadt@ miod@ krw@
|
|
|
|
prompted by reyk
|
|
OK reyk
|
|
|
|
ok claudio@
|
|
|
|
instead of letting hardware rings grow on every interrupt, restrict
it so it can only grow once per softclock tick. we can only punish
the rings on softclock ticks, so it make sense to only grow on
softclock tick boundaries too.
the rings are now punished after >1 lost softclock tick rather than
>2. mclgeti is now more aggressive at detecting livelock.
the rings get punished by an 8th, rather than by half.
we now allow the rings to be punished again even if the system is
already considered in livelock.
without this diff a livelocked system will have its rx ring sizes
scale up and down very rapidly, while holding the rings low for too
long. this affected throughput significantly.
discussed and tested heavily at j2k10. there are still some games
with softnet we can play, but this is a good first step.
"put it in" and ok deraadt@
ok claudio@ krw@ henning@ mcbride@
if we find out that it sucks we can pull it out again later. till then
we'll run with it and see how it goes.
|
|
netatalk enabled.
|
|
becaue it skips a wakeup() later on. this is the only error condition
that returns before the wakeup. not sure why this particular case is
handled differently, and not certain what the error code should be, but
this is better than breaking all of usb because of a problem on one port.
dicussed with deraadt
|
|
* usbd_device_handle dev - the device responsible for the task. use
this to not run the task if the device's hub is dying.
* int running - a flag to be set when the task is running.
add usb_rem_wait_task(), a wrapper for usb_rem_task() that waits for
the task to complete if the task is already running.
s/usb_rem_task/usb_rem_wait_task/ in usb_detach(). probably most
drivers using usb_tasks should do this as well. although device
attach/detach is serialized in normal cases, in the special case
where the usb bus is hotpluggable (like cardbus/pcmcia), devices
are not detached in the task thread.
|