summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2009-11-11syncTheo de Raadt
2009-11-11memory leaks found by parfait; ok ogaTheo de Raadt
2009-11-11Spell.Federico G. Schwindt
2009-11-11Rewrite a confusing loop when freeing the arg array on exit and move the checkNicholas Marriott
for argv being NULL, prompted by parfait via deraadt. Also fix some definite brokenness when assigning multiple environment variables in arguments (such as "X=1 Y=2").
2009-11-11Add an explicit zero-length check for UTF-8 input data, prompted by a reportNicholas Marriott
from parfait via deraadt. While here, add a statement to set the width when filling with _s if not enough space (width should never be high enough at the moment anyway), and wrap some long lines.
2009-11-11fix leaks in error cases found by parfaitJonathan Gray
ok blambert@ miod@ deraadt@
2009-11-11memory leaks, found by parfait; ok millertTheo de Raadt
2009-11-11obvious use after free, found by parfaitTheo de Raadt
2009-11-11fix a few memory leaks, found by parfait; ok jsgTheo de Raadt
2009-11-11add a icache flush which appears to make the machines even more stableTheo de Raadt
(no crashes in nearly forever) ok kettenis
2009-11-11memory leak with #ifdef SMALL, found by parfaitTheo de Raadt
ok jsg
2009-11-11correctly order the range check and use the right limits, pointed out by parfaitTheo de Raadt
ok claudio millert
2009-11-11do not walk off the prefix array, off by one; found by parfaitTheo de Raadt
ok jsg millert
2009-11-11Fix previous. When configured to relay via IP address, MX lookup would failJacek Masiulaniec
(NXDOMAIN), leading to a bounce. Precede the MX lookup with an attempt to parse the relay as numeric string. "reads ok" gilles@
2009-11-11patch a whole bunch of memory leaks, parfait only spotted one of themTheo de Raadt
ok miod jsg
2009-11-11fix a buffer overflow found by parfaitJonathan Gray
ok millert@
2009-11-11incorrect range check, > vs >=, on the error list, spotted by parfaitTheo de Raadt
ok otto jsg
2009-11-11Let ioc(4) pass the information whether it is an onboard device or not, to itsMiod Vallat
subdevices; use this on iockbc to only perform the fuel workaround on the onboard ioc.
2009-11-11Perform a bit more kbc initialization, instead of relying upon the prom toMiod Vallat
do this for us; PS/2 ports on CADduo boards attach keyboard and mouse now. ok jsing@
2009-11-11Check if the receive buffer has any unused space before reading from socket inJacek Masiulaniec
buf_read (and in ssl_buf_read).
2009-11-11It turns out PCI IOC3 card which embed both the Ethernet controller and theMiod Vallat
superio chip interrupt on two different pins (yet do not advertize themselves as a multi-function device, of course). So, on one hand, this makes the ioc attachment code simpler, because it simply needs to map interrupt pins A and B, and another hand, this moves all the interrupt knowledge to the PCI bridge driver, since routing of pin B differs whether the device is the onboard IOC3 chip (and able to use any of the 8 bridge interrupt sources...) or on a PCI board (with pin mapping sane, since controlled by the bridge). This makes superio interrupts on CADduo boards work. Tested to cause no regressions on Origin 200, Octane and Fuel.
2009-11-11Plug two memory leaks in error pathes. Found by parfait. OK henning, jsgClaudio Jeker
2009-11-11Free the pane bufferevent when the fd is closed (the signal could come beforeNicholas Marriott
the error callback).
2009-11-11Don't leak memory in error case.Jonathan Gray
Found by parfait.
2009-11-11don't leak memory in an error case.Jonathan Gray
found by parfait.
2009-11-11vsystem, system, unlink can mostly go through state, and do the ->clear partMarc Espie
as well.
2009-11-11remove extra warningsMarc Espie
2009-11-11remove redirector: if we want to run system AND log, just say soMarc Espie
2009-11-11fix setup_header in -vx !-r case: show we are adding a package, and don'tMarc Espie
show it twice.
2009-11-11don't use Warn if we've got a $state, get through errprint/errsay.Marc Espie
Also: reset lastdisplay on clear, and don't clear twice.
2009-11-11also get most STDERR messages through the same wayMarc Espie
2009-11-11progressmeter puts STDOUT in autoflush if -t, so that it can display to it ↵Marc Espie
instead of piping a lot of stuff to STDERR. Go through state->print for most messages, so they will NOT do weird things with the progressmeter. Use a ->say shortcut which does the same thing that perl 5.10 say does...
2009-11-11Fix crlf issue in buf_getln, similar to that in smtp_session.c r1.123.Jacek Masiulaniec
ok gilles@
2009-11-11improve buf_getln readability, no fuctional change.Jacek Masiulaniec
2009-11-11state->progress->print => $state->printMarc Espie
2009-11-11make things so that $state->print always work, with or without progressmeter,Marc Espie
even before we set it up.
2009-11-11remove forwarders, and provide a sensible API that says what's going onMarc Espie
(e.g., we're logging information for later).
2009-11-11bad idea to inherit from Error, compose object insteadMarc Espie
2009-11-11Fix some memory leaks in error cases.Jonathan Gray
Found by parfait. ok henning@
2009-11-11Ensure all replies are at least 4 chars long. If only 3 chars wereJacek Masiulaniec
received, append a space character. This enables other parts of the daemon to safely index into 4th character of the reply buffer without the risk of accessing one byte beyond NUL. ok gilles@
2009-11-11add missing headers needed by time()Charles Longeau
ok jacekm@
2009-11-11Only need to chmod +x or -x the socket when a client is created, lost orNicholas Marriott
attached, rather than every event loop.
2009-11-11Fix an obvious use after free. Found by parfait. Reported and OK jsg@Claudio Jeker
2009-11-11Regress for skipping evaluation of else-type conditional if previousFederico G. Schwindt
corresponding one evaluted to true. espie@ ok.
2009-11-11If this is an else-type conditional and previous corresponding oneFederico G. Schwindt
evaluated to true, skip. tested by simon@ and myself. espie@ ok.
2009-11-11Pass the structure by reference. pointed out and ok by miod@Federico G. Schwindt
2009-11-10Use buffered fwrite(3) to build the udl Huffman table,Marco Pfatschbacher
rather than doing 131074 write(2)s. OK mglocker, deraadt.
2009-11-10Handle LOMlite2 in an interrupt-driven way; avoids using delay(9) once theMark Kettenis
machine is up and running.
2009-11-10syncTheo de Raadt
2009-11-10tweak previous;Jason McIntyre