summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-08Use a union to ensure cmsg buffer is properly alignedJeremie Courreges-Anglas
Fixes a crash on landisk (strict alignement arch) reported by otto@ ok deraadt@ otto@
2020-05-08Remove unneccessary X509_NAME_oneline wrapper. Passing NULL as buftobhe
does the same thing. ok patrick@
2020-05-08Nuke unneeded 'inits' field in struct proposal. 'mtu' being 0 is enough of a ↵Kenneth R Westerback
clue to avoid setting interface mtu.
2020-05-08Nuke 'set but never used' addrs field in struct proposal.Kenneth R Westerback
2020-05-08Use proper function pointer type instead of void *Jeremie Courreges-Anglas
Mixing up function and void pointers isn't defined by POSIX or the C standard. POSIX only specifies that casting the result of dlsym(3) to an appropriate function pointer works. Avoid all this by using a typedef. from Michael Forney, ok tb@
2020-05-08imsg.h needs uio.h, pointed out by deraadtNicholas Marriott
2020-05-08Fix obvious copy-past-O in calculation of maximum length of "Available"Martijn van Duren
column for df subcommand. Fixes misalignment in some cases.
2020-05-08Move parsing of _CRS into acpi(4) and pass the parsed address and interruptMark Kettenis
information in struct acpi_attach_args. ok mpi@
2020-05-08Make sure cmsgbufs are properly aligned by using the idiom from theOtto Moerbeek
CMSG_DATA man page. Avoids SIGBUS on landisk; ok kettenis@ jca@
2020-05-08ld.so(1) also ignores LD_LIBRARY_PATH an friends for set-group-ID executablesJeremie Courreges-Anglas
While here, use consistent casing and don't use .Ev for set-user-ID/set-group-ID. from Miod
2020-05-08LD_DEBUG is ignored for set-user-ID and set-group-ID executablesJeremie Courreges-Anglas
from Miod
2020-05-08Do not use string litterals in the grammar ("{") it is not POSIX compliantClaudio Jeker
and also not needed. This just needs a char lookup ('{') like it is done in all the other rules with '{'. With this parse.y can be compiled with bison. OK otto@ benno@
2020-05-08Just a bit of KNF.Claudio Jeker
OK florian@
2020-05-08Do not wait indefinitely for flushing when closing a tty.Martin Pieuchot
This prevent exiting processes from hanging when a slave pseudo terminal is close(2)d before its master. From NetBSD via anton@. Reported-by: syzbot+2ed25b5c40d11e4c3beb@syzkaller.appspotmail.com ok anton@, kettenis@
2020-05-08fix compilation with DEBUG_KEXDH; bz#3160 ok dtucker@Damien Miller
2020-05-08less ugly upstream namesTheo de Raadt
2020-05-07On receiving a handshake or alert record with empty inner plaintext,Theo Buehler
terminate the connection with an unexpected_message alert. See RFC 8446 section 5.4. Found with tlsfuzzer hint/ok jsing
2020-05-07post-6.7 development continuesTheo de Raadt
2020-05-06openssh-8.3; ok deraadt@Damien Miller
2020-05-06another case where a utimes() failure could make scp send aDamien Miller
desynchronising error; reminded by Aymeric Vincent ok deraadt markus
2020-05-06Currently LibreSSL reports an unknown SSL_internal error. AdjustAlexander Bluhm
regex in test. So make regress passes for the release, the error message will be improved later. discussed with jsing@
2020-05-06Only allow forkmda() to be called from a local action dispatcher.Todd C. Miller
From gilles@, OK deraadt@ jung@
2020-05-06Bump LibreSSL version to 3.1.1Theo Buehler
ok bcook inoguchi deraadt
2020-05-06The error message from LibreSSL has changed. Adjust regex in test.Alexander Bluhm
discussed with jsing@
2020-05-06Same fix for ospfd lsupdate.c applies in ospf6d as well.Claudio Jeker
Do not use the pointer returned by ibuf_reserve() after calling another ibuf function. After the call the internal buffer may have moved by realloc() and so the pointer is invalid. Instead use ibuf_size() to get the current offset in the buffer and use ibuf_seek() later on to write back the updated lsa age into the buffer at the right spot. This fixes an issue seen by Richard Chivers on routers with many passive interfaces. OK stsp@ denis@ deraadt@ also tested by sthen@
2020-05-06Do not use the pointer returned by ibuf_reserve() after calling anotherClaudio Jeker
ibuf function. After the call the internal buffer may have moved by realloc() and so the pointer is invalid. Instead use ibuf_size() to get the current offset in the buffer and use ibuf_seek() later on to write back the updated lsa age into the buffer at the right spot. This fixes an issue seen by Richard Chivers on routers with many passive interfaces. OK stsp@ deraadt@
2020-05-06rpki-client is only interested in real files. Don't tell rsync toClaudio Jeker
preserve symbolic links. Instead just ignore them. OK benno@ deraadt@
2020-05-06Do sanity checks in ip6_pullexthdr() preventing a panic in m_copydata(9).Martin Pieuchot
An invalid/corrupted hop6 option in rip6_input()/ip6_savecontrol() could lead m_copydata(9)s' check to trigger a panic. Fix from maxv@NetBSD where the problem was also reported by syzkaller. Reported-by: syzbot+3b07b3511b4ceb8bf1e2@syzkaller.appspotmail.com Reported-by: syzbot+7ee0eb2691d507fcad2e@syzkaller.appspotmail.com ok sashan@, dlg@, claudio@, deraadt@
2020-05-05Purge the ic_bss->ni_savedq mbuf queue when a wireless interface goes down.Stefan Sperling
Purging this queue prevents a panic which occurs when a WPA2-enabled athn(4) hostap interface is reconfigured while this queue contains frames. In hostap mode, this queue contains group-addressed (broadcast) frames which are buffered for clients sleeping in powersave state. Frames on this queue are transmitted when it is time to send another beacon, at which point in time sleeping clients wake up to receive such frames. The panic message is "key unset for sw crypto", which can be explained as follows: Group keys are cleared when the interface goes down. The beacon Tx interrupt handler gets triggered by hardware when the interface comes back up. This handler attempts to encrypt the queued frames for transmission, resulting in the above panic since the group key has been zeroed out. This panic has been observed with athn(4) by Jan Stary and Ted Patterson, and Ted has confirmed that this patch fixes the problem. ok kettenis@ (with the caveat that it's been a long time since he put our AP-side powersave support into a working state)
2020-05-05watch the /.profile and the /.cshrc in the root directory;Ingo Schwarze
i noticed this is desirable while looking at an issue reported by Doug Moss <dougmoss710 at yahoo dot com> on bugs@; OK deraadt@ sthen@ tb@
2020-05-05Revert parts of CVS commit Jdqd26bn9Ev6aFMc ("Fix processing of compressedStefan Sperling
block ack notifications sent by iwn(4) firmware"). This effectively reverts changes in how the driver interacts with firmware and fixes connections getting stuck for unknown reasons, in two known cases: One with an Airport Extreme 6th gen AP and another with a b-box 3V+ modem using a Sagemcom MAC address for its built-in AP. The Sagemcom case was observed by myself. The Airport case was reported by Jeremy O'Brien via abieber@. I am committing this now to prevent the problem from affecting 6.7 release even though we don't yet understand what caused the problem. ok mpi@
2020-05-04Remove redundant code testing if a terminal is a usb stream.Alexandre Ratchov
Fixes coverity CID 1492830. ok sthen, deraadt
2020-05-04Use a larger (2048 bit) RSA test key.Joel Sing
Otherwise we fail to do PSS signatures since the key size is too small.
2020-05-04Using int64_t together with printf %llu is not portable. Either add aClaudio Jeker
cast in the printf to unsigned long long or just use unsigned long long from the start. In this case it is better to switch the type. Similar changes had been done before. OK deraadt@
2020-05-04leave -beta.Theo de Raadt
2020-05-04Check v6 availablilty mask instead of v4.Gerhard Roth
go for it deraadt@
2020-05-04Partially reverse a commit from 2019/12/28denis
A large number of redistributed routes make ospf6d crash. OK remi@, sthen@
2020-05-04Fix out-of-bounds access in tables[][] that was exposed in bluhm'sTheo Buehler
regress on i386 after inoguchi moved some symbols to const. ok inoguchi jsing deraadt
2020-05-04tcpbench: display stats on SIGINFO, not just at exit. ok tb@ procter@ deraadt@Stuart Henderson
2020-05-03Use strftime() rather than ctime() to generate timestamps nicer.Theo de Raadt
ok job, input claudio benno
2020-05-03Make it clear the date is in UTC.Theo de Raadt
ok job
2020-05-03Correctly name max_out_prefix and don't clobber the max_prefix value.Claudio Jeker
Also include the group name in the general neighbor description. Both issues reported by Patrick Velder OK deraadt@
2020-05-03repair headers, as noted by tbTheo de Raadt
2020-05-03correct dateTheo de Raadt
2020-05-03Accept two ChangeCipherSpec messages during a TLSv1.3 handshake.Joel Sing
In compatibility mode, a TLSv1.3 server MUST send a dummy CCS message immediately after its first handshake message. This is normally after the ServerHello message, but it can be after the HelloRetryRequest message. As such we accept one CCS message from the server during the handshake. However, it turns out that in the HelloRetryRequest case, Facebook's fizz TLSv1.3 stack sends CCS messages after both the HelloRetryRequest message and the ServerHello message. This is unexpected and as far as I'm aware, no other TLSv1.3 implementation does this. Unfortunately the RFC is rather ambiguous here, which probably means it is not strictly an RFC violation. Relax the CCS message handling to allow two dummy CCS messages during a TLSv1.3. This makes our TLSv1.3 client work with Facebook Fizz when HRR is triggered. Issue discovered by inoguchi@ and investigated by tb@. ok deraadt@ tb@
2020-05-02Add ping(1)-like summary statistics.Richard Procter
Makefile omitted by mistake from commit tJPIjljmTjZW ok djm@ deraadt@
2020-05-02Add ping(1)-like summary statistics.Richard Procter
ok djm@ deraadt@
2020-05-02Repair the description of "edh [params (none|auto|legacy)]" toSebastian Benoit
configure EDH-based cipher suites with Perfect Forward Secrecy (PFS) for older clients that do not support ECDHE. Problem noticed and initial diff by Jesper Wallin, thanks! ok kn@
2020-05-02Minimal documentation of JSON output.Claudio Jeker
2020-05-02Add support to output data in JSON. This is still work in progress andClaudio Jeker
the output structures may still change but it should be a good starting point for poeple to start playing with it. OK benno@, job@, deraadt@