summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-28remove superfluous/invalid KASSERT() in pfsync_q_del().Alexandr Nedvedicky
pointed and OK bluhm@
2023-04-28Remove now no longer needed <assert.h>; sort headersTheo Buehler
ok jsing
2023-04-28Deassert has_explicit_policy()Theo Buehler
The only caller is X509_policy_check() which goes straight to error. with beck ok jsing
2023-04-28Deassert delete_if() callbacksTheo Buehler
Add sk_is_sorted() checks to the callers of sk_X509_POLICY_NODE_delete_if() and add a comment that this is necessary. with beck ok jsing
2023-04-28Deassert x509_policy_level_find()Theo Buehler
Move the check that level->nodes is sorted to the call site and make sure that the logic is preserved and erroring does the right thing. with beck ok jsing
2023-04-28Deassert X509_policy_check()Theo Buehler
Instead of asserting that i == num_certs - 2, simply make that an error check. with beck ok jsing
2023-04-28Deassert x509_policy_level_add_nodes()Theo Buehler
This assert is in debugging code that ensures that there are no duplicate nodes on this level. This is an expensive and unnecessary check. Duplicates already cause failures as ensured by regress. with beck ok jsing
2023-04-28Deassert x509_policy_new()Theo Buehler
Turn the check into an error which will make all callers error. with beck ok jsing
2023-04-28Rearrange freeing of memory in the regress testJob Snijders
2023-04-28Reorder the text such that every function is discussed only onceIngo Schwarze
instead of discussing some of them at two different places. Also follow a more logical order: initialization first, then reading and writing, then retrieving the digest and reinitialization. Leave context handling and chain duplication at the end because both are rarely needed. While here, also tweak the wording of the shuffled text and add some precision in a few places.
2023-04-28make the policy test compile on sparc64Theo Buehler
2023-04-28Inbound portion of RFC9131. Routers can create new neighbor cache entriesPeter Hessler
when receiving a valid Neighbor Advertisement. OK florian@ kn@
2023-04-28This change speeds up DIOCGETRULE ioctl(2) which pfctl(8) uses toAlexandr Nedvedicky
retrieve rules from kernel. The current implementation requires like O((n^2)/2) operation to read the complete rule set, because each DIOCGETRULE operation must iterate over previous n rules to find (n + 1)-th rule to read. To address the issue diff introduces a pf_trans structure to keep pointer to next rule to read, thus reading process does not need to iterate from beginning of rule set to reach the next rule. All transactions opened by process get closed either when process is done (reads all rules) or when /dev/pf device is closed. the diff also comes with lots of improvements from dlg@ and kn@ OK dlg@, kn@
2023-04-28Relax the "pass all" rule so all forms of neighbor advertisements are allowedPeter Hessler
in either direction. This more closely matches the IPv4 ARP behaviour. From sashan@ discussed with kn@ deraadt@
2023-04-28Add X509_REQ_add_extensions and to X509_REQ_add1_attr to DER cache testJob Snijders
These new tests won't bubble up a non-zero error exit code because other libcrypto bits still need to land first.
2023-04-28Same change as in bgpd:Claudio Jeker
Add explicit default labels in switch() statements with error handling. Right now these are not reachable. Should also clear some gcc warnings. OK tb@
2023-04-28Add explicit default labels in switch() statements with error handling.Claudio Jeker
Right now these are not reachable. Should also clear some gcc warnings. OK tb@
2023-04-28Add a membar_consumer() for the taskq_create() in sosplice(). MembarAlexander Bluhm
producer and consumer must come in pair and the latter was missing. Also move the code a bit to make clear which check is needed for what. OK mvs@
2023-04-28Move FSDISKTYPE uses from disklabel(8) invocations to vnconfig(8)Kenneth R Westerback
invocations, making the geometry information written to the disklabel a bit more logically related to the disktab information from whence it came. Also makes FSDISKTYPE usage consistent. Flip the disklabel(8) invocations to the "echo '/ *'" idiom to make it obvious that the desire is to create a single 'a' partition containing all free space. No intentional functional change. MBRs, disklabels and newfs outputs appear identical. reads good to kn@
2023-04-28Enable kernel-address sanitizer for clang openbsd targetGreg Steuck
OK deraadt@
2023-04-28Implement --size-only and --ignore-timesClaudio Jeker
Flags are passed to the remote system but --size-only is only set if local system is sender since this is the behaviour of rsync. Initial diff from Martin Cracauer but mostly reimplemented and extended by myself. OK kn@
2023-04-28Remove net lock from DIOCGETQUEUESKlemens Nanni
Both ticket and number of queues stem from the pf_queues_active list which is effectively static to pf_ioctl.c and fully protected by the pf lock. OK sashan
2023-04-28Fix memory constraints in the inline-assembly stub that calls into securePatrick Wildt
mode. Without this change the compiler doesn't realize that the memory behind the array that contains the return values might have changed and optimizes the access away. With this change it properly access the array to retrieve the returned values. ok drahn@
2023-04-28Remove error handling around mallocarray(9). I cannot fail whenAlexander Bluhm
called with M_WAITOK. OK kevlo@
2023-04-28fix lfindent (newline-and-indent) comment and description in the man pageOmar Polo
for a while it has used only spaces when no-tab-mode is enabled and respected the current buffer tab width.
2023-04-28Cleanup pass over x509_check_policy.cTheo Buehler
This hoists variable declarations to the top and compiles with -Wshadow. ok beck
2023-04-28mark up all commands in the man pageOmar Polo
2023-04-28Hook up the the x509 policy regression tests to x509 regress.Bob Beck
These were adapted from BoringSSL's regress tests for x509 policy. They are currently marked as expected to fail as we have not enabled LIBRESSL_HAS_POLICY_DAG by default yet, and the old tree based policy code from OpenSSL is special. These tests pass when we build with LIBRESSL_HAS_POLICY_DAG.
2023-04-28Fix copyright, convert boringssl comments to C styleBob Beck
2023-04-28KNFBob Beck
ok knfmt
2023-04-28remove unused code.Bob Beck
2023-04-28remove debugging printfBob Beck
2023-04-28Retire -E's "expert" mode. Introduced 23 years ago to avoidKenneth R Westerback
confusing users with FFS attributes that only experts should fiddle with. Actual use has withered away with functionality rendered moot or moved elsewhere. '-e' remains for the truly obscure corner cases. Simply excise the code for now to see if hidden users/uses are exposed. Further simplifications are possible if no such users/uses surface. ok with sthen@ millert@ kn@ otto@
2023-04-28This test should not have V_EXPLICIT_POLICY set. with thisBob Beck
corrected we pass
2023-04-28Add the rest of the boringssl policy unit tests.Bob Beck
We currently still fail two of these, looks like one more bug in extracting the depth for require policy from the certificate..
2023-04-28escape the "D1" revisions, as mandoc thinks this is a macro call;Jason McIntyre
2023-04-28Add options to change the confirm key and default behaviour ofNicholas Marriott
confirm-before. From Elias Assaf in GitHub issue 3548; prompted by an earlier change from Yutaro Yoshii in GitHub issue 3496.
2023-04-28Do not fatal if tparm fails, instead just log it (not working sequencesNicholas Marriott
are better than exiting).
2023-04-28Add a driver for the Qualcomm rng device found on the Thinkpad X13s, based onPeter Hessler
kettenis's amlrng driver. suggestions and OK patrick@
2023-04-28syncKevin Lo
2023-04-28regenKevin Lo
2023-04-28Add support for RTL8188FTV chip to urtwn(4).Kevin Lo
Tested with Comfast CF-WU710N v4. "go ahead" deraadt@ OK stsp@
2023-04-27Use __size_t which is available in syslog.hGreg Steuck
Directly including sys/syslog.h would fail due to size_t being unknown. OK millert, miod
2023-04-27vmd(8): introduce multi-process model for virtio devices.Dave Voutila
Isolate virtio network and block device emulation in dedicated processes, forked and exec'd from the vm process. This allows for tightening pledge promises to just "stdio". Communication between the vcpu's and these devices now occurs via imsg channels, which adds the benefit of not always blocking the vcpu thread while emulating the device. With this commit, it's possible that vmd is the first open source hypervisor that *defaults* to a multi-process device emulation model without requiring any additional configuration from the operator. Testing help from phessler@ and Mischa Peters. ok mlarkin@
2023-04-27add missing entries; ok miodJason McIntyre
2023-04-27add missing entries; ok miodJason McIntyre
2023-04-27add missing entries;Jason McIntyre
remove Tn macro usage; feedback/ok miod
2023-04-27Mark the fan speed sensor as invalid when it reports -1 RPM. This happens forMiod Vallat
a short while after suspend. ok deraadt@ kn@
2023-04-27Better pcic(4) description.Miod Vallat
2023-04-27add support for I/O statistics so that tape speeds can be observed withRobert Nagy
iostat(8)