summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-03-31man pages: add missing commas between subordinate and main clausesChristian Weisgerber
jmc@ dislikes a comma before "then" in a conditional, so leave those untouched. ok jmc@
2022-03-31on-ramdisk firmware extraction can overflow the install-media directoryTheo de Raadt
because of the the tar+mv combination. Purge both path variations better, so that an interrupted install can be restarted. ok miod abieber kettenis
2022-03-31Remove duplicate scsi devices.Kenneth R Westerback
ok miod@ deraadt@
2022-03-31Fix leak in ASN1_TIME_adj_internal()Theo Buehler
p is allocated by asprintf() in one of the *_from_tm() functions, so it needs to be freed as in the other error path below. CID 346194 ok jsing
2022-03-31Simplify priv_key handling in d2i_ECPrivateKey()Theo Buehler
d2i_EC_PRIVATEKEY() can handle the allocation of priv_key internally, no need to do this up front and reach it through the dangerous reuse mechanism. There's also no point in freeing a variable we know to be NULL. ok jsing
2022-03-31Sync & permit ASPA objects to appear on ManifestsJob Snijders
OK tb@ claudio@
2022-03-31Check EVPDigest* return values.Theo Buehler
CID 351293
2022-03-31'e' is no longer an optional element for ober_scanf_elements.Martijn van Duren
This caused the last attribute to be dropped. Reported by Allan Streib (astreib <at> fastmail <dot> fm) Reminded by Raf Czlonka (rczlonka <at> gmail <dot> com) OK tb@ claudio@
2022-03-31'e' is no longer an optional element for ober_scanf_elements.Martijn van Duren
This caused the last attribute to be dropped. Reported by Allan Streib (astreib <at> fastmail <dot> fm) Reminded by Raf Czlonka (rczlonka <at> gmail <dot> com) OK tb@ claudio@
2022-03-31'e' is no longer an optional element for ober_scanf_elements.Martijn van Duren
This caused the last attribute to be dropped. Reported by Allan Streib (astreib <at> fastmail <dot> fm) Reminded by Raf Czlonka (rczlonka <at> gmail <dot> com) OK tb@ claudio@
2022-03-31regression test for sftp cp commandDamien Miller
2022-03-31add a sftp client "cp" command that supports server-side copyingDamien Miller
of files. Useful for this task and for testing the copy-data extension. Patch from Mike Frysinger; ok dtucker@
2022-03-31add support for the "corp-data" protocol extension to allowDamien Miller
server-side copies to be performed without having to go via the client. Patch by Mike Frysinger, ok dtucker@
2022-03-31Move knote_processexit() call from exit1() to the reaper().Todd C. Miller
This fixes a problem where NOTE_EXIT could be received before the process was officially a zombie and thus not immediately waitable. OK deraadt@ visa@
2022-03-30select post-quantum KEX sntrup761x25519-sha512@openssh.com as theDamien Miller
default; ok markus@
2022-03-30fix poll() spin when a channel's output fd closes without data in theDamien Miller
channel buffer. Introduce more exact packing of channel fds into the pollfd array. fixes bz3405 and bz3411; ok deraadt@ markus@
2022-03-30Mention constification of *_hw_if (files forgotten during constificationMiod Vallat
commit)
2022-03-30Simplify up_generate_updates()Theo Buehler
Instead of using new == NULL or new != NULL in combination with an again label to steer the control flow of this function, switch to using a while loop and break/continue/return. Simplified version of a diff by claudio. ok claudio
2022-03-30Add a simple test to ensure that pmeth->cleanup() can cope with NULLTheo Buehler
pkey_ctx->data.
2022-03-30Avoid segfaults in EVP_PKEY_CTX_free()Theo Buehler
It is possible to call pmeth->cleanup() with an EVP_PKEY_CTX whose data is NULL. If pmeth->init() in int_ctx_new() fails, EVP_PKEY_CTX_free() is called with such a context. This in turn calls pmeth->cleanup(), and thus these cleanup functions must be careful not to use NULL data. Most of them are, but one of GOST's functions and HMAC's aren't. Reported for HMAC by Masaru Masada https://github.com/libressl-portable/openbsd/issues/129 ok bcook jsing
2022-03-30pkey_hmac_init(): use calloc()Theo Buehler
Instead of using malloc() and setting most struct members to 0, simply use calloc(). ok bcook jsing
2022-03-30Capture up to used size not available size for each line.Nicholas Marriott
2022-03-30Remove double slash in path to test program.Anton Lindqvist
2022-03-30Flag the kq-tun regress test as skipped as opposed of only mentioning itAnton Lindqvist
in a comment. Allows my own regress runner (and bluhm's) to highlight kqueue as having skipped tests. While here, get rid of redundant usage of phony.
2022-03-30ssh is almost out of getopt() characters; note the remainingDamien Miller
remaining available ones in a comment
2022-03-30avoid NULL deref via ssh-keygen -Y find-principals. bz3409, reportedDamien Miller
by Mateusz Adamowski
2022-03-30If enough MSI-X vectors are available, set up multiple tx and rx queues.Jonathan Matthew
In multi-vector mode, the MSI-X vector number is the same as the irq number on the nic, so use vector/irq 0 for link interrupts, then assign one to each pair of rx and tx queues. We don't configure RSS yet, so packets will only be received on the first queue, but they can be transmitted on any queue. ok dlg@
2022-03-29Add Eric Biggers's reproducer for the memory corruption withTheo Buehler
the Z_DEFAULT_STRATEGY.
2022-03-29Of the enabled tests only kq-pty-1 needs root, so reduceTheo Buehler
REGRESS_ROOT_TARGTES and remove ${SUDO} from kq-pty-2. kq-tun also needs root, but it isn't run. discussed with and ok millert
2022-03-29Regression test for NOTE_EXIT being delivered before child is waitable.Todd C. Miller
2022-03-29Update list ofarchitecturesJeremie Courreges-Anglas
Retire sparc (32 bits) and vax, add riscv64. From Raf Czlonka
2022-03-29man pages: add missing word, The foo() ... -> The foo() function ...Christian Weisgerber
ok jmc@ schwarze@
2022-03-29Given asn1/a_object.c rev. 1.45 by jsing@, stop talking about BUGSIngo Schwarze
we no longer have, focus on what our implementation now does, but keep short warnings in how far other implementations might be more fragile. Some improvements to wordings and clarity while here. OK tb@
2022-03-29Add Google Chromium tests for libz bugs. Write a minimal wrapperAlexander Bluhm
to avoid importing GoogleTest, Google's C++ test framework.
2022-03-29Disable the recently introduced logic used to associate ucc and audioAnton Lindqvist
devices. Caspar Schutijser reported on bugs@ that pressing the volume keys on his headset causes a usb host controller interrupt storm. I'm trying to figure out what's going on but since we're approaching release keep it disabled.
2022-03-29man pages: add missing commas in enumerationsChristian Weisgerber
2022-03-29Bound cofactor in EC_GROUP_set_generator()Theo Buehler
Instead of bounding only bounding the group order, also bound the cofactor using Hasse's theorem. This could probably be made a lot tighter since all curves of cryptographic interest have small cofactors, but for now this is good enough. A timeout found by oss-fuzz creates a "group" with insane parameters over a 40-bit field: the order is 14464, and the cofactor has 4196223 bits (which is obviously impossible by Hasse's theorem). These led to running an expensive loop in ec_GFp_simple_mul_ct() millions of times. Fixes oss-fuzz #46056 Diagnosed and fix joint with jsing ok inoguchi jsing (previous version)
2022-03-29off-by-one check didn't recognize partition 'a' section on specifiedTheo de Raadt
disk, and would fall through to the active partition selection from crystal kolipe, ok miod krw
2022-03-29Do not zero cofactor on ec_guess_cofactor() successTheo Buehler
The cofactor we tried to calculate should only be zeroed if we failed to compute it. ok inoguchi jsing
2022-03-29Zap trailing whitespaceTheo Buehler
2022-03-29close enough to release, we drop -betaTheo de Raadt
2022-03-29bring back getting framebuffer size from efifb (rev 1.3)Jonathan Gray
avoids the following on BESSTAR TECH HM90 with Ryzen 9 4900H (renoir) reported by Fredrik Engberg drm:pid0:gmc_v9_0_process_interrupt *ERROR* [mmhub0] no-retry page fault (src_id:0 ring:158 vmid:0 pasid:0, for process pid 0 thread pid 0) drm:pid0:gmc_v9_0_process_interrupt *ERROR* in page starting at address 0x0000000000561000 from IH client 0x12 (VMC) drm:pid0:gmc_v9_0_process_interrupt *ERROR* VM_L2_PROTECTION_FAULT_STATUS:0x00003B3C drm:pid0:gmc_v9_0_process_interrupt *ERROR* Faulty UTCL2 client ID: VCNU (0x1d) drm:pid0:gmc_v9_0_process_interrupt *ERROR* MORE_FAULTS: 0x0 drm:pid0:gmc_v9_0_process_interrupt *ERROR* WALKER_ERROR: 0x6 drm:pid0:gmc_v9_0_process_interrupt *ERROR* PERMISSION_FAULTS: 0x3 drm:pid0:gmc_v9_0_process_interrupt *ERROR* MAPPING_ERROR: 0x1 drm:pid0:gmc_v9_0_process_interrupt *ERROR* RW: 0x0 [drm] *ERROR* ring vcn_dec test failed (-60) [drm] *ERROR* hw_init of IP block <vcn_v2_0> failed -60 drm:pid0:amdgpu_device_init *ERROR* amdgpu_device_ip_init failed drm:pid0:amdgpu_attachhook *ERROR* Fatal error during GPU init
2022-03-29Basic copy editing:Ingo Schwarze
Eliminate weasel words and needless parentheses, reduce "will" and "shall" and "may", add more precision, some grammar fixes, shorten and improve wordings, add some missing macros. Triggered by a question from naddy@.
2022-03-28Running getty(8) on /dev/console when using a glass console interferes withMark Kettenis
running Xorg in a way that isn't fully understood. So change the arm64 install.md to munge /etc/ttys to enable the ttyC0 entry if we detect that wsdisplay0 is the console and make sure the code in install.sub that does the actual munging disables the console entry before enabling another entry to prevent running two getty(8) processes on (effectively) the same device. ok deraadt@
2022-03-28if_detach() does if_remove(ifp); NET_LOCK(); rti_delete(). NewAlexander Bluhm
igmp groups may join while sleeping in interface destruction. In this case if_get() in igmp_joingroup() fails and rti_fill() is not called. Then inm->inm_rti may be NULL. This is the condition when syzkaller crashes in igmp_leavegroup(). Pass the ifp the current CPU is already holding down to igmp_joingroup() and igmp_leavegroup() to avoid half constructed igmp groups. Calling if_get() in caller and callee makes no sense anyway. Reported-by: syzbot+146823a676b7bea83649@syzkaller.appspotmail.com OK denis@
2022-03-28Only SLIST_REMOVE() a link when the link is on the list.Kenneth R Westerback
Avoids a potential panic.
2022-03-28Compare the SKI of the embedded EE certificate of the CMS message with theClaudio Jeker
SID of the Signer Info structure. RFC6488 mandates this. OK job@ tb@
2022-03-28Change internal functions to static in openssl(1) pkcs12Kinichiro Inoguchi
ok tb@
2022-03-28Remove unused function cert_load in openssl(1) pkcs12Kinichiro Inoguchi
ok tb@
2022-03-28Fix misspelled NM town names, from personal knowledge, checked against USPS.Anthony J. Bentley