summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-23Avoid crash in BN_asc2bn()Theo Buehler
Historically (and currently in OpenSSL), BN_asc2bn() could be called with NULL, but only for positive numbers. So BN_asc2bn(NULL, "1") would succeed but BN_asc2bn(NULL, "-1"), would crash. The other *2bn functions return a length, so accepting a NULL makes some sense since it allows callers to skip over part of the string just parsed (atoi-style). For BN_asc2bn() a NULL bn makes no sense because it returns a boolean. The recent CBS rewrite makes BN_asc2bn(NULL, *) always crash which in turn made Coverity throw a fit. Another change of behavior from that rewrite pertains to accidents (or is it madness?) like -0x-11 and 0x-11 being parsed as decimal -17 (which Ingo of course spotted and diligently documented). This will be addressed later. ok jsing
2023-06-23Fix return check for BN_hex2bn()Theo Buehler
Purely cosmetic change taking into account the fact that this function returns a length rather than a boolean. This is the last offender in the library. ok jsing
2023-06-23Fix return check of bn_hex2bn_cbs()Theo Buehler
It returns a length, not a Boolean, so check for 0 explicitly. This is purely cosmetic. ok jsing
2023-06-23typo: hexidecimal -> hexadecimalTheo Buehler
2023-06-23Remove some redundant parenthesesTheo Buehler
This file is already enough of an eyesore without them.
2023-06-23rpki-client: check for duplicate certificate extensionsTheo Buehler
RFC 5280 disallows multiple extensions with the same OID. Since libcrypto does not check that currently, do this by hand. This only deals with CA certs for now, EE certs could do that similarly. Found with BBN test corpora ok job
2023-06-23rpki-client: disallow empty sets of IP Addresses or AS numbersTheo Buehler
RFC 3779 doesn't say anything about empty lists of IP addresses and AS numbers. Of course the RFC 3779 code in libcrypto implements a check for empty lists for AS numbers but fails to do so for IP addresses... While RFC 6487 is explicit about disallowing empty lists of IP addresses, it is not explicit about disallowing empty ipAddressesOrRanges, but that seems to be the intent. Found with BBN test corpora ok job
2023-06-23Revert previous, not all platforms allow compilingOtto Moerbeek
__builtin_return_address(a) with a != 0.
2023-06-23Avoid division by 0 in m_pool_usedGreg Steuck
OK dlg@ Reported-by: syzbot+a377d5cd833c2343429a@syzkaller.appspotmail.com
2023-06-23ksmn(4): Support thermal sensors on Ryzen 9 79xxMike Larkin
ok deraadt, brynet
2023-06-22symbols: Tweak this test so it works with -j NTheo Buehler
2023-06-22Revert "clockintr_cpu_init: initialize starting offsets with ↵Scott Soule Cheloha
clockintr_stagger()" octeon machines do not increment the global variable "ncpus" (init_main.c) in the same spot as other platforms, which violates the KASSERT in clockintr_stagger(), causing a panic. We need to bring octeon's behavior into alignment with every other platform before proceeding with this patch. Reported and debugged by bluhm@.
2023-06-22Mention lid position support.Tobias Heider
From Jan Stary
2023-06-22Add machdep.lidaction example. We support this on arm64 laptops now.Tobias Heider
From Jan Stary Ok patrick@
2023-06-22Instead of tsleep on lbolt do a tsleep with a 1 second timeout.Claudio Jeker
Result is the same and gets rid of a lbolt use. OK miod@
2023-06-22Allow to ask for deeper callers for leak reports using malloc options.Otto Moerbeek
ok deraadt@
2023-06-22Use new ibu API, switch from ibuf_seek() to ibuf_set().Claudio Jeker
Also use ibuf_data() and ibuf_size(). OK tb@
2023-06-22KNFClaudio Jeker
2023-06-22drm/amdgpu: Don't set struct drm_driver.output_poll_changedJonathan Gray
From Thomas Zimmermann 4b4cae8e4b37c7ad4d9721dbda060a62e49e3c17 in linux-6.1.y/6.1.35 0e3172bac3f43759719384403fe2d1e4c61f87e0 in mainline linux
2023-06-22drm/amdgpu: add missing radeon secondary PCI IDJonathan Gray
From Alex Deucher 21863dc45aed8d68a2573cce032ecbc8fe7c5bf5 in linux-6.1.y/6.1.35 e61f67749b351c19455ce3085af2ae9af80023bc in mainline linux
2023-06-22drm/amd/pm: workaround for compute workload type on some skusJonathan Gray
From Kenneth Feng 6f5b5ce9397d91b0a8bc8d15dc8fd72bc0aacaa4 in linux-6.1.y/6.1.35 7ca302d488f80cf4529620acc1c545f9022d8bb8 in mainline linux
2023-06-22drm/amd: Tighten permissions on VBIOS flashing attributesJonathan Gray
From Mario Limonciello b69a10df900386871703a4cc3be974485f52ff7c in linux-6.1.y/6.1.35 7ab1a4913d0051cf5196ef7987b5fa42c25e13b6 in mainline linux
2023-06-22drm/amd: Make sure image is written to trigger VBIOS image update flowJonathan Gray
From Mario Limonciello b2706d862b6577b8218bdef1c238e175624b906d in linux-6.1.y/6.1.35 3eb1a3a04056ba3df3205e169b8acc9da0c65a94 in mainline linux
2023-06-22drm/amd/display: edp do not add non-edid timingsJonathan Gray
From Hersen Wu ee8c6580c3106b0061c7cdff1804e5a1f1e1d7fe in linux-6.1.y/6.1.35 e749dd10e5f292061ad63d2b030194bf7d7d452c in mainline linux
2023-06-22drm/amdgpu: vcn_4_0 set instance 0 init sched score to 1Jonathan Gray
From Sonny Jiang 5d1fdfb3d185a9726478ba174235eff7c16f1101 in linux-6.1.y/6.1.35 9db5ec1ceb5303398ec4f899d691073d531257c3 in mainline linux
2023-06-22drm:amd:amdgpu: Fix missing buffer object unlock in failure pathJonathan Gray
From Sukrut Bellary 8ca9880735b0a33a4ff54328d6c5eb60fe2b0a6d in linux-6.1.y/6.1.35 60ecaaf54886b0642d5c4744f7fbf1ff0d6b3e42 in mainline linux
2023-06-22drm: panel-orientation-quirks: Change Air's quirk to support Air PlusJonathan Gray
From Maya Matuszczyk c45aed74318e65b8da938a593c124ad2ee1a1e66 in linux-6.1.y/6.1.35 1aa7f416175619e0286fddc5fc44e968b06bf2aa in mainline linux
2023-06-21Remove extra trailing whitespaceMike Larkin
ok stsp
2023-06-21ksh: escape control chars when displaying file name completions.Todd C. Miller
If there are multiple matches when using autocomplete, the list of matching file names was output as-is. However, for a single match, control characters are escaped before the file name is displayed. This makes the behavior more consistent by escaping control chars in the list of matches too. Discussed with deraadt@, OK op@
2023-06-21Revert "schedcpu, uvm_meter(9): make uvm_meter() an independent timeout"Scott Soule Cheloha
Sometimes causes boot hang after mounting root partition. Thread 1: https://marc.info/?l=openbsd-misc&m=168736497407357&w=2 Thread 2: https://marc.info/?l=openbsd-misc&m=168737429214370&w=2
2023-06-21clear errno before strtoull as it may already be set to ERANGEOmar Polo
noticed and ok millert@
2023-06-21avoid truncation of filtered data linesOmar Polo
Don't copy in a buffer the filter' output for parsing as we may truncate filter-dataline (i.e. the mail body). Instead, parse the string by advancing the pointer without copying or modifications. Issue reported by Joachim Schneider on the OpenSMTPD-portable repository. ok millert@
2023-06-21Use recallocarray() consistently. recallocarray() was introduced to simplifyClaudio Jeker
exactly this use case where the new memory needs to be zeroed during resize. Since recallocarray() takes care of all this there is no need to bzero() memory anymore. OK tb@ millert@
2023-06-21Add a parameter 'action' to mpfree() so it can optionally discardKenneth R Westerback
or keep the memory pointed at by the char ** parameter. Allows mpfree() to be used against the global mountpoints[] and eliminates a couple of manual loops to free the current contents of mountpoints[]. No intentional functional change.
2023-06-21add "fib reload" support to ospf6d/ospf6ctl, and trigger itStuart Henderson
automatically on a timeout after RTM_DESYNC (i.e. route socket overflow). ported across from ospfd. fixes/ok claudio@ (it's much harder to overflow the routing socket buffer these days since it was bumped to 2MB, but still happens occasionally on a busy machine).
2023-06-21Provide optimised bn_clzw() for aarch64.Joel Sing
2023-06-21Simplify and clean up the code. Try to use more ibuf idioms but theClaudio Jeker
mix of types used in these functions make this rather hard. The expected data checks are still not great but a step in the right direction. OK tb@
2023-06-21Convert string2binary() to use new ibuf api instead of working with anClaudio Jeker
extra buffer first. OK tb@
2023-06-21Provide and use bn_clzw() in place of bn_word_clz().Joel Sing
On some architectures, we can provide an optimised (often single instruction) count-leading-zero implementation. In order to do this effectively, provide bn_clzw() as a static inline that can be replaced by an architecture specific version. The default implementation defers to the bn_word_clz() function (which may also be architecture specific). ok tb@
2023-06-21Update ospf6d to use new ibuf api.Claudio Jeker
This mostly moves away from memcpy(ibuf_seek(buf, off, size), data, size) to ibuf_set(buf, off, data, size). Also ibuf_reserve() is replaced with ibuf_add_zero(). OK tb@
2023-06-21Remove extra newlinesClaudio Jeker
2023-06-21Make BN_num_bits() independent of bn->top.Joel Sing
Provide bn_bitsize(), which performs a constant time scan of a BN in order to determine the bit size of the BN value. Use this for BN_num_bits() such that it is no longer dependent on the bn->top value. ok tb@
2023-06-21Add tests for BN_sqr() corner cases.Joel Sing
Test BN_sqr() with a newly allocated BN, a BN explicitly set to zero and small values that fit in a single BN_ULONG.
2023-06-21Add BN_cmp()/BN_ucmp() tests with zero padded inputs.Joel Sing
Currently BN_hex2bn() removes the leading zeros, however this will not be the case in the future.
2023-06-21Add a BN_num_bits() with zero padded input.Joel Sing
Currently BN_hex2bn() removes the leading zeros, however this will not be the case in the future.
2023-06-21Check fdopen return value, from Christian Menges.Nicholas Marriott
2023-06-21better validate CASignatureAlgorithms in ssh_config and sshd_config.Damien Miller
Previously this directive would accept certificate algorithm names, but these were unusable in practice as OpenSSH does not support CA chains. part of bz3577; ok dtucker@
2023-06-21make `ssh -Q CASignatureAlgorithms` only list signature algorithms thatDamien Miller
are valid for CA signing. Previous behaviour was to list all signing algorithms, including certificate algorithms (OpenSSH certificates do not support CA chains). part of bz3577; ok dtucker@
2023-06-21handle rlimits > INT_MAX (rlim_t is u64); ok dtuckerDamien Miller
bz3581
2023-06-21call rk3328 not rk3288 functions in rk3328_pinctrl()Jonathan Gray
tested by and ok kettenis@