summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-06-24Some KNF.Joel Sing
2014-06-24Replace 48 lines of code with a single inet_pton() call. The previousJoel Sing
handrolled version could not even make use of sscanf(), since that would not work with a certain antiquated compiler. It is worth noting that there is a tiny change in behaviour - previously calling BIO_get_host_ip() with something that looked like it might be a valid IP address (for example, "1." or even ".") would result in it returning failure rather than trying a BIO_gethostbyname() - now we'll always try a BIO_gethostbyname() if it was not a valid IPv4 address. ok beck@ miod@ deraadt@
2014-06-24Actually make BIO_set_tcp_ndelay() work - TCP_NODELAY will not magicallyJoel Sing
appear by itself. ok beck@ miod@
2014-06-24The Perl close() function, when called on pipe file descriptors,Ingo Schwarze
provides information from wait(2), which needs careful inspection in order to not hide errors. Problem identified by florian@ after a bug report from otto@. Fix based on a patch from florian@, considerably tweaked by me. OK florian@
2014-06-24Do not try to pass potentially non-existent array elements intoIngo Schwarze
functions since that is going to kill the Perl interpreter. While here, do not attempt to parse $PATH or $ENV when undefined. Crash found the hard way with a dubious /root/.login file by otto@ who declares himself unable to read perl code even though he can apparently debug it with ktrace(1) - thanks for the excellent bug report! Feedback and ok florian@.
2014-06-24Fixup the test after new queue code has been added.Mike Belopuhov
You can't load a ruleset with undefined queues into the anchor. Change the test to use "set prio" since the whole purpose of it is to test the flexibility of the pf.conf language, not a particular queue feature.
2014-06-24do not prompt for overwrite when none is neccessary using the -F optionJason McIntyre
(which is off by default anyway); netbsd -r1.49, from wiz@netbsd
1998-03-11Lynx 2.8Mats O Jansson
2014-06-24Fix memory leak.Loganaden Velvindron
Thanks to Brenk Cook. OK from miod@
2014-06-24remove the noaccesstime synonym for noatime which was previously added for ↵Daniel Dickman
BSD/OS compatibility. ok deraadt@, miod@i, millert@
2014-06-24when copying local->remote fails during read, don't send uninitialisedDamien Miller
heap to the remote end. Reported by Jann Horn
2014-06-24don't fatal() when hostname canonicalisation fails with aDamien Miller
ProxyCommand in use; continue and allow the ProxyCommand to connect anyway (e.g. to a host with a name outside the DNS behind a bastion)
2014-06-24New key API: refactor key-related functions to be more library-like,Damien Miller
existing API is offered as a set of wrappers. with and ok markus@ Thanks also to Ben Hawkes, David Tomaschik, Ivan Fratric, Matthew Dempsky and Ron Bowes for a detailed review a few months ago.
2014-06-24unit and fuzz tests for new key APIDamien Miller
2014-06-24New key API: refactor key-related functions to be more library-like,Damien Miller
existing API is offered as a set of wrappers. with and ok markus@ Thanks also to Ben Hawkes, David Tomaschik, Ivan Fratric, Matthew Dempsky and Ron Bowes for a detailed review a few months ago.
2014-06-24regress test for broken consecutive revoked serial number rangesDamien Miller
2014-06-24fix bug in KRL generation: multiple consecutive revoked certificateDamien Miller
serial number ranges could be serialised to an invalid format. Readers of a broken KRL caused by this bug will fail closed, so no should-have-been-revoked key will be accepted.
2014-06-23repair ramdisk buildsTheo de Raadt
2014-06-23Since this is a library, place issetugid() before every getenv()Theo de Raadt
ok miod
2014-06-23Below DIAGNOSTICS, document the SYSERR message level;Ingo Schwarze
jmc@ wondered what it meant and agrees with this patch.
2014-06-23Add regress test for SIGSEGV and SIGBUS siginfo semantics.Matthew Dempsky
According to POSIX, SIGSEGV should specify SEGV_ACCERR if the memory pages are mapped, but the protections don't match the user's access attempts, while SEGV_MAPERR should only be specified for pages that are unmapped. Some platforms currently handle this correctly, but not all. Additionally, SIGBUS/BUS_ADRERR should be generated instead of SIGSEGV for access to file mapped pages that exceed the end of the file. (Thanks to kettenis@ for suggesting this test.) Currently failing, so not linked into the regress tree yet.
2014-06-23gcc4: emit warning when ignoring alignment constraintsMatthew Dempsky
Currently, GCC 4.2 silently ignores the "aligned" attribute for objects allocated on the stack if the specified minimum alignment exceeds the platform's natural stack alignment. This has bitten us in the past, so we shouldn't allow this to continue. Fixing the "ignores" problem seems hard, so this commit settles for tackling the "silently" problem instead. ok miod, and possibly guenther and deraadt
2014-06-23first attempt at documenting NOINET6 by default and eui64 turning it on againHenning Brauer
2014-06-23Fix possible crash on invalid filesystems.Tobias Stoeckmann
Merged from FreeBSD's revision 206098. ok beck@
2014-06-23turn of IPv6 for new interfaces by default. this really just means thereHenning Brauer
is no link-local address assigned by default, which - by default, since INET6 is in the GENERIC kernels - makes the machine and services on it reachable. No such thing in IPv4 land. since assigning an inet6 address manually or running rtsol(d) etc resets the NOINET6 flag and causes the link-local to be assigned, this really is a noop for all inet6 users with the exception of those ONLY using the default link-local address. These needs to run "ifconfig <if> inet6 eui64" or put the equivalent in hostname.if. discussed at length with many, ok at least by krw todd benno sthen
2014-06-23SystemMemory is used to access memory mapped registers on some machines, so weMark Kettenis
must use the bus_space(9) API to access it instead of memcpy(9). Also make sure we properly align access to fields that need more than byte alignment. ok guenther@
2014-06-23make "ifconfig <if> inet6 eui64" reset the NOINET6 flagHenning Brauer
(unconditionally), so a link-local will be assigned if there isn't one yet. ok krw benno todd sthen
2014-06-23add another supported model;Jason McIntyre
from edward (myself rdtan net)
2014-06-23Fix compile without IPSEC.YASUOKA Masahiko
Pointed out by Ivan Solonin. ok henning mpi jca
2014-06-23Allow keys and send-keys to invisible panes, from saggy-kun at users dotNicholas Marriott
sf dot net.
2014-06-23Count mouse clicks correctly, from Balazs Kezes.Nicholas Marriott
2014-06-23unbreak build of getentropy_sysctl - we need linux/sysctl.h, andBob Beck
RANDOM_UUID is an enum member.
2014-06-23unbreak - main needs to be extern in here somewhere.Bob Beck
2014-06-22Add regress tests for BIO_get_host_ip().Joel Sing
2014-06-21matthew reminds me to update regress to reflect current specTed Unangst
2014-06-21repair indentation for an inner loop; shorten some macros and variableTheo de Raadt
names to shorten line lengths ok beck
2014-06-21loosen the spec for timingsafe functions slightly, so as to notTed Unangst
artificially constrain alternative implementations. ok deraadt
2014-06-21fix expected message levelIngo Schwarze
2014-06-21Move to a non-zeroing _dl_malloc, a _dl_calloc and _dl_reallocarry andOtto Moerbeek
fix _dl_strdup to return NULL instead of crash; ok deraadt@
2014-06-21hash in correct pointerTheo de Raadt
2014-06-20As suggested by jmc@, only include line and column numbers into messagesIngo Schwarze
when they are meaningful, to avoid confusing stuff like this: $ mandoc /dev/null mandoc: /dev/null:0:1: FATAL: not a manual Instead, just say: mandoc: /dev/null: FATAL: not a manual Another example this applies to is documents having a prologue, but lacking a body. Do not throw a FATAL error for these; instead, issue a warning and show the empty document, in the man(7) case with the same amount of blank lines as groff does. Also downgrade mdoc(7) documents having content before the first .Sh from FATAL to WARNING.
2014-06-20KNFBob Beck
2014-06-20indentTheo de Raadt
2014-06-20rearrange so that the main function with the important comments is at the topOtto Moerbeek
ok deraadt@ beck@
2014-06-15occured -> occurred;Jason McIntyre
2014-06-15move to a smaller rbytes buffer; ok miod@ deraadt@Otto Moerbeek
2014-06-14Change return value of getentropy() to int 0 for success. MaximumTheo de Raadt
buffersize is enforced strictly, this supplies sufficient entropy payload to act as seed material. Discourage general use of this API, but lock down this function name as the go-to for userland PRNG seeding. Improve documentation. ok miod matthew
2014-06-13typo; Piotr SikoraTheo de Raadt
2014-06-13Add timingsafe_memcmp().Matthew Dempsky
ok deraadt, jmc, tedu
2014-06-23The second level of the CTL_NET sysctl is a PF_*, not an AF_*Philip Guenther
inconsistent usage in route(8) noted by Gregor Best (gbe (at) ring0.de)