summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-04KNF nitTheo Buehler
2022-06-04Tweak a comment using review feedback from jsingTheo Buehler
2022-06-03Memory leak when assigning a string to some of the built-in variables.Todd C. Miller
Allocated string erroneously marked DONTFREE. From Miguel Pineiro Jr.
2022-06-03The fulfillment of an assignment operand had been truncating itsTodd C. Miller
entry in ARGV (since circa 1989). From Miguel Pineiro Jr.
2022-06-03Fix a file management memory leak that appears to have been thereTodd C. Miller
since the files array was first initialized with stdin, stdout, and stderr (circa 1992). From Miguel Pineiro Jr.
2022-06-03Add stubbed out handlers for the pre_shared_key extensionTheo Buehler
ok jsing
2022-06-03Implement handlers for the psk_key_exchange_modes extensions.Theo Buehler
ok jsing
2022-06-03Add a use_psk_dhe_ke flag to the TLSv1.3 handshake structTheo Buehler
This will be used to indicate client side support for DHE key establishment. ok jsing
2022-06-03Ensure that a client who sent a PSK extension has also sent a PSKTheo Buehler
key exchange mode extension, as required by RFC 8446, 4.2.9. ok jsing
2022-06-03Check tls_config_new() for NULL returnTheo Buehler
This way we don't crash in tls_config_insecure_noverify_cert(). From Mateusz Piotrowski on bugs ok claudio
2022-06-03Provide #defines for the two currently registered PskKeyExchangeModes.Theo Buehler
ok jsing
2022-06-03oops, update forgotten date in the footerIngo Schwarze
2022-06-03During identifier parsing, handle undefined escape sequencesIngo Schwarze
in the same way as groff: * \\ is always reduced to \ * \. is always reduced to . * other undefined escape sequences are usually reduced to the escape name, for example \G to G, except during the expansion of expanding escape sequences having the standard argument form (in particular \* and \n), in which case the backslash is preserved literally. Yes, this is confusing indeed. For example, the following have the same meaning: * .ds \. and .ds . which is not the same as .ds \\. * \*[\.] and \*[.] which is not the same as \*[\\.] * .ds \G and .ds G which is not the same as .ds \\G * \*[\G] and \*[\\G] which is not the same as \*[G] <- sic! To feel less dirty, have a leaning toothpick, if you are so inclined. This patch also slightly improves the string shown by the "escaped character not allowed in a name" error message.
2022-06-03expose hardware counters as kstats.David Gwynne
some of them are 16 bit, so check frequently. now i can see what packets my apu1 is dropping in hardware. ok claudio@
2022-06-03Do not unintentionally turn off all mouse mode when button is also present.Nicholas Marriott
2022-06-03move auth_openprincipals() and auth_openkeyfile() over toDamien Miller
auth2-pubkeyfile.c too; they make more sense there.
2022-06-03test setenv in both client and server, test first-match-wins tooDamien Miller
2022-06-03Make SetEnv directives first-match-wins in both sshd_config andDamien Miller
sshd_config; previously if the same name was reused then the last would win (which is the opposite to how the config is supposed to work). While there, make the ssh_config parsing more like sshd_config. bz3438, ok dtucker
2022-06-03Add missing *-sk types to ssh-keyscan manpage.Darren Tucker
From skazi0 via github PR#294.
2022-06-03Add period at end of "not known by any other names" message. github PR#320Darren Tucker
from jschauma, ok djm@
2022-06-03ssh-keygen -A: do not generate DSA keys by default. Based on github PR#303Darren Tucker
from jsegitz with man page text from jmc@, ok markus@ djm@
2022-06-03fix the definition of the MVNETA_PRXITTH Port RX Intr Threshold registerDavid Gwynne
2022-06-02Let btrace(8) execute the END probe upon receiving a SIGTERM signalJeremie Courreges-Anglas
While SIGINT (already handled) makes sense for interactive use, handling SIGTERM in the same manner is less surprising for scripting. This lets you do: btrace ... & some workload; kill $! and get the expected output. ok mpi@
2022-06-02Do not attempt to use client in config file (it will be NULL), GitHubNicholas Marriott
issue 3206.
2022-06-02When deleting or renaming a buffer and a buffer name is specified,Nicholas Marriott
complain if the buffer doesn't exist instead of silently deleting or renaming the most recent buffer. GitHub issue 3205.
2022-06-02Take the size of allocation into account when checking the kernel reserve.Mark Kettenis
ok mpi@
2022-06-02Don't treat the first arg as a 4.3BSD option string if it contains a '/'.Todd C. Miller
Also document that files-to-dump could be interpreted as a 4.3BSD option if it doesn't contain a slash. OK deraadt@
2022-06-02Since \. is not a character escape sequence, re-classify it from theIngo Schwarze
wrong parsing class ESCAPE_SPECIAL to the better-suited parsing class ESCAPE_UNDEF, exactly like it is already done for the similar \\, which isn't a character escape sequence either. No formatting change is intended just yet, but this will matter for upcoming improvements in the parser for roff(7) macro, string, and register names. See the node "5.23.2 Copy Mode" in "info groff" regarding what \\ and \. really mean.
2022-06-02Use consistent spacing around assignmentsTheo Buehler
2022-06-02Only constraints and verify need static linking in here.Theo Buehler
2022-06-02Avoid the layering violation of re-parsing for \E in roff_expand().Ingo Schwarze
To that end, add another argument to roff_escape() returning the index of the escape name. This also makes the code in roff_escape() a bit more uniform in so far as it no longer needs the "char esc_name" local variable but now does everything with indices into buf[]. No functional change.
2022-06-02Adjust lowest allowed routing priority to be bigger than RTP_LOCAL.Claudio Jeker
RTP_LOCAL is internally used by the kernel and is not available for userland. The minimal usable routing prio is 2. OK tb@
2022-06-02Use a common idiom to check if the user supplied routing priority isClaudio Jeker
in range. Also rephrase the error message. OK tb@
2022-06-02Cleanup ktable_exists() usage and its warning message.Claudio Jeker
Check the return value in all cases and use a common idiom for this check. OK tb@
2022-06-02Adjust some warning messages to be a bit more accurate. ktable_update()Claudio Jeker
actually loads a routing table and not really an rdomain.
2022-06-02When running sysupgrade on -stable move to the next release, notFlorian Obser
-current. Found the hard way by & OK sthen
2022-06-02Implement and enable IPv4, TCP, and UDP checksum offloading for igc.mbuhl
ok kevlo@
2022-06-02Stop hiding a few assertions behind the opt-in LOCKF_DIAGNOSTIC option.Anton Lindqvist
This code has already been exercised quite extensively by syzkaller and got decent test coverage.
2022-06-02enable aq(4) on arm64 now that it works reasonably wellJonathan Matthew
2022-06-01Fix a buffer overrun in the roff(7) escape sequence parser that couldIngo Schwarze
be triggered by macro arguments ending in double backslashes, for example if people wrote .Sq "\\" instead of the correct .Sq "\e". The bug was hard to find because it caused a segfault only very rarely, according to my measurements with a probability of less than one permille. I'm sorry that the first one to hit the bug was an arm64 release build run by deraadt@. Thanks to bluhm@ for providing access to an arm64 machine for debugging purposes. In the end, the bug turned out to be architecture-independent. The reason for the bug was that i assumed an invariant that does not exist. The function roff_parse_comment() is very careful to make sure that the input buffer does not end in an escape character before passing it on, so i assumed this is still true when reaching roff_expand() immediately afterwards. But roff_expand() can also be reached from roff_getarg(), in which case there *can* be a lone escape character at the end of the buffer in case copy mode processing found and converted a double backslash. Fix this by handling a trailing escape character correctly in the function roff_escape(). The lesson here probably is to refrain from assuming an invariant unless verifying that the invariant actually holds is reasonably simple. In some cases, in particular for invariants that are important but not simple, it might also make sense to assert(3) rather than just assume the invariant. An assertion failure is so much better than a buffer overrun...
2022-06-01change amd64 pmap_convert to return voidDave Voutila
There are no other return options, so adjust function signature to void. This also allows for cleaning up its usage in vmm(4) in the vm pmap initialization logic. ok mlarkin@
2022-06-01callers to pf(4) must continue to run with packet as returnedAlexandr Nedvedicky
by firewall. OK dlg@
2022-06-01remove unused pmap_convert prototype from i386Dave Voutila
Leftover lint from early days of vmm(4). ok mlarkin@
2022-06-01If escape-time is 0, force to 1 instead - not waiting at all is askingNicholas Marriott
for problems on some platforms.
2022-06-01Remove a confusing comment that has been stale since e2k19 (r1.26).Theo Buehler
2022-06-01Add a regress test for the end of lock range ambiguity bug.Visa Hankala
2022-06-01Fix ambiguity with lock range endVisa Hankala
When the user requests a lock range that ends at LLONG_MAX, replace the end point with the special EOF value -1. This avoids ambiguity with lf_end in lf_split(). The ambiguity could result in a broken data structure. This change is visible to userspace in a corner case. When a lock range has been requested with an end point at absolute position LLONG_MAX, fcntl(F_GETLK) returns l_len == 0, instead of a positive value, for that range. This seems consistent with FreeBSD and Linux. OK anton@ Reported-by: syzbot+c93afea6c27a3fa3af39@syzkaller.appspotmail.com
2022-06-01Fix lock range start when l_whence == SEEK_END and l_len < 0.Visa Hankala
OK anton@
2022-06-01Limit the number of RSC checklist FileNameAndHash entries the same wayTheo Buehler
as mft FileAndHash entries are checked. ok claudio job
2022-06-01Fix off-by-one in MAX_MANIFEST_ENTRIES checkTheo Buehler
ok claudio job