summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2006-03-20NetBSD Coverity CID 774: Don't increment a pointer *before* testing it for NULL!David Hill
ok otto@
2006-03-20NetBSD Coverity CID 2074: Fix memory leak.David Hill
ok deraadt@
2006-03-20NetBSD Coverity CID 1745: Fix memory leak.David Hill
yes otto@
2006-03-20NetBSD Coverity CID 2305: Fix memory leak.David Hill
ok deraadt@
2006-03-20spacingTheo de Raadt
2006-03-20be strict with tolower() castingTheo de Raadt
2006-03-20spacingTheo de Raadt
2006-03-20cast xstrdup to propert u_char *Theo de Raadt
2006-03-20x11_fake_data is only ever used as u_char *Theo de Raadt
2006-03-20spacingTheo de Raadt
2006-03-20annoying spacing fixes getting in the way of real diffsTheo de Raadt
2006-03-20sprinkle some ARGSUSED for table driven functions (which sometimes must ↵Theo de Raadt
ignore their args)
2006-03-20sprinkle u_int throughout pty subsystem, ok markusTheo de Raadt
2006-03-20make `rcs -a' use cvs_strsplit() for easiness; OK joris@.Xavier Santolaria
2006-03-20in a switch (), break after return or goto is stupidTheo de Raadt
2006-03-20add missing xfree()'s after we are done with cvs_strsplit();Xavier Santolaria
spotted by ray@, OK joris@.
2006-03-20djm did a typoTheo de Raadt
2006-03-20in a switch (), break after return or goto is stupidTheo de Raadt
2006-03-20When being verbose while deleting ike rules (-dv), print deletions instead ofHans-Joerg Hoexer
additions. Suggested by david@
2006-03-20When adding a connection, do not explicitly start that connectionHans-Joerg Hoexer
using "t" and "c" fifo commands. This is prone to a race when adding several tunnels between the same peers. Just let isakmpd start that connection on its own (using the connection checker).
2006-03-20make sure the command fifo is ready before isakmpd returns. ThisHans-Joerg Hoexer
resolves a startup race when interacting with ipsecctl. Suggested by and discussed with moritz@ ok moritz@
2006-03-20delint; cvs_buf_write_stmp() will never return non-zero:Niall O'Higgins
- remove superfluous error handling for cvs_buf_write_stmp() - change cvs_buf_write_stmp() return type to void ok joris@ xsa@
2006-03-20de-register.Brad Smith
2006-03-20add two missing function declarationsDavid Hill
change sensor_status to sensorsd_status ok deraadt@
2006-03-20for some of internal functions use paddr_t where phys addr is intended ↵Michael Shalayeff
insteadd of u_long; miod@ ok
2006-03-20a bit of demagification. this moves the checks for the cpu scaling featuresDavid Gwynne
out of machdep and into powernow-k7 and -k8. machdep now just figures out if its the right type of cpu before calling the powernow code which figures out if the scaling is supported. from gwk
2006-03-20(really) last of the Coverity diffs: avoid possible NULL deref inDamien Miller
key_free. via elad AT netbsd.org; markus@ ok
2006-03-20report function m4errx, that shows app-specific data (filename/linenumber)Marc Espie
before the error message. Use it to simplify code. okay miod@
2006-03-20remove kernel printfs that say "unable to allocate memory" just beforeDavid Gwynne
returning ENOMEM and the like. userland can say that for us while keeping our dmesg clean.
2006-03-20finer grained use of splbio in the ioctl paths. only use it when dealingDavid Gwynne
with the ccb queues rather than over the whole ioctl. also get rid of the CMD_WAIT flag which is used to restrict the ioctl to only one caller at a time. this is actually protecting from overuse of ccbs for management tasks (like bioctl) by making sure the scsi paths will always have their ccbs. replace the flag with a real lock so that callers can sleep till the mgmt ccb is free, rather than returning EBUSY
2006-03-20shrink the ccb even more. instead of having a "wakeup" member to say whenDavid Gwynne
the ioctl paths can wake up, check the state of the ccb instead. when the ccb becomes READY again then the command has completed.
2006-03-20introduce rt_if_remove which takes care of routing table updates for anHenning Brauer
interface that is removed. use that from if.c and if_tun.c instead of re-implementing in the latter case. ok claudio
2006-03-20remove the bits in the ccb for generalised handling of dmaable memory.David Gwynne
now that each code path that puts commands on the hardware has specific completion routines, we dont have to deal with the memory magic in a generic fashion.
2006-03-20switch the mgmt ioctl path to use the ioctl completion function.David Gwynne
2006-03-20move the drv_inq ioctl path to its own completion routine. all the cleanupDavid Gwynne
of the dmammem is now done in the ioctl, the completion routing simply wakes it up.
2006-03-20get rid of the CCB_READY check in ami_start, it is subtly broken and slowsDavid Gwynne
things down. this path is easy to verify without this code so im just dropping it.
2006-03-20the command queues are important so wrap them up in splbioDavid Gwynne
2006-03-20shorten the setup of the xs timeoutDavid Gwynne
2006-03-20Add a regression test for false positive with ((x == y) == z), fixed inChad Loder
r1.31 of usr.bin/xlint/lint1/tree.c
2006-03-20Lint should not complain about expressions of the form: ((x == y) == z)Chad Loder
because this is perfectly legal in C. deraadt@ was seeing lint false positives with the S_ISREG macro from stat.h. So set m_eqwarn to 0 for the EQ operator. See xlint regress case #16.
2006-03-20memory leaks detected by Coverity via elad AT netbsd.org;Damien Miller
deraadt@ ok that should be all of them now
2006-03-20last lot of GSSAPI related leaks detected by Coverity viaDamien Miller
elad AT netbsd.org; reviewed by simon AT sxw.org.uk; deraadt@ ok
2006-03-20more GSSAPI related leaks detected by Coverity via elad AT netbsd.org;Damien Miller
reviewed by simon AT sxw.org.uk; deraadt@ ok
2006-03-20GSSAPI related leaks detected by Coverity via elad AT netbsd.org;Damien Miller
reviewed by simon AT sxw.org.uk; deraadt@ ok
2006-03-20de-register.Brad Smith
2006-03-20syncBrad Smith
2006-03-20factorize SGMAP-mapped DMA map creation and destroy codeMartin Reindl
ok miod@, additional testing jsg@ from NetBSD
2006-03-20if we're in visual mode reading a command, check the termination valuePeter Valchev
of v_tcmd() and bail if it's not TERM_OK as opposed to in a more specific case. this is based on the NetBSD ^C fix but after discussion with otto@. while it did not affect the specific crash it is more correct.
2006-03-19ANSIfyBrad Smith
2006-03-19ANSIfyBrad Smith