summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-05-30While working on another diff I ended up looking to see why on earth theJoel Sing
DTLS code had a chunk that checked to see if the SSL version was *not* DTLS. Turns out that this is inside a big #if 0 block with a comment explaining why DTLS will never need this code... The DTLS code was clearly written by wholesale copying the SSLv3 code. Any code not applicable to DTLS was seemingly #if 0'd or commented out and left for others to find. d1_pkt.c is copied from s3_pkt.c and it has a do_dtls1_write() function that has the same function signature as do_ssl3_write(), except that the create_empty_fragement (yes, that is the spelling in ssl_locl.h) argument is unused for DTLS (although there is code that pretends to use it) since it uses explicit IV (as the comment notes). Instead of leaving this turd lying around, nuke the #if 0'd code (along with the check for *not* DTLS) and remove the pointless create_empty_fragment argument given the only two do_dtls1_write() calls specify zero. This kind of thing also makes you wonder how much actual peer review occurred before the code was initially committed... ok beck@
2014-05-30Use calloc instead of malloc and memset.YASUOKA Masahiko
from Benjamin Baier
2014-05-30Rework parse_name() so that variable declaration is separate from functionJoel Sing
based initialisation, use more readable variable names and use a goto rather than duplicating the frees for the error and non-error paths... ok beck@
2014-05-30Add definitions for Process and (finally!) ThreadPhilip Guenther
Tweak some error descriptions based on that Completely reword ETXTBSY description based on a suggestion from millert@ tweaks and oks jmc@ millert@ sobrado@
2014-05-30A program is the thing you run; a process is an instance of somethingPhilip Guenther
running ok millert@ sobrado@
2014-05-30remove CONST_STRICT. ok beck deraadtTed Unangst
2014-05-30no need for null check before free. from Brendan MacDonellTed Unangst
2014-05-30Don't write out more than we have allocated in obj_txt, as the gloryBob Beck
that is OBJ_obj2txt() can return a larger value.. ok tedu@
2014-05-30remove some of the bigger lies, as applicable to libressl.Ted Unangst
2014-05-30explicit_bzero for clearing stack variables.Ted Unangst
2014-05-29I do not have time to describe how bad the realloc() uses in here, nowTheo de Raadt
being relaced by reallocarray(). you will have to look at the diff. there can be no explanations for the extra casts. as beck says, "Don't go towards the light theo!" ok beck tedu
2014-05-29trivial realloc -> reallocarrayTheo de Raadt
2014-05-29the comment says RAND_pseudo_bytes should be RAND_bytes. make it so.Ted Unangst
ok deraadt
2014-05-29we no longer care that these aren't used for ssl2Ted Unangst
2014-05-29ok, next pass after review: when possible, put the reallocarray argumentsTheo de Raadt
in the "size_t nmemb, size_t size"
2014-05-29convert 53 malloc(a*b) to reallocarray(NULL, a, b). that is 53Theo de Raadt
potential integer overflows easily changed into an allocation return of NULL, with errno nicely set if need be. checks for an allocations returning NULL are commonplace, or if the object is dereferenced (quite normal) will result in a nice fault which can be detected & repaired properly. ok tedu
2014-05-29Use the same convention for mixer control names as azalia.Alexandre Ratchov
2014-05-29syncTheo de Raadt
2014-05-29Everything sane has stdio, and FILE *. we don't need ifdefs for this.Bob Beck
ok to firebomb from tedu@
2014-05-29remove back compat that was already disabled back in 1998.Ted Unangst
from Alexander Schrijver
2014-05-29Make make includes work again without kssl.hBob Beck
2014-05-29Any sane platform has stdio. Stop pretending we will ever use a platformBob Beck
that does not. "fire bomb" tedu@
2014-05-29kssl is dead.Ted Unangst
2014-05-29no space before labelTed Unangst
2014-05-29line up else betterTed Unangst
2014-05-29define -DLIBRESSL_INTERNAL in here so we don't use nastiesBob Beck
ok deraadt@
2014-05-29consistent bracesTed Unangst
2014-05-29unidef DH, ECDH, and ECDSA. there's no purpose to a libssl without them.Ted Unangst
ok deraadt jsing
2014-05-29repair KNF indentTheo de Raadt
2010-10-01import OpenSSL-1.0.0aDamien Miller
2014-05-29use calloc, from Benjamin BaierTed Unangst
2014-05-29use calloc, from Benjamin BaierTed Unangst
2014-05-29use calloc, from Benjamin BaierTed Unangst
2014-05-29use calloc, from Benjamin BaierTed Unangst
2014-05-29Make it substantially easier to identify protocol version requirementsJoel Sing
by adding an enc_flags field to the ssl3_enc_method, specifying four flags that are used with this field and providing macros for evaluating these conditions. Currently the version requirements are identified by continually checking the version number and other criteria. This change also adds separate SSL3_ENC_METHOD data for TLS v1.1 and v1.2, since they have different enc_flags from TLS v1. Based on changes in OpenSSL head. No objection from miod@
2014-05-29When you have functions that perform specific functions, use them.Joel Sing
EVP_CIPHER_CTX_free() does a NULL check, then calls EVP_CIPHER_CTX_cleanup() and frees the memory. COMP_CTX_free() also had its own NULL check, so there is no point in duplicating that here. ok beck@
2014-05-29document control characters which are extensions;Jason McIntyre
2014-05-29flesh out STANDARDS;Jason McIntyre
2014-05-29fsck should use the same values in checking as newfs does in creatingKenneth R Westerback
a filesystem. fs_nspf and its derivitives like fs_spc are DEV_BSIZE values, not actual hardware disk sector values. Adjust initializations accordingly. Tweak header and man page comments to make the DEV_BSIZE'ness more obvious for future spelunkers. No-op for DEV_BSIZE (a.k.a. 512-byte) sector devices but should help checking filesystems on, e.g., 4k-byte sector devices. ok jmc@ on the man page tweaks.
2014-05-29Fix another two cases where the return value of ssl_replace_hash() isJoel Sing
unchecked. In the case of tls1_change_cipher_state(), it is fairly pointless to use ssl_replace_hash(), since it does not initialise the hash and there is special handling required in the DTLS write case. Instead, just inline the part of ssl_replace_hash() that is needed and only ssl_clear_hash_ctx() the write hash in the non-DTLS case. Also add a detailed comment explaining why there needs to be specialised handling for DTLS write context and where the contexts are actually freed. ok miod@
2014-05-29no more gcc2.Daniel Dickman
ok miod@
2014-05-29Add missing NULL checks for calls to ssl_replace_hash(). This functionJoel Sing
calls EVP_MD_CTX_create(), which will return NULL if it fails to allocate memory. ok miod@
2014-05-29Read MAXPHYS bytes at a time in the hibernate image read, instead ofMike Larkin
PAGE_SIZE bytes. Completes the MAXPHYS optimizations in the read path. with input from guenther@ who suggested a version that was a little easier to understand. Tested on i386 and amd64.
2014-05-29zap double word;Jason McIntyre
2014-05-29Use .Er for errnosPhilip Guenther
2014-05-29GrammarPhilip Guenther
2014-05-29for -a and -g, do not say "as per posix": it adds no value to the user, andJason McIntyre
STANDARDS already notes these flags are compliant; it also stops us looking redundant referring to older posix revs; for -g, also note that output can safely be used by the shell; while here, zap some unneeded Fl i missed in previous;
2014-05-29some basic formatting fixes;Jason McIntyre
2014-05-29Update to match recent changesPhilip Guenther
2014-05-29We now use arc4random() so PERL_RANDOM_DEVICE is no longer needed.Philip Guenther
ok afresh@
generated by cgit v1.2.3 (git 2.25.1) at 2025-01-19 07:35:32 +0000