summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-05-21${rcexec} -> rc_execAntoine Jacoutot
2022-05-21Use 'at' for ASN1_TEMPLATE variable names rather than 'tt'.Joel Sing
Also use array indexes for it->templates, rather than trying to be extra clever in for loops (suggested by tb@ during a review). No functional change. ok tb@
2022-05-21Remove _ex_ from all of the internal function names.Joel Sing
It no longer makes sense to have "extended" versions of functions internally. No functional change. ok tb@
2022-05-21Replace the $rcexec variable by an rc_exec function.Antoine Jacoutot
It is much cleaner to the eyes and makes more sense from a functionnal point of view. This will allow to extend rc_exec with other functionnalities (like upcoming rc_startdir). Bonus point: daemon_logger will now work with manually crafted rc_start functions. This will require a mechanical change from ${rcexec} to rc_exec in rc.d scripts. ports will be fixed right after this commit but we will keep compatibility to give a chance to people to fix their custom scripts. positive tests from a few ok robert@
2022-05-21No need for true(1).Antoine Jacoutot
2022-05-21repair a few more backwards compares that create headachesTheo de Raadt
ok millert
2022-05-21system(3) should ignore SIGINT and SIGQUIT until the shell exits.Todd C. Miller
This got broken when system.c was converted from signal(3) to sigaction(2). Also add SIGINT and SIGQUIT to the set of blocked signals and unblock them in the parent after the signal handlers are installed. Based on a diff from Leon Fischer. OK deraadt@
2022-05-20vmm: remove spinout paranoiaDave Voutila
Move all the spinout counters for ipis (enable/disable vmm, remote vmcs clear) behind MP_LOCKDEBUG. All three areas (vmm_start, vmm_stop, vmx_remote_vmclear) migrate to infinite busy waits. tested by and ok mlarkin@
2022-05-20vmm: load the vmcs before reading vcpu registersDave Voutila
The vmm(4) ioctl for reading a vcpu's registers didn't flush and load the vmcs before issuing vmread instructions. This adds a flag to vcpu_readregs_vmx to signal if the vmcs needs to be synchronized before attempting the reads. (This is the same approach used for vcpu_writeregs_vmx function.) This fixes `vmctl send` on Intel hosts using vmd(8). While here, I noticed the vcpu_writeregs_vmx function doesn't properly set the vmcs state variable to VMCS_CLEARED after running a vmclear instruction. This can cause errors on vm re-entry. ok mlarkin@
2022-05-20use correct logging or error callsDave Voutila
ftruncate sets errno, so use fatal() and not fatalx(). Checking for under-reads of read(2) isn't going to set errno so use errx(). ok abieber@
2022-05-20as promised, extend the precaching using quirks stems extension.Marc Espie
(as it happens, some py-sip thingy got the treatment so I could test that the code does something) !
2022-05-20Add expected failures for octeon and riscv64.mbuhl
2022-05-20Re-classify the roff(7) \r (reverse line feed) escape sequenceIngo Schwarze
from "ignore" to "unsupported" because when an input file uses it, mandoc(1) is likely to significantly misformat the output, usually showing parts of the output in a different order than the author intended.
2022-05-20Test the handling of some additional one-character escape sequencesIngo Schwarze
that take no argument and are ignored: \% \& \^ \a \d \t \u \{ \| \} No change to parsing or formatting needed.
2022-05-20fold some of the useful "obsolete" information into the main textMarc Espie
2022-05-20Add RFC 7318Job Snijders
2022-05-20New ldapsearch does not support -h and -p for host and port, butAlexander Bluhm
accepts -H ldapuri. Use startup and cleanup framework. Pidfile does not work anymore, use pkill ldapd. Delete deactivated and failing cpan test.
2022-05-20Drop *out == NULL check in ASN1_STRING_to_UTF8()Theo Buehler
Unfortunately, several things in the ecosystem depend on the existing API behavior of being able to pass in an uninitialized pointer on the stack: haproxy, grpc, mongo-tools and others show up on the first two pages of Debian codesearch. ok jsing
2022-05-20Don't pass uninitialized pointer to ASN1_STRING_to_UTF8()Theo Buehler
Exposed by recent rewrite of ASN1_STRING_to_UTF8(). Found via grep after fixing CID 352831. ok jsing
2022-05-20Don't pass uninitialized pointer to ASN1_STRING_to_UTF8()Theo Buehler
Exposed by recent rewrite of ASN1_STRING_to_UTF8(). CID 352831 ok jsing
2022-05-20Rename hid_none to hid_all as it represents all possible hid kinds byAnton Lindqvist
now.
2022-05-20uhid_maxrepid() is currently not able to observe all report IDs as itAnton Lindqvist
passes hid_none as the wanted hid kind to hid_start_parse(). This becomes a problem for descriptors with multiple report IDs per collection. Therefore change the semantics of the hid_none kind to let it represents all possible kinds. Gets rid of "uhidev_intr: bad repid" console spam as reported by sthen@ on bugs@. Have been in snaps for a week.
2022-05-19Reorder functions within file.Joel Sing
Order functions by use, moving public API to the bottom and utility functions to the top. This makes the code more logical/readable, plus we can remove all except one of the static function prototypes. No functional change.
2022-05-19Rewrite the asn1_template_*() functions with CBS.Joel Sing
Rewrite the asn1_template_*() functions with CBS, readable variable names and free then alloc. This was the last caller of asn1_check_eoc() and asn1_check_tag(), hence remove them and rename the _cbs suffixed versions in their place. ok tb@
2022-05-19following the fixed parsing direction of roff_expand() in roff.c rev. 1.260,Ingo Schwarze
some diagnostics now appear in a more reasonable order, too
2022-05-19Adjust a column number in an error messageIngo Schwarze
after the roff_expand() reorganization in roff.c rev. 1.260. The new parsing direction has two effects: 1. Correct output when a line contains more than one expanding escape sequence that has a side effect. 2. Column numbers in diagnostic messages now report the changed column numbers after any expansions left of them have taken place; in the past, column numbers refered to the original input line. Arguably, item 2 was a bit better in its old state, but slightly less helpful diagnostics are a small price to pay for correct output. Besides, when the expansion of user-defined strings or macros is involved, in many cases, mandoc(1) is already unable to report meaningful line and column numbers, so item 2 is not a noteworthy regression. The effort and code complication for fixing that would probably be excessive, in particular since well-written manual pages are not supposed to use such features in the first place.
2022-05-19fix a wrong column number that got fixed as a side effectIngo Schwarze
of the roff_expand() reorganization in roff.c rev. 1.260
2022-05-19remove a bogus warning that went away as a side effectIngo Schwarze
of the roff_expand() reorganization in roff.c rev. 1.260
2022-05-19Make roff_expand() parse left-to-right rather than right-to-left.Ingo Schwarze
Some escape sequences have side effects on global state, implying that the order of evaluation matters. For example, this fixes the long-standing bug that "\n+x\n+x\n+x" after ".nr x 0 1" used to print "321"; now it correctly prints "123". Right-to-left parsing was convenient because it implicitly handled nested escape sequences. With correct left-to-right parsing, nesting now requires an explicit implementation, here solved as follows: 1. Handle nested expanding escape sequences iteratively. When finding one, expand it, then retry parsing the enclosing escape sequence from the beginning, which will ultimately succeed as soon as it no longer contains any nested expanding escape sequences. 2. Handle nested non-expanding escape sequences recursively. When finding one, the escape sequence parser calls itself to find the end of the inner sequence, then continues parsing the outer sequence after that point. This requires the mandoc_escape() function to operate in two different modes. The roff(7) parser uses it in a mode where it generates diagnostics and may return an expansion request instead of a parse result. All other callers, in particular the formatters, use it in a simpler mode that never generates diagnostics and always returns a definite parsing result, but that requires all expanding escape sequences to already have been expanded earlier. The bulk of the code is the same for both modes. Since this required a major rewrite of the function anyway, move it into its own new file roff_escape.c and out of the file mandoc.c, which was misnamed in the first place and lacks a clear focus. As a side benefit, this also fixes a number of assertion failures that tb@ found with afl(1), for example "\n\\\\*0", "\v\-\\*0", and "\w\-\\\\\$0*0". As another side benefit, it also resolves some code duplication between mandoc_escape() and roff_expand() and centralizes all handling of escape sequences (except for expansion) in roff_escape.c, hopefully easing maintenance and feature improvements in the future. While here, also move end-of-input handling out of the complicated function roff_expand() and into the simpler function roff_parse_comment(), making the logic easier to understand. Since this is a major reorganization of a central component of mandoc(1), stability of the program might slightly suffer for a few weeks, but i believe that's not a problem at this point of the release cycle. The new code already satisfies the regression suite, but more tweaking and regression testing to further improve the handling of various escape sequences will likely follow in the near future.
2022-05-19improve a comment explaining a particularly nasty hack; no code changeIngo Schwarze
2022-05-19Remove unused macro (log_debuginfo)Claudio Jeker
2022-05-19Now MULTIPROCESSOR kernel boots with CPU modules installed inKenji Aoyama
arbitrary slots. Plamen Mihaylov's LUNA-88K2 originally has 2 CPU modules in slot #0 and #2, but MULTIPROCESSOR kernel panics because they are not placed in contiguous slots. This diff fixes it. Original diff from miod@, tested by Plamen Mihaylov and me.
2022-05-19document what this file stands forMarc Espie
2022-05-19Document that imsg_add(3) frees its msg argument on failure.Stefan Sperling
ok op@ claudio@
2022-05-19Adjust or remove some stale commentsTheo Buehler
2022-05-19Add missing space between No macro and "authority".Theo Buehler
2022-05-19Deal with STACK_OF divergence between LibreSSL and OpenSSLTheo Buehler
2022-05-19Rewrite mft.c and roa.c with ASN.1 templatesTheo Buehler
The ASN.1 templates are a rather direct translation of the ASN.1 in the relevant RFCs and they allow deserializing the Manifest and ROA eContent in a single step instead of numerous opaque d2i_ASN1_SEQUENCE_ANY() calls. Once the eContent is deserialized, we can walk the structs, validate it as before and populate the internal data structures. Positive feedback job ok claudio
2022-05-19Not so recent evolution of the PowerPC and POWER architectures have definedMiod Vallat
exception addresses past EXC_LAST, making its definition wrong. Replace it with EXC_END, which points to the end of hardware exception addresses, and adjust logic accordingly. ok kettenis@
2022-05-19Revert "drm/amd/pm: keep the BACO feature enabled for suspend"Jonathan Gray
From Alex Deucher 0fad10b263a33492107d62caa460d5e4c717ce29 in linux 5.15.y/5.15.41 a56f445f807b0276fc0660c330bf93a9ea78e8ea in mainline linux
2022-05-19Force maximum payload size to 128 bytes for AR816X/AR817x as it triggersKevin Lo
dma write error rendering the network unusable. Bug reported and patch tested by Scott C. MacCallum.
2022-05-18document what PLIST_REPOSITORY does a bit betterMarc Espie
2022-05-18Remove #ifdef DDB specific includes, added in 1.968 but related code bitsMiod Vallat
removed in 1.970. ok bluhm@
2022-05-17Refactor asn1_d2i_ex_primitive()Joel Sing
Split the object content handling off into asn1_d2i_ex_primitive_content(), move the handling ov V_ASN1_ANY into asn1_d2i_ex_any() and move the MSTRING handling into asn1_d2i_ex_mstring(). This way we parse the header once (rather than twice for ANY and MSTRING), then process the content, while also avoiding complex special cases in a single code path. ok tb@
2022-05-17document /etc/login.conf.d/Jason McIntyre
help robert ajacoutot ok ajacoutot
2022-05-17ditch most of the obsolete stuffMarc Espie
there are still a few odds and ends which should make their way to the rest of the manpage eventually (or to the faq), useful information that's not immediately available elsewhere
2022-05-17Move towards OpenIKED 7.1Tobias Heider
2022-05-17Refactor ASN.1 template functions before rewriting.Joel Sing
Change asn1_template_ex_d2i() so that we short circuit in the no explicit tagging case. Split out the SET OF/SEQUENCE OF handling from asn1_template_noexp_d2i() into a asn1_template_stack_of_d2i() function and simplify the remaining code. ok tb@
2022-05-17Use a higher match priority such that mvclock(4) wins from syscon(4).Mark Kettenis
ok patrick@, dtucker@
2022-05-17Expose asn1_abs_set_unused_bits() in asn1_locl.hTheo Buehler
Should have been part of a previous commit. ok jsing