summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-07make dpb able to heed PERMIT_PACKAGE as wellMarc Espie
2019-11-07syncStuart Henderson
2019-11-07Stop installing the "leap-second" zoneinfo files in share/zoneinfo/rightStuart Henderson
(and the second copy of the "normal" files in share/zoneinfo/posix). The way these files are supposed to work is that you set the system clock to the time with leap-seconds included (UTC+leap, or TAI-10) and copy the entire "right" set of files to the main zoneinfo directory (upstream provides them as parallel directories to encourage this). And everyone else sets the system clock to UTC and uses the "posix" files. https://data.iana.org/time-zones/theory.html#leapsec We don't have much support for a non-UTC system clock, and these files have been seen to cause some confusion. kettenis@ says "Software that really cares probably has its own leap- second table and will actually rely on the POSIX definition of time_t to convert times into human readable form." ok deraadt naddy millert
2019-11-07zap CDROM_ONLYMarc Espie
document built-packages.log
2019-11-07db_addr_t -> vaddr_tMartin Pieuchot
2019-11-07Substitute boolean_t/TRUE/FALSE by int/1/0.Martin Pieuchot
2019-11-07syncTheo de Raadt
2019-11-07Reenable "val-log-level: 2", so that when sites have misconfiguredStuart Henderson
dnssec the sysadmin has some idea what's going on in logs, and "aggressive-nsec: yes", if we're using dnssec anyway we might as well get the benefits. These were both enabled last time dnssec was enabled in this sample unbound.conf. ok florian@
2019-11-07when asking the ports tree, we fork a child.Marc Espie
instead of ditching stderr entirely, keep it in a temp file, and if the child exits with an error, we got something to display. (note that returning and undef'd plist is enough of an error, just we had no clue what went wrong previously) aja@ ran into this a few weeks ago.
2019-11-07style nitMarc Espie
2019-11-07adjfreq(2): fix atomic swapcheloha
I broke adjfreq(2)'s atomic swap in kern_time.c,v1.112. By using the "f" variable to store both the new and old frequency adjustments, the new adjustment gets clobbered by the old adjustment if the caller asked for a swap. ok visa@ mpi@
2019-11-07Convert db_addr_t -> vaddr_t but leave the typedef for now.Martin Pieuchot
2019-11-07db_addr_t -> vaddr_t, missed in previous.Martin Pieuchot
ok deraadt@
2019-11-07Don't stop parsing functions when variables are declared before arguments.Martin Pieuchot
Fix argument types of functions containing a static variable when compiled with clang(1).
2019-11-07Do a better job at guessing the name of localy defined static variables.Martin Pieuchot
Handle the "varname.id" schema used by gcc(1) and "funcname.varname" used by clang(1). Fix a shadowing issue with clang(1).
2019-11-07Stop remembering the type of local variables.Martin Pieuchot
Fix a shadowing issue reported by procter@.
2019-11-07Do propper kernel input validation for in_control() ioctl(2)Alexander Bluhm
SIOCGIFADDR, SIOCGIFNETMASK, SIOCGIFDSTADDR, SIOCGIFBRDADDR, SIOCSIFADDR, SIOCSIFNETMASK, SIOCSIFDSTADDR, and SIOCSIFBRDADDR. Name in_ioctl_set_ifaddr() consistently. Use in_sa2sin() to validate inet address. Combine if_addrlist loops and add comment. Although netmask is not a inet address, length must be valid. Reported-by: syzbot+5fc6da002fc4e8d994be@syzkaller.appspotmail.com OK visa@
2019-11-07Substitute boolean_t/TRUE/FALSE by int/1/0.Martin Pieuchot
2019-11-07db_addr_t -> vaddr_tMartin Pieuchot
ok deraadt@
2019-11-07Showing kernel WEP keys to userland has been disabled in genericAlexander Bluhm
ieee80211 ioctl(2) implementation. Do the same for the driver specific code of ac(4) and wi(4) wireless network devices. OK mpi@
2019-11-07Enable DNSSEC validation in unbound by defaultjob
OK deraadt@ otto@
2019-11-07Only root is allowed to set the WEP key. Add an suser() check toAlexander Bluhm
enforce this for the an(4) wireless network device. found by Ilja Van Sprundel; OK dlg@ deraadt@ mpi@
2019-11-07remove the detach and linkstate hooks when the parent is going away.David Gwynne
i think this is a fix for a real bug. pfsync leaked the hooks it had on a parent^Wsyncdev when the parent went away. now there's KASSERTs to make sure all hooks are removed before an interface goes away, the leak caused the KASSERTs to fire and made the bug obvious. found by hrvoje popovski
2019-11-07Simplify by getting rid of the unecessary 'depend' rule.Martin Pieuchot
ok patrick@
2019-11-07Avoid NULL dereference in arpinvalidate() and nd6_invalidate() byKenneth R Westerback
making RTM_INVALIDATE code path perform same check as RTM_DELETE does. ok mpi@
2019-11-07ANSIfy & substitute boolean_t/TRUE/FALSE by int/1/0.Martin Pieuchot
ok jasper@, deraadt@
2019-11-07Substitute boolean_t/TRUE/FALSE by int/1/0.Martin Pieuchot
ok dlg@, jasper@
2019-11-07FALSE -> 0, missed in previous.Martin Pieuchot
Spotted by deraadt@
2019-11-07 Remove half way implemented address and default route proposals.Florian Obser
This never worked out and is getting in the way of DNS proposals which are coming next. No (intended) functional change. Input & OK tohe
2019-11-07Document the new home of the control socket; ok florian@Otto Moerbeek
2019-11-07Fill in missing man page bits for U2F security key support:Christian Weisgerber
Mention the new key types, the ~/.ssh/id_ecdsa_sk file, ssh's SecurityKeyProvider keyword, the SSH_SK_PROVIDER environment variable, and ssh-keygen's new -w and -x options. Copy the ssh-sk-helper man page from ssh-pkcs11-helper with minimal substitutions. ok djm@
2019-11-07move the port destructor calls in clone destroy back out of NET_LOCK.David Gwynne
it's no longer necessary to hold NET_LOCK to call interface hook adds or dels now, but it is necessary not to hold NET_LOCK when calling some barrier functions. found by hrvoje popovski
2019-11-07serialise hook adds and dels with a mutex instead of an implicit NET_LOCK.David Gwynne
i had NET_ASSERT_LOCKED() in the hook add and remove operations, because that's what's held when the hooks are run. some callers do not hold the NET_LOCK when calling them though, eg, bridge(4). aggr and tpmr used to not hold NET_LOCK while being destroyed, which also caused the asserts to fire, so i moved the port destroys inside NET_LOCK, but now I have deadlocks with some barrier calls. the hooks having their own lock means callers don't have to hold NET_LOCK and the list will stay sane. the code that runs the hooks gives up the mutex when calling the hook, but keeps track of where it's up to bey putting a cursor in the list. there's a single global mutex for all the interface linkstate and detach hooks, but this stuff isn't a hot path by any stretch of the imagination. based on (a lot of) testing by hrvoje popovski. thank you.
2019-11-07turn the linkstate hooks into a task list, like the detach hooks.David Gwynne
this is largely mechanical, except for carp. this moves the addition of the carp link state hook after we're committed to using the new interface as a carpdev. because the add can't fail, we avoid a complicated unwind dance. also, this tweaks the carp linkstate hook so it only updates the relevant carp interface, not all of the carpdevs on the parent. hrvoje popovski has tested an early version of this diff and it's generally ok, but there's some splasserts that this diff fires that i'll fix in an upcoming diff. ok claudio@
2019-11-07Add -F flag to send-keys to expand formats in search-backward andNicholas Marriott
forward copy mode commands, this makes it easier to use the cursor_word and cursor_line formats. From Anindya Mukherjee in GitHub issue 1964.
2019-11-06Give acme-client a chance to work on IPv6 only hosts by using theFlorian Obser
AI_ADDRCONFIG flag for getaddrinfo to only return addresses for a configured address family. Implementing a loop over all IPs is left as an exercise to the reader. Reported some time ago by kasimov.an AT gmail on bugs@, thanks! oh boy deraadt@ OK benno@
2019-11-06Make udl(4) and uts(4) compile again in debug mode by fixing IOCGROUPMarcus Glocker
and IOCPARM_LEN macros types.
2019-11-06Use atomic operations consistently while writing to kubsan_slot.anton
Otherwise, reports might go by unnoticed. Prodded by and ok visa@
2019-11-06Perform contraint validation against 9.9.9.9 and 2620:fe::fe also (whichTheo de Raadt
avoids DNS lookups entirely, but yes this https is correctly validated) long discussions with otto, florian, and the quad9 crew.
2019-11-06useless debug outputFlorian Obser
2019-11-06Move control socket to /dev like slaacd(8) is doing to be able toFlorian Obser
start unwind earlier, before /var is mounted. discussed with deraadt
2019-11-06we have emergency entropy injection code in rc, for if the bootblocks andTheo de Raadt
other methods failed to inject/churn the rng enough. Move it up far earlier. ok naddy sthen kettenis
2019-11-06Pull break into ifdef; noticed by bluhm who also OK'ed the previousFlorian Obser
commit.
2019-11-06Make iwn(4) flush remaining frames on the Tx aggregation queue whenStefan Sperling
Tx aggregation is stopped. Fixes a bug where outstanding frames on the aggregation queue interfere with roaming to another AP. net80211 will only roam once all outstanding frames destined for the old AP have been sent, i.e. once that AP node's Tx refcount goes to 0. Any outstanding frames sitting in the Tx aggregation queue, waiting to be ACKed, will keep this refcount above zero. To make roaming work reliably in combination with Tx aggregation, the driver must ensure that ieee80211_release_node() gets called for each frame on the queue when Tx aggregation is stopped. Problem observed by tobhe@ Fix tested + ok tobhe@ jca@
2019-11-06Fix RTA_DNS checks:Florian Obser
Do not overwrite the address family, we need to know if this is IPv4 or IPv6 to parse the message. Nameservers are IP addresses, not NUL-terminated strings. Check that the length is a multiple of the length of an IP address. OK krw
2019-11-06Rename "asr" to "stub" in user visible parts.Florian Obser
More people know what a "stub" resolver is then asr. Pointed out by & discussed with deraadt Input & OK otto
2019-11-06Raise net80211's "beacon miss" threshold to avoid frequent re-connectsStefan Sperling
to APs that are relatively far away and suffer some packet loss. The former threshold was 7 beacons (about 700 ms). This raises the threshold to 30 beacons (about 3 seconds). Should still be good enough for detecting APs that have disappeared, and makes wifi networks provided by the University of Bucharest more reliable in the p2k19 hackroom. While here, make 'ifconfig iwm0/iwn0 debug' print an obvious message when we believe that the AP has disappeared. Problem reported and fix tested by landry@ / pirofti@ ok mpi@ sthen@
2019-11-06Allow the singular constraint clause to list multiple addresses;Otto Moerbeek
ok deraadt@
2019-11-06mention in tcpdump(8) description of -i that one can use either a networkStuart Henderson
or a USB device. ok mpi
2019-11-06No need to write resolv.conf after deciding to get a new lease,Kenneth R Westerback
or after deciding to terminate or when AUTOCONF4 is not set.