summaryrefslogtreecommitdiff
path: root/bin/ksh
AgeCommit message (Collapse)Author
2018-01-16Introduce internal_warningf() and mark internal_errorf() as noreturnJeremie Courreges-Anglas
This helps tools like scan-build, and follows the example of warningf() and errorf(). ok anton@
2018-01-16Stop constructing the ulimit optstring passed to ksh_getopt() at runtime sinceanton
it's rarely subject to change. While here, unifdef RLIMIT_VMEM. ok jca@
2018-01-16One minor scan-build warningJeremie Courreges-Anglas
emacs.c:1041:2: warning: Value stored to 'cp' is never read
2018-01-15Don't try to open HISTFILE if the variable is unset.Jeremie Courreges-Anglas
str_val returns null, not NULL, if the variable isn't set. The erroneous check means that we later tried to open(""). ok millert@ tb@ anton@ benno@
2018-01-15Stop pretending we support building ksh without EDIT/HISTORY supportJeremie Courreges-Anglas
ok anton@
2018-01-14unifdef BRACE_EXPAND; ok jca@anton
2018-01-13remove unused parameter from the static function print_expansions();Ingo Schwarze
patch from Michael W. Bombardieri <mb at ii dot net>; OK tb@
2018-01-12Some more tweaks to NOTESJeremie Courreges-Anglas
- it's safe to assume that there's no plan to write "an `agent' to execute unreadable/setuid/setgid shell scripts" - the BUG-REPORTS file has been removed - update the entry for FPATH, ksh93 also documents the described behavior - kill entry about octal and hex notation in arithmetic expressions (supported) - typos Feedback from Klemens Nanni
2018-01-08update comments that were left behind in the recent unifdef JOB commitSebastian Benoit
from Klemens Nanni, thanks.
2018-01-08Drop two outdated entriesJeremie Courreges-Anglas
Namely POSIX character classes and tilde expansion within parameter substitution. While here, kill a useless line and fix a typo. From Klemens Nanni
2018-01-08Remove unused "args" param from kb_add(), it is always NULL.Todd C. Miller
OK anton@ jca@
2018-01-08Kill entries that are obviously outdated/out of scopeJeremie Courreges-Anglas
Pointed out by Klemens Nanni who had ~ the same diff
2018-01-07Add proper bounds checking to kb_add(). OK anton@Todd C. Miller
2018-01-06Bring back the sign compare changes, this time with a fix from otto@Todd C. Miller
that fixes the issues seen on hppa. OK deraadt@ otto@
2018-01-05unifdef JOBS supportJeremie Courreges-Anglas
Prompted by a mail from Klemens Nanni, who also had the same diff. ok deraadt@ millert@
2018-01-05Typos in comments: 'it' -> 'if' and 'noityf' -> 'notify'.Theo Buehler
from Klemens Nanni
2018-01-04Back out sign compare changes that appear to cause problems on hppa.Todd C. Miller
Requested by deraadt@
2018-01-01Add WARNINGS=yes to ksh and fix the resulting sign compare warnings.Todd C. Miller
OK tb@
2017-12-30backslash also escapes newlines when quoted;Jason McIntyre
from kshe
2017-12-27Add -Wshadow to Makefile and fix the resulting warnings. Many ofTodd C. Miller
the warnings are due to the use of globals with generic names, specifically "options" and "path". I've renamed "options" to "sh_options" since it holds the shell options and "path" to "search_path". OK jca@ tb@
2017-12-26The hack for /dev/fd support on systems without it was removed aTodd C. Miller
long time ago. Update the comments and replace test_stat() calls with stat() since test_stat() now just calls stat() directly. Also rename the "mode" parameter to "amode" in test_eaccess() to match access(2) and make it clear that this is the access mode and not the file mode. OK jca@
2017-12-18Get rid of a todo by stop declaring variable texec as static and instead zeroinganton
it out prior to continuing down the recursive call chain. Initial diff from Michael W. Bombardieri, later tweaked; ok tb@
2017-12-18Add another pair of home/end key bindings; from Lari Rasku.anton
ok jca@
2017-12-15oops - previous should have been a list item;Jason McIntyre
2017-12-12Document change in the default shell prompts.Theo Buehler
Discussed with and ok jmc
2017-12-12Include hostname in shell prompts by defaultTheo Buehler
With tmux, ssh and vmd, we tend to open shells on many different hosts simultaneously and the default prompts '$ ' and '# ' for {,k}sh as well as '% ' and '# ' for csh become dangerous: it's very easy to issue a command on the wrong host. This can easily be avoided by displaying the hostname in the prompt. Everything beyond "hostname{$,#,%} " is going to be a matter of taste, so we left it at that. If you use an FQDN, only the first part (the output of 'hostname -s') will be printed. requested by and ok deraadt; mostly positive feedback many ok anton, brynet, bcallah and others
2017-12-07Drop the unused second argument from set_prompt(). It used to be used forTheo Buehler
early special casing of ! and !! in the PS1 expansion. This was removed from set_prompt() as part of the implementaion of the character count toggles \[ and \] back in 2004. ok jca
2017-11-27Follow emacs mode and remove the interactive "version" function.Theo Buehler
ok jca, anton (who both had the same diff) and deraadt
2017-11-26Remove the "version" interactive function in emacs mode.Jeremie Courreges-Anglas
Not bound by default and not very useful. ok schwarze@ anton@
2017-11-22Fix some incorrectness related to Emacs editing mode in ksh:anton
- Keep the order of bindings in sync between the manual and implementation - Fix wrongly documented bindings in the manual - Break out commands without a default binding in the manual ok jmc@ tb@
2017-11-21Initialize *histbase to NULL to fix a bus error in emacs editing modeTheo Buehler
found by anton. To reproduce, run "env EDITOR=emacs MALLOC_OPTIONS=J ksh" then press "^[_". ok anton, jca
2017-11-02Switch calloc(3) back to malloc(3). The call to calloc was introducedTheo Buehler
by the plaintext history diff, but the code that may have depended on this was since removed from history.c. None of the code introduced between the plaintext history commit and now depends on calloc(3). This way we can again use malloc.conf(5)'s J option to recognize use of uninitialized memory. ok jca
2017-10-23Kill needless rewind(3) call in hist_init()Jeremie Courreges-Anglas
We may have read two bytes from the file, but history_load() needs to call rewind(3) anyway. ok benno@
2017-10-23Skip (and warn about) overlong history lines.Jeremie Courreges-Anglas
With much input from Ori Bernstein and anton@; ok anton@ (and benno@ on a previous version).
2017-10-19Delete the deprecated emacs-usemeta option.Jeremie Courreges-Anglas
ok tb@ anton@
2017-10-18The return value of this function isn't used.Jeremie Courreges-Anglas
ok anton@ tb@
2017-09-07Keep histptr inside of the allocated history arrayJeremie Courreges-Anglas
histptr == history -1 means that the history is empty, but the behavior is then undefined. Allocate an extra array entry to work around this. Input & ok tb@
2017-09-03Use PATH_MAX instead of a local defineJeremie Courreges-Anglas
okk deraadt@ millert@ anton@
2017-09-02whitespace commit from BCTheo de Raadt
2017-08-31ignoredups implementation quirkJeremie Courreges-Anglas
Reminded by tb@
2017-08-30Guard FEMACSUSEMETA uses behind #ifdef EMACSJeremie Courreges-Anglas
2017-08-30Implement HISTCONTROL ignoredups & ignorespace featuresJeremie Courreges-Anglas
ignoredups: don't save the current line if it is identical to the last history line. ignorespace: don't save the current line if it starts with a space ok anton@ millert@
2017-08-30Stop exposing the emacs-usemeta option, and warn when trying to set it.Jeremie Courreges-Anglas
Unused since 2012, to be removed after 6.2. Input from anton@, ok anton@ millert@
2017-08-30Drop needless commentJeremie Courreges-Anglas
ok anton@ millert@
2017-08-30No need for NULL checks before afree()Jeremie Courreges-Anglas
2017-08-29Kill a useless setlocale() queryJeremie Courreges-Anglas
Pointless since the removal of the setlocale() call in main.c:rev1.82, the emacs-usemeta flag isn't used in the code since 2012. This kills a chunk of code in a statically linked ksh. ok millert@
2017-08-28Don't bother setting freed history lines to NULL.Jeremie Courreges-Anglas
Dead code that could send the wrong hint to an unsuspicious reader. The code should walk use 'history' & 'histptr' to walk the array. ok millert@, "go for it" tb@
2017-08-28Put history_write() in line with other functions that walk historyJeremie Courreges-Anglas
One method is enough: only access history lines between 'history' and 'histptr'. Pointers outside these bounds might be invalid. ok millert@, "go for it" tb@
2017-08-27Free history entries when resizing/reloadingJeremie Courreges-Anglas
Cluebat & ok tb@
2017-08-27Remove unused copy_non_glob() in ksh.Nayden Markatchev
Report and diff by David Crosby <dave@dafyddcrosby.com> OK otto@