summaryrefslogtreecommitdiff
path: root/bin
AgeCommit message (Collapse)Author
2018-05-30point readers to the correct place instead of having themSebastian Benoit
jump around. suggested and ok jmc@, ok jcm@
2018-05-24Fail earlier if we don't have a current filename. This simlifies theMartijn van Duren
code and removes a few BACKWARDS flags. OK otto@
2018-05-18remove the alias type='whence -v' and replace it withSebastian Benoit
a buildin command, that just calls into c_whence(). This makes type look like the buildin in other shells and makes things like system("'type' 'git'"); work. With lots of suggestions and feedback from anton@, kn@ and jca@. ok kn@ jca@
2018-04-26Make ed's 'l' command end lines with a '$' and make sure that literalMartijn van Duren
'$' characters are escaped, so that we are POSIX compliant. The omission of trailing '$' was originally hidden behind a BACKWARDS flag. This flag was most likely introduced to be compatible with 4.4BSD. Thanks to naddy@ for pointing me to the 4.4BSD ed implementation. I tried to trace the origin and enabling of the BACKWARDS flag, since both FreeBSD and NetBSD have the flag, but only FreeBSD doesn't have it enabled. Both projects had an alm@ working on ed during 1993-1995 during which he added this flag to both projects and only enabled it on NetBSD, but I wasn't able to reach him on any known address. Thanks to Ed Schouten (ed@freebsd), and Michael W. Lucas of the ed Mastery book for helping me trying to locate Andrew Moore. Problem originally prodded by garzon.lucero@gmail.com and later independently re-requested by n.reusse@hxgn.net. OK tb@, guenther@, and mwl@mwl.io
2018-04-25The time-setting codepath can use pledge "settime" which was added forTheo de Raadt
ntpd, but apparently date was never revisited. "wpath" is for wtmp logging. "rpath" for the case where -z argument isn't in the standard timezone dir. discussed with tb and guenther
2018-04-24Keep the time pipeline's stack in tactkn
Revision 1.28 (2008) fixed stack abuse by allocating a new one and effectively clearing it. This broke pipelines such as $ time for i in . ; do : ; done /bin/ksh: : is read only Prompted by tb, OK millert, tb, jca
2018-04-13Count $SECONDS with CLOCK_MONOTONIC.cheloha
Keeps $SECONDS advancing uniformly and independent of wall clock jumps. ok jca@
2018-04-09Support 64 bit integers on 32 bit architectures.Tobias Stoeckmann
No binary change on amd64 and there should be no differences on any other 64 bit architecture either (because long = int64_t). ok cheloha, tb
2018-04-07snprintf+writev -> dprintfcheloha
Much simpler. Dropping writev makes the output from summary() non-atomic, so output lines triggered by SIGINFO can intermingle with output lines triggered by SIGINT or atexit(3). This behavior is difficult to trigger, even deliberately. The buffer in dprintf is large enough so that lines produced by summary() are not garbled if this occurs, though, so this is unlikely to break any scripts. Discussed at length with deraadt@, who helpfully noted that "not all problems have perfect solutions." ok millert@
2018-04-02Support integers of arbitrary length.Tobias Stoeckmann
Previously it was possible to overflow integers while parsing. With this diff, we support any kind of POSIX-compatible integers for comparisons. with input by and ok schwarze, ok tb
2018-03-31Clarify that -P only *attempts* overwriting, which may not succeed;Ingo Schwarze
requested by deraadt@ after repeated questions on bugs@ and tech@, e.g. from Gregoire Jadi and Craig Skinner.
2018-03-31Fix spacing in brace command list grammar.anton
Initial diff by me, later improved by schwarze@; also ok jmc@
2018-03-31Fix overflows while handling 64 bit integers.Tobias Stoeckmann
Based on FreeBSD's expr and NetBSD's old regression test suite. with input by and ok schwarze
2018-03-16improve markup quality in the cases found by the new "--" style messageIngo Schwarze
2018-03-15Favor usage of __func__ in warning/error messages. Some of them referred to theanton
wrong function and fix the rest for consistency. Diff from Michael W. Bombardieri with some cosmetic cleanup applied. ok benno@ tb@
2018-02-26Make ed(1) warn about modifications if 'r'ead in an empty file andMartijn van Duren
trying to quit. Diff from Tim Chase OK tb@ and millert@
2018-02-13atoll -> strtonumcheloha
ok millert@ tb@
2018-02-06Clarify that the "bind" built-in command only affects Emacs editingIngo Schwarze
mode, to avoid potential confusion pointed out by andreas dot kahari at icm dot uu dot se on misc@. Patch minimally tweaked based on a comment from jmc@. OK anton@ jca@ jmc@ on the previous version without the tweak.
2018-02-05CKSUM_DIGEST_STRING_LENGTH bounding didn't include full range of size_tTheo de Raadt
and NUL ok millert krw tb
2018-02-04use sizeof, rather than the constant. on change in binary.Theo de Raadt
2018-02-04repair ugly indentsTheo de Raadt
2018-02-04Print strtonum(3)-style error messages on invalid numeric input.cheloha
More informative than the usage message. While here, no need to return EINVAL: just return 1 if we overflow. ok jca@ schwarze@
2018-02-02Extend range for seconds from 100 million to upper bound of time_t.cheloha
Makes us compliant with POSIX.1-2008, which requires that sleep(1) support up to 2147483647 seconds. Bounced off of tb@ and jca@. ok tb@ millert@ jca@
2018-01-20Remove code that has been disabled since 1999. From Michael W. Bombardieri whoanton
also took the time to provide an excellent explanation on why the code isn't useful on tech@. ok jca@
2018-01-16Introduce internal_warningf() and mark internal_errorf() as noreturnJeremie Courreges-Anglas
This helps tools like scan-build, and follows the example of warningf() and errorf(). ok anton@
2018-01-16Stop constructing the ulimit optstring passed to ksh_getopt() at runtime sinceanton
it's rarely subject to change. While here, unifdef RLIMIT_VMEM. ok jca@
2018-01-16One minor scan-build warningJeremie Courreges-Anglas
emacs.c:1041:2: warning: Value stored to 'cp' is never read
2018-01-15Don't try to open HISTFILE if the variable is unset.Jeremie Courreges-Anglas
str_val returns null, not NULL, if the variable isn't set. The erroneous check means that we later tried to open(""). ok millert@ tb@ anton@ benno@
2018-01-15Stop pretending we support building ksh without EDIT/HISTORY supportJeremie Courreges-Anglas
ok anton@
2018-01-14unifdef BRACE_EXPAND; ok jca@anton
2018-01-13remove unused parameter from the static function print_expansions();Ingo Schwarze
patch from Michael W. Bombardieri <mb at ii dot net>; OK tb@
2018-01-12Some more tweaks to NOTESJeremie Courreges-Anglas
- it's safe to assume that there's no plan to write "an `agent' to execute unreadable/setuid/setgid shell scripts" - the BUG-REPORTS file has been removed - update the entry for FPATH, ksh93 also documents the described behavior - kill entry about octal and hex notation in arithmetic expressions (supported) - typos Feedback from Klemens Nanni
2018-01-09Rename test file =.err to eq.err for simpler make file scripts.Alexander Bluhm
2018-01-08update comments that were left behind in the recent unifdef JOB commitSebastian Benoit
from Klemens Nanni, thanks.
2018-01-08Drop two outdated entriesJeremie Courreges-Anglas
Namely POSIX character classes and tilde expansion within parameter substitution. While here, kill a useless line and fix a typo. From Klemens Nanni
2018-01-08Remove unused "args" param from kb_add(), it is always NULL.Todd C. Miller
OK anton@ jca@
2018-01-08Kill entries that are obviously outdated/out of scopeJeremie Courreges-Anglas
Pointed out by Klemens Nanni who had ~ the same diff
2018-01-07Add proper bounds checking to kb_add(). OK anton@Todd C. Miller
2018-01-06Bring back the sign compare changes, this time with a fix from otto@Todd C. Miller
that fixes the issues seen on hppa. OK deraadt@ otto@
2018-01-05unifdef JOBS supportJeremie Courreges-Anglas
Prompted by a mail from Klemens Nanni, who also had the same diff. ok deraadt@ millert@
2018-01-05Typos in comments: 'it' -> 'if' and 'noityf' -> 'notify'.Theo Buehler
from Klemens Nanni
2018-01-04Back out sign compare changes that appear to cause problems on hppa.Todd C. Miller
Requested by deraadt@
2018-01-03Stop "dd if=/dev/zero of=/dev/null bs=1 count=2 skip=0x7fffffffffffffff"Ingo Schwarze
from erroring out with "dd: skip: Undefined error: 0", mostly for consistency and to avoid the unidiomatic, wrong looking code. Patch from Bulat Musin <mbulatka at yandex dot ru>. OK guenther@ millert@
2018-01-01Add WARNINGS=yes to ksh and fix the resulting sign compare warnings.Todd C. Miller
OK tb@
2017-12-30backslash also escapes newlines when quoted;Jason McIntyre
from kshe
2017-12-27Add -Wshadow to Makefile and fix the resulting warnings. Many ofTodd C. Miller
the warnings are due to the use of globals with generic names, specifically "options" and "path". I've renamed "options" to "sh_options" since it holds the shell options and "path" to "search_path". OK jca@ tb@
2017-12-26The hack for /dev/fd support on systems without it was removed aTodd C. Miller
long time ago. Update the comments and replace test_stat() calls with stat() since test_stat() now just calls stat() directly. Also rename the "mode" parameter to "amode" in test_eaccess() to match access(2) and make it clear that this is the access mode and not the file mode. OK jca@
2017-12-23As we only use the .tv_sec field, simplify gettimeofday(2) -> time(3).cheloha
While here, use err(3) instead of errx(3) if adjtime(2) fails. Discussed/tweaked with/by tb@ and jca@. ok tb@ jca@
2017-12-18Get rid of a todo by stop declaring variable texec as static and instead zeroinganton
it out prior to continuing down the recursive call chain. Initial diff from Michael W. Bombardieri, later tweaked; ok tb@
2017-12-18No need to declare variable name as static in dounsetenv(). Also, drop aanton
redundant call to free() since name is always freed upon return. From Michael W. Bombardieri, with some tweaks by myself.