| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Noticed by STeve Andre
|
|
|
|
|
|
|
|
a) Eliminate single invocation here document functions
not_going_to_install(), congrats() by putting the here
document at the point of invocation.
b) Make (deliberately) global variables consistantly upper case and
with no leading '_'. Many variables that could be local are still
creating globals.
c) Make all get_* functions names conform to a convention of
get_<global variable name>, where the <global_variable_name>
is the global variable set by the function, or whose new
value is returned by the function.
d) Change _IFS to IFDEVS to be consistant with CDDEVS and DKDEVS,
and initialize it at the same place.
e) Handle bare '+', '-' in same place other selections are parsed
rather than in a separate case statement.
f) eliminate '[ "$var" ] || var=value' constructs with ': ${var:=value}'
constructs.
g) Rename local_sets_dir -> SETSDIR.
h) Rework logic around ftp passwords to eliminate duplications
and ensure a new password is asked for each time.
i) Some minor cosmetic adjustments.
|
|
|
|
|
|
being found for install/upgrade.
|
|
sendmail.cf to /etc/mail.
ok deraadt@, millert@, todd@
|
|
a) Abstract selection list handling into a function
do_selection_list() rather than repeating the
code twice.
b) Eliminate function get_selection() and put limited
remaining functionality directly into only caller,
get_get_file_list().
c) Remove unused parameters in glob_selection() and
invocations of same.
d) Remove unused parameters from install_get_files_list()
invocations.
e) Remove unnecessary local parameter '_file_list' in
install_mounted_fs().
|
|
consolidation reduces calls to these functions to either 0
(display_failure_msg()) or 1.
Just put the here documents in place of the invocation.
|
|
backup their data and reinstall when the release gap is too big.
|
|
put dmesg.boot there rather than the non-normal location
/tmp/dmesg.boot.
|
|
a) The selection list does not display default sets already
transferred.
b) Saying 'done' does not seem to mysteriously skip the sets
erroneously shown as selected due to a).
This problem was found by miod@.
In the process
a) Use _setsdone only to record sets that have successfully been
extracted.
b) Don't loop on fetching files if a transfer fails. Just let the user
know, and let the normal logic offer them a chance to extract the
failed sets from the same or different source.
c) Eliminate some (newly) dead variables, especially the global
_osetsdone.
|
|
|
|
|
|
option to encrypt, by terminating option list with '--'. This
generated an error during install and left root with a blank password.
Mentioned a couple of months ago by Adrian Close, and
dhartmei@ prodded me again today.
|
|
|
|
|
|
|
|
|
|
|
|
1) Put knowledge of /tmp/fstab in munge_fstab rather
than redirect input on calls. Check in munge_fstab
whether /etc/fstab was successfully created, and exit
install/upgrade with appropriate error if not. This
error condition is therefore checked on install and upgrade.
2) Don't bother specifying value in exit statements - no one
is checking whether it is 1, 2, or 0.
3) Put status messages inside check_fs rather than around
invocation, and exit from check_fs if a fsck fails, rather
than checking return value and exiting.
4) With above changes, simplify munge_fs/check_fs/mount_fs logic in
upgrade.sh.
5) Various cosmetic cleanups.
|
|
|
|
|
|
|
|
|
|
on alpha@.
|
|
1) Centralize selection of install/upgrade media rather than ask
separately for mounted filesystem. Eliminate separate calls
to get_localdir in install.sh and upgrade.sh. In install.sh
this call occurred only if a diskless system was detected, which
millert@ agreed was a historical relic, i.e. what exactly would
a diskless workstation be installing to?
2) Check for the presence of any mounted filesystems at the expected
mount point (/mnt or /mnt2) and emit an error message if none found.
3) Add a '?' option to the pathname question so you can see what
filesystems are mounted at/below the expected mount point.
4) Rework logic in get_localdir to make flow more logical. e.g. only
do sane_install() check after the user says to install no more sets;
if sane_install() fails ask a slightly different question and make
the default 'y' to install more sets.
5) Rework install_sets() to simplify logic. Don't try to tailor
list of install media to system, just warn that some may not be
available and emit useful error messages if the user tries a
non-available source.
Some verbiage still needs work (amoung other things).
fgsch@ noticed problems with installing from mounted filesystems, forcing me
to finish these changes.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
1) It takes two parameters, the mount point and a default
directory.
2) It has one step escape ('abort') instead of asking user if they are
really sure an empty pathname is what they want. Empty entry with no
default value now just re-presents the prompt. More consistant with the
behaviour of other prompts.
3) Provide separate error messages for non-existant directory and a
directory with no sets.
Rework install_mounted_fs() (renamed from install_from_mounted_fs to
be consistant with install_disk, etc.) so that
1) It takes two parameters, the mount point and the default directory.
2) It calls get_localdir(), passing the parameters along.
Rework install_disk(), install_cdrom() and install_nfs() to eliminate
local queries for local dir and rely on get_local() via
install_mounted_fs() instead.
Make mount_a_disk() return 0 on success to make testing its return
value more obvious. Use this in install_disk() to make logic clearer
and eliminate the need for a return.
|
|
Mount NFS servers with -o ro the same as all other install
sets sources.
Check for /sbin/mount_nfs in install_nfs() rather before
the call in install_sets(). Makes install_sets() more
consistant in both code and reactions to failed attempts
to find sets.
|
|
ever adds an option with a name too similar to the name of the one
being manipulated.
Only softdep at the moment but some more option fiddling coming.
|
