| Age | Commit message (Collapse) | Author |
|---|
|
All board specific quirks inside the installer (and other bugs) relating to
root on softraid are fixed, so that install media with the new question
just works for plain as well as encrypted installs.
Tested on Pinebook Pro, Raspberry Pi 4b, SolidRun CEX7.
|
|
Various files are put onto a pi's ESP, assuming root disk means boot disk,
which is not true for root on softraid(4).
Wrap the code in a loop over chunks (if any) or the single disk as before,
just like installboot(8) does.
OK mbuhl
|
|
pine64 happens to be the first board "we ran on", as kettenis explains, and
this code tries to handle the situation of installing to the same disk the
installer booted from.
Similar boards like the Pinebook Pro don't get special treatment and work;
INSTALL.arm64 already explains how to flash required firmware onto disks or
install media -- Allwinner SoCs like the pine64 included.
Spotted through md_installboot() dd'ing blobs onto the root disk,
which does not fly with root on softraid and is in the way of arm64 getting
support for guided disk encryption.
Suggested by kettenis patrick
Feedback jsg patrick
OK patrick
|
|
|
|
"disk" can mean both "chunk" and "volume" and a future diff for better
softraid volumes handling will benefit from this distinction.
No functional change.
|
|
Set to split `hw.disknames' strings is neat, but functionn-wide means the
bsort() invocation honours it, i.e. it'll output newlines not spaces.
Break the one-liner into the same multi-line idom occuring elsewhere and
contain IFS in the subshell that needs it.
This was never visible due how the output of was consumed by the shell.
The only visual, but otherwise effectless bug due to this appeared with the
new disk encryption question double-quoting get_dkdevs() output, i.e.
multiple disks printed across multiple lines; this yields one, as inteded.
OK afresh1
|
|
'Default IPv4 route?' takes an IP or this word, not no IP at all.
All other questions already quote their 'none', 'done', etc. answers.
No behaviour change for autoinstall(8) files, questions end after the
qestion mark and potential answers/help in parentheses comes after that.
|
|
There since introduction, lucked out since it is the last case.
No functional change.
|
|
All other dd invocations in installer code, INSTALL.* instructions and
dd(1) EXAMPLES use the disk's "raw device".
|
|
`_disk' (and related variables) hold disk names as "sd0" so that all else
can be constructed from it.
Fix the only two offenders across distrib/ which put start the variable
with "/dev/"; no functional change.
|
|
Same as done for arm64 already
|
|
|
|
While MAKEDEV accepts multiple args, it complains loudly on repeated args.
It is silent when trying to create a single already existing device.
This is probably a bug in MAKEDEV.
|
|
Less duplicate code, easier to add new firmware.
OK afresh1
|
|
We must not discard all errors, just disable informational messages.
OK tb
|
|
No need to loop here, the script takes multiple args.
OK tb afresh1
|
|
|
|
|
|
|
|
|
|
|
|
(=mini34). Preparatory to removing some obsolete/unused disktab
entries.
|
|
|
|
^C during questiong yields
/install: /tmp/cppid: cannot open $(<) input
The trap handler must first test existence, then read the PID file.
Quote like other PID file constructs in install.sub do.
Use newlines to make the trap function readable.
OK miod
|
|
ok kn@ deraadt@
|
|
WEP does not work with our bwfm(4) and it shows:
Which network interface do you wish to configure? (or 'done') [bse0] bwfm0
ifconfig: SIOCS80211NWKEY: Operation not supported by device
Access point? (ESSID, 'any', list# or '?') [any] 2
Security protocol? (O)pen, (W)EP, WPA-(P)SK [O]
Handle the error and disable (W)EP unless the driver has it.
No objections from anyone.
|
|
ok miod@ millert@
|
|
|
|
One new question to cover the most common use case, such that manual setup
in (S)hell or '!' prior to install is no longer required:
Encrypt the root disk? (disk, 'no' or '?' for details) [no] ?
Create a passphrase protected CRYPTO softraid volume to be used as root disk.
Available disks are: sd0.
Encrypt the root disk? (disk, 'no' or '?' for details) [no]
Use of keydisk or different disciplines are not covered.
Only asked in interactive installations; no autoinstall(8) or upgrades.
Only reachable on i386, amd64, sparc64 and riscv64 for now (arm64 WIP).
Tested by cheloha naddy and a few users
Feedback from cheloha deraadt claudio
OK cheloha
"get it in now" deraadt
|
|
|
|
|
|
|
|
|
|
In practise, omitting \n is pointless in get_*devs*(), addel() and rmel()
as they are all all used in such a way that the shell always ensures a
trailing \n anyway.
(This might have been needed with the old recursive bsort(), but not now.)
The one exception being the case of a ramdisk with no disks, which revealed
\n mishandling in the root disk question where it ought to print "none"
instead of an empty list of available disks (since inception in r1.1114):
Available disks are: .
Which disk is the root disk? ('?' for details) ?
OK afresh1
|
|
|
|
|
|
It's from a test file and should never have been installed.
Noticed by xse in #openbsd on libera.chat
|
|
Enable features like arithmatic expression and thus make the debug aid
`FUNCS_ONLY=1 . /install.sub' work in those prompts.
'!' answers spawn their own ksh process, but (S)hell drops into /.profile
sourced by /bin/sh executed by init(8), i.e. a korn shell defaulting to
strict bourne shell mode.
Shell options in this interactive parent shell do not effect install.sub
aka. /install, /autoinstall and /upgrade as it is executed in a child.
OK afresh1
|
|
Sets on an unmounted disk partition are most likely to be on install media,
e.g. CD or USB stick.
Default 'Which disk contains the install media?' to the first disk that is
a) not the root disk and b) not a disk with softraid chunks (hosting the
root disk, for example).
This makes it point at the right disk in most setups.
All disks remain valid answers, this is only about the default.
OK afresh1
|
|
|
|
|
|
|
|
ksh(1) can sort itself and addel() ensures uniqueness, so reuse both to get
a much simpler shell version of `sort -u' that is bug-for-bug compatible
with the old one but shorter and easier to tweak/reason about.
OK afresh1
|
|
|
|
|
|
|
|
|
|
|
|
|
|
root partition.
Identical behaviour as but more readable than the "echo 'a
a\n\n\n\nw\nq\n'| disklabel -E" it replaces.
It also eliminates the extraneous output of -E that required
">/dev/null".
ok kn@
|
