Age | Commit message (Collapse) | Author |
|
We should be fine silencing only the test condition which produces legit
output and warnings.
All else produces no output and should not error out; if it does, those
warnings should be printed and fixed.
Feedback OK halex
|
|
|
|
|
|
This function's style is a bit off: it wraps the body in a subshell to
discard all stdout/err at once, but still uses return inside it.
1. A command list (using {}) would be enough here as it groups like a
subshell but avoids spawning another shell;
2. discarding stdout/err at the end of an if block works the same
(effecting both condition and body) and saves one level of indent;
3. return inside a subshell inside a function does NOT return from the
function but merely exits the subshell; this is easily misread.
Saving a fork and indent and improving readability boils down to this
(cvs diff -wU1):
|@@ -3320,3 +3317,2 @@ check_unattendedupgrade() {
| _d=${_d%% *}
|- (
| if [[ -n $_d ]]; then
|@@ -3331,5 +3327,5 @@ check_unattendedupgrade() {
| rm -f /dev/{r,}$_d?
|- fi
|+ fi >/dev/null 2>&1
|+
| return $_rc
|- ) > /dev/null 2>&1
| }
OK halex
|
|
On supported -release systems, syspatch(8) -c is run from rc.firsttime(8)
and the list of patches it pretty-printed if non-empty.
-c output fits into a shell variable, not needing a temporary file, which
is also what usr.sbin/syspatch/syspatch.sh does internally.
OK millert
|
|
sh(1) happily accepts newlines inside double quotes just like in scripts:
$ sh -c "echo foo
echo bar"
foo
bar
So no need to squash things into a single line as usually done inside make
targets where each makefile line is considered its own script unless
continued with trailing backslashes.
OK millert
|
|
|
|
The delimiter can be quoted (single or double) to disable parameter, command
and arithmetic expansion inside the here document:
$ cat <<__EOT
echo $(echo foo)
__EOT
echo foo
$ cat <<'__EOT'
echo $(echo foo)
__EOT
echo $(echo foo)
Do the latter to be able to write the here document/file content exactly as
it would end up in output/rc.firsttime, making it easier to read.
To be more consistent and explicit, switch the remaining here documents with
pure plain text (no shell expansion, etc.) to quoted delimiters.
OK millert
|
|
We read /tmp/i/hosts line-wise to fill /mnt/etc/hosts and remove the tmp
file immediately afterwards, so just skip ftplist entries inside the loop
with a slightly easier to read ksh pattern rather than purge the tmp file
up-front with sed(1).
This is also a tiny bit more robust should the ftplist entries ever be added
with a tab as separator instead of a space and/or an alias since the sed
one-liner hardcodes a single space and expects no alias whereas ksh's read
takes any amount of whitespace between _addr and _hn while not caring about
optional aliases.
Comment is obvious so zap it.
OK millert
|
|
model there might be no firmware and we want to avoid confusing users
with WARNING messages about patterns that were not matched.
ok deraadt@
|
|
to use a time zone path that's not relative to /usr/share/zoneinfo.
Hopefully we can limit tzset(3) to only look at zone info files in
/usr/share/zoneinfo, soon.
OK millert, deraadt
|
|
ok miod@ deraadt@
|
|
|
|
|
|
|
|
|
|
'disklabel -dw'.
Tested & ok visa@
|
|
'disklabel -dw'.
Tested & ok miod@
|
|
ok kn@
|
|
|
|
|
|
|
|
OK miod jsg
|
|
|
|
|
|
Missed in previous
OK kettenis
|
|
ok kn@, deraadt@
|
|
|
|
ok deraadt@
|
|
for the / file system. Brings landisk into the wonderful world of y2k38
compliance.
|
|
|
|
OK miod
|
|
case install the first level bootstrap at the beginning of the of the wd0a
filesystem, rather than at the beginning of the disk.
Both locations work but the previous behaviour overwriting an existing MBR
is a violation of POLA.
tweaks & ok krw@
|
|
OK jsg@
|
|
disktab.h has not been used or useful for a looooong time.
Detailed historical research by jsg@.
ok jsg@ deraadt@
|
|
It is possible to install OpenBSD/armv7 using the framebuffer console on
systems supporting the simplefb(4) driver, such as the Cubieboard2.
OK miod@
|
|
|
|
----------------------------
/usr/src/usr.sbin/installboot/Makefile revision 1.25
date: 2022/08/15 17:06:43; author: kn; state: Exp; lines: +5 -1; commitid: 36Ayh2RViNOotnQJ;
Add initial piece for softraid(4) support on arm64
arm64 is the only currently supported OpenBSD platform which both
a) supports booting off root on softraid(4) (kernel and bootloader) and
b) is an EFI platform (as far as installboot(8) is concerned).
Currently, installboot treats softraid root volumes as regular devices,
ignoring ignores chunk devices completely.
Teach installboot the first bits of softraid support for EFI:
installing the single-stage boot loader on chunks rather than the volume.
Copy over sparc64's softraid stage-1 code as-is and make its stage-2 a NOOP:
# ./obj/installboot -v sd4
Using / as root
installing bootstrap on /dev/rsd4c
using first-stage /usr/mdec/BOOTAA64.EFI
sd4: softraid volume with 1 disk(s)
sd0a: installing boot blocks on /dev/rsd0c
copying /usr/mdec/BOOTAA64.EFI to /tmp/installboot.KuBD4zkfpM/efi/boot/bootaa64.efi
writing /tmp/installboot.KuBD4zkfpM/efi/boot/startup.nsh
arm64 miniroot fits and boots with this.
OK stsp
As of now, EFI partitions must still be created manually as installboot's
'-p' does not support softraid at all (next missing piece for root on
softraid on arm64 installations to work out-of-the-box).
----------------------------
Reminded by miod, thanks
|
|
|
|
softraid(4) patterns were never used since import in 2015
and only one out of APFS patterns are used.
Feedback on APFS krw
OK krw
|
|
|
|
|
|
|
|
|
|
|
|
|
|
games in there, in particular during BIOS upgrade sequences.
ok krw kettenis dv
|
|
|
|
|
|
|