| Age | Commit message (Collapse) | Author |
|---|
|
OK deraadt@ mestre@
|
|
<stdlib.h> if we are on a QUEST
OK tb@
|
|
last arguments since "The list of arguments must be terminated by a null
null pointer" of type char *
Suggested by and OK tb@
|
|
OK tb@
|
|
OK tb@
|
|
Prompted and OK by tb@
|
|
OK tb@
|
|
, remove some lint-style comments, add missing void to functions without args,
also some function prototypes (extern) were missing their args, so I added them
as they were defined in hack.h
OK tb@ on separate diffs
|
|
OK tb@
|
|
OK tb@
|
|
|
|
|
|
|
|
OK tb@
|
|
OK tb@
|
|
OK tb@
|
|
mille.h:
#define CTRL locally, which is used by move.c and misc.c, to avoid including
termios.h or sys/ttydefaults.h where it's actually defined
varpush.c:
Change _PATH_DEVNULL to "/dev/null" since other systems may not have it defined
but also avoids including <paths.h>
Included a few sugestions from tb@ who also gave his OK
|
|
ok mestre@
|
|
ok mestre@
|
|
Note: casted 2 args to struct sockaddr * on list.c to shut off compiler
warnings, and also changed an int len to socklen_t since recvfrom(2) receives
the last argument as the latter.
I'm running out of credits, but this was once again with great help and OK from
tb@
|
|
OK tb@
|
|
SUSP in the termios settings. Presumably this is how things worked
before the conversion to termios. Fixes suspend/resume in hack.
|
|
- in main() replace exit with return
- drop some /* NOTREACHED */ lint comments along the way.
- make more use of standard CFLAGS, esp. -Wimplicit-function-declaration
- add and sort some headers when needed
- add straightforward pledges to some programs used at compile time
discussed with and ok mestre@
|
|
Note: Binary change is introduced due to function schedule() where its args are
(int,double,char,char,char), but on trek.h are (int,double,int,int,int). Changed
to the latter since the 3 last args are coordinates.
OK tb@
|
|
OK tb@
|
|
|
|
Lesson learnt: don't include an header sorted alphabetically just because. The
external definition of variables was done on phantglobs.h but their declaration
was on phantstruct.h and therefore the latter must be included before the
former. It's easier to just include phantstruct.h inside phantglobs.h since it
always need it.
With help and OK from tb@
|
|
ok mestre@
|
|
Convert function() to function(void).
ok mestre@
|
|
on an older diff by mestre.
ok mestre@
|
|
ok mestre@
|
|
ok mestre@
|
|
OK tb@ and he also pointed out that for consistency with rest of the tree we
should include termios.h instead of sys/ttydefaults.h, where applicable
|
|
Most noticeable that were removed are sys/types.h which will be included from
stdlib.h and in turn also brings along sys/cdefs.h. The other one is limits.h
that was used with the old idiom (denom * random() / LONG_MAX), although it was
only removed were applicable (some files still need that header).
OK tb@
|
|
srandom(time()+getpid()), was changed by srandomdev(), but #include <time.h>
lived up until this day so remove it.
Additionally, earlier than that, 18 years ago, random(6) was one of the first
consumers of arc4random(3) family, and was pulling it from dev/rndvar.h but
these days we pull it from stdlib.h, which is already done, so while here
remove dev/rndvar.h also.
"seems comprehensive to me" deraadt@ and OK tb@
|
|
|
|
This one was also OK'ed by tb@
|
|
OK tb@
|
|
Alerted by tb@
|
|
OK tb@
|
|
OK tb@
|
|
With help and OK from tb@
|
|
of clarification. Thus, express the description both more concisely and
more precisely. Drop details about spaces in the output formatting.
While there, update the corresponding comment in the source code.
With input from jmc@ and mestre@; detailed discussion with sobrado@.
ok sobrado@
|
|
Prompted by benno's addition of the flag to most of usr.sbin/.
ok benno@
|
|
match the format of the original;
from andre smagin
|
|
from netbsd pr 49451
|
|
ok mmcc@
|
|
ok tb@
|
|
With precious tip, help and also OK from tb@
|
|
- while here switch main() to return instead of exit(3), makes stack protector happy.
OK tb@
|
