Age | Commit message (Collapse) | Author |
|
less distracting this way.
|
|
bug noticed by mlarkin
|
|
ok cheloha deraadt schwarze
|
|
analysis and patch from David Fifield
|
|
properties for the Wumpus. The bug has been present since 4.3BSD-Reno
and was introduced by Keith Bostic on February 14, 1990 when committing
the major rewrite from Dave Taylor.
Patch (accompanied by a detailed functional and historical analysis)
from David Fifield <david at bamsoftware dot com> on bugs@.
With all the bats in these caves, how could a bug possibly survive
for twenty-eight years?
|
|
First, fill a missing pixel in the glyph for 'U'.
Second, fix an off-by-one in the line output routine. This caused an
extra space character to be output at the end of every line. It might
have caused a buffer overflow if any glyph had used the entire possible
width of 132 pixels, but as it is the widest is only 124 pixels.
Third, output blank lines instead of lines full of spaces (the number of
spaces was equal to the width of the most recent non-blank line).
Finally, add bounds checks to protect against buffer overflows that could arise
in case the data table were ever modified to draw out of bounds (characters
wider or taller than 132 pixels, or a two-byte code where the second byte is
past the end of the table).
ok bcallah
|
|
data table are unused and can be eliminated by rendering al glyphs and
re-encoding them. A few more entries can be eliminated through more
efficient encoding.
Patch generated with a python program by David Fifield.
For details see https://marc.info/?l=openbsd-bugs&m=153955110702704&w=2
ok bcallah
|
|
ok sthen@
|
|
user's home folder and setgid was removed. Therefore it's not possible to have a
single score file with all the users anymore but we forgot to change a comment
that still implied that.
Suggested by tb@ to just delete the comment.
|
|
but with much reduced permissions ("stdio tty" if ncurses based and "stdio"
for the ones that only perform basic operations).
There's still a few games that we cannot yet remove their fs access, through
pledge(2), since they open files on demand and too late, this might get
revisited in the future.
OK tb@
|
|
scorefile nevertheless an fd is opened way in advance and therefore we can
disable any further access to the filesystem.
OK tb@
|
|
OK tb@
|
|
effectively disable all fs access by dropping "rpath wpath cpath" from
pledge(2) right at the beginning of the program.
"looks right" tb@
|
|
Discussed with and OK tb@
OK cheloha@ on previous version
|
|
from Martin Kopta <martin at kopta dot eu>
|
|
in for loops.
ok stsp, bcallah
|
|
the battlestar code by reformatting a few lines.
special request from mlarkin so he'll go back to fixing meltdown.
|
|
David Fifield; ok tb@
|
|
|
|
Makes reading the classification algorithm easier.
ok tb@
|
|
adj360() is a modulo operation: use fmod(3) to simplify things.
Adding 0.5 to the phase to steer implicit truncation is a hack:
use lround(3) to simplify things.
Product of a discussion with pjanzen@/jca@/tb@ regarding floating-point
rounding and the importance of correctly classifying a gibbous moon.
ok pjanzen@ jca@ tb@
|
|
ok tb@ jca@
|
|
instead of gettimeofday(2).
From Scott Cheloha, ok jca
|
|
from scott cheloha
|
|
trailing whitespace is no longer permitted when invoked from stdin.
From Scott Cheloha.
ok jca
|
|
ok jasper@, jca@, deraadt@
|
|
From Scott Cheloha
|
|
ok tb
|
|
|
|
Fixes printing of fortunes that use a combination of backspace and
underbars for underlining in non-UTF8 locales. OK schwarze@
|
|
From Scott Cheloha
|
|
bentley's previous commit.
|
|
suggested by tedu, ok schwarze@ stsp@ tb@
|
|
printable ASCII. That makes using UTF-8 in fortune datfiles safe.
Potential usefulness of UTF-8 in fortune datfiles noticed by bentley@.
OK tedu@ millert@.
|
|
OK mlarkin@
|
|
okay millert@
|
|
files. This fixes up parallel builds in the default case.
FreeBSD does something similar.
okay millert@
|
|
ok bentley
|
|
okay millert@
|
|
as found by krw@
|
|
|
|
Those functions are unused and have been compiled out since 1998,
it's time to let them go.
OK sthen@, tom@, mestre@
|
|
OK tb@
|
|
ok jmc@
|
|
OK tb@ (fix paths diff) deraadt@
|
|
OK tb@ deraadt@
|
|
okay millert@ deraadt@
|
|
OK tb@, jmc@
|
|
OK tb@, phessler@ (previous version)
|
|
When invoking fortune with the -l option (to get long dictums only),
the program gets stuck in an infinite loop because fortlen() doesn't
return the fortune length correctly.
OK mestre@, tb@, deraadt@, schwarze@
|