Age | Commit message (Collapse) | Author |
|
ok mickey@
|
|
changes address incorrect stack usage, when optimization needs more
nameless temporary values than available registers, and has to save them
on stack.
In some (rare) circumstances, it will compute a stack address _outside_
the current function local storage space, overwriting the caller's stack.
Most of the time, this only affects the "outgoing argument area", which is
harmless if it has not been populated; this explains why it has not been
noticed earlier.
Since I see no easy way to fix this, I decided to go the simpler way of
removing this ougoing argument area. This not only reduces stack usage,
but also makes varargs/stdarg code smaller and faster; also functions which
get their first few arguments in registers, then some on the stack, then
some in registers again, will not allocate stack space for the second
set of arguments passed through registers.
This is an ABI change, we are no longer 88Open compliant (have we ever
been?).
|
|
from Jonathan Gray (PR #3870);
ok millert@
|
|
again; stabs doesn't work for 64-bit code.
ok miod@, espie@
|
|
work for code compiled at -O0...
|
|
ok miod@, wow deraadt@
|
|
knowing that the area we are using is correctly aligned.
Produces smaller and faster code (about 0.8% time decrease in a complete
build, which amounts to roughly 15 minutes).
|
|
the sole purpose of making these easier to spot and exterminate.
tested by various people on amd64 and I on arm&sparc64, ok deraadt@
|
|
for registers if at least one nameless argument is passed through registers;
instead, only allocate as many bytes as necessary.
Slightly reduces stack usage; no ABI change.
|
|
current_function_{stdarg,varargs} instead of homegrown implementation, etc.
No functional change.
|
|
fixes C++ exceptions.
this relies on an earlier libstdc++ bump
|
|
and they have different major numbers to prevent collision.
|
|
To build you must:
cd /usr/src && make obj && make includes
cd lib/libc && make depend && make && NOMAN=1 sudo make install
cd /usr/src && make build
|
|
The problem really only arises when optimize_reg_copy_3() attempts to
merge a load which fits in a register and a load which does not fit - in
the m68k case, merging an int32_t foo and (int64_t)foo two lines later.
In this case, and only if the backend provides its own expansion of the
extendsidi2 insn (usually for performance and code size reasons) as
embedded assembly statements but not rtl operations, then gcc at this
point will ``fail to realize'' that when sign-extending (or
zero-extending) the value of rN into rN and r(N+1), the value of rN is
not preserved on big-endian architectures, and the optimization will
produce bad code.
Of all the OpenBSD-supported platforms, arm and m68k are the only
affected; but further optimizations in gcc3 (on arm) apparently neuter
this bug, which I have been unable to reproduce in an arm build with
gcc3.
This commit works around the problem by preventing expansions larger
than the width of a general register, on m68k only. Other platforms are
not affected.
|
|
suggested by Alexey E. Suslikov;
ok millert@
|
|
|
|
forgot to commit this with the .mk changes, sparc was broken for a while
|
|
"kvm pcb" commands.
ok deraadt@
|
|
ok miod@
|
|
|
|
This is a workaround for lines 1055-1057 of tcp_input.c being miscompiled,
though the problem looks like missing use/clobber qualifiers in the
extendplussidi insn, rather than a specific optimize_reg_copy_3() issue.
A proper fix may be devised in the future, in the meantime this allows
m68k platforms to be back in track.
|
|
|
|
|
|
|
|
|
|
ok deraadt@
|
|
ok drahn@
|
|
|
|
|
|
|
|
a 2,048-byte boot sector.
ok weingart@
|
|
progress bar with very slow connections)
|
|
|
|
tested todd@,naddy@. millert@ deraadt@ ok
|
|
|
|
least ANSI_VARARGS deep inside the configure. Sorry -- try again.
|
|
|
|
|
|
- INSN_CODE and LOG_LINKS attributes should be copied from the first insn of splitted insns.
ok pvalchev@ and sturm@
|
|
|
|
isn't that far away... xcrypt-ctr (AES ctr mode), montmul (montgomery
multiply for 800 RSA sign/sec at 1024bit), and xsha1/xsha256 too.
|
|
No functional change, it's just faster.
|
|
and the reload phase when compiling complex code, and the fix is non-trivial.
|
|
|
|
and FUNCTION_ARG_ADVANCE fixes in m88k.c, allow the optimized bcopy
sequences to be reliable again, so enable them back.
|
|
parameter is going to hit the stack.
|
|
Sebastian Krahmer.
ok millert@
|
|
__builtin_saveregs(); no functional change.
|
|
ok mickey@, drahn@, deraadt@
|
|
MAKE SURE TO REBUILD LD.SO FIRST
|