| Age | Commit message (Collapse) | Author |
|---|
|
Declare functions rather than generating declarations with macros.
Just call functions rather than mainting function pointer tables.
Purge unused arguments. Simplify mbstate_t casting.
Garbage collect one empty and one unused function.
As a bonus, make mbsinit(3) work at all, it returned garbage
in the past due to a missing cast when passing mbstate_t.
Apart from that, no functional change.
No libc bump needed; only private functions are removed and
change prototype and only private structs change size.
OK stsp@ mpi@; deraadt@ likes the general direction.
|
|
While here, polish some wording.
OK stsp@
|
|
a linked list to store it. No functional change.
OK mpi@ guenther@,
and stsp@ agrees too that the time is ripe to start such cleanup
|
|
from henning petersen, netbsd pr lib/51284
ok semarie
|
|
locale implementation: _{Current,Default}*Locale, __[mn]locale_changed,
__mb_len_max_runtime
ok millert@ schwarze@ deraadt@
|
|
correctly - logically complete that now by removing MLINKS from base;
authors need only to ensure there is an entry in NAME for any function/
util being added. MLINKS will still work, and remain for perl to ease
upgrades;
ok nicm (curses) bcook (ssl)
ok schwarze, who provided a lot of feedback and assistance
ok tb natano jung
|
|
so no need to include share/locale/ctype/Makefile.inc to get it.
ok guenther@ stsp@ (who had the same diff)
|
|
that setting errno is required by POSIX, but not by ISO C.
|
|
This is unambiguously required both by POSIX and by our own manual page.
It also makes a lot of sense because having a function that can
fail and that sets errno in some failure modes but does not set
errno in other failure modes would be a terrible idea. Such a
function would be ridiculously complicated to use. To detect the
reason for failure, you would have to:
- save errno
- reset errno to zero
- call the function
- inspect the return value to detect failure
- inspect errno to decide about the reason for failure
- if errno is zero, restore the saved errno
That is completely unreasonable, in particular for a seemingly innocous
function like mbtowc(3). Next to no programmer would get that right in
any real-world program.
Note that this bug is very widespread, it also affects NetBSD,
FreeBSD, Solaris 11, and glibc. I will also send a note around to
the other systems.
There may be fallout from programs using the interface incorrectly.
If you run into any, please report that to me.
OK millert@
|
|
|
|
This function doesn't even have an "n" argument, so that non-existent
argument clearly cannot restrict the return value.
|
|
incomplete characters are not an error, do not throw EILSEQ, and
are not supposed to.
OK millert@
|
|
ok tobias@
|
|
with input by and ok schwarze@
|
|
With input from jmc, zhuk, schwarze, and bentley.
ok jmc zhuk bentley
|
|
|
|
ok jmc@
|
|
case, by deleting some useless '& of an array' we also eliminate the need
for the casts which prompted the original lint warnings
ok deraadt@
|
|
setrunelocale() which is not exported from libc
ok jmc@ stsp@
|
|
on arm and m88k
problems with optind observed by jsg@
|
|
the symbols are weak
|
|
|
|
in standard C are all weak.
Hide several symbols internal to the implementation
|
|
C standard are all weak.
Apply __{BEGIN,END}_HIDDEN_DECLS to gdtoa{,imp}.h, hiding the
arch-specific __strtorx, __ULtox_D2A, __strtorQ, __ULtoQ_D2A symbols.
|
|
and the symbols not in the C standard are weak
|
|
|
|
there is a test for "only UTF-8" after, that will return ENOTSUP. So the caller
will known the wanted codeset isn't supported.
problem spotted by guenther@
OK stsp@ guenther@
|
|
ok mpi tedu phessler zhuk, and discussed with many at c2k15
|
|
ok mpi tedu phessler zhuk, and discussed with many at c2k15
|
|
Input & okay (pre-lock) from jmc@, sobrado@ and stsp@.
|
|
suggestion for removing (instead of commenting) the lines from stsp@
OK millert@
|
|
cvs. Remove the unused search path from Makefile.inc
"fine with me" stsp@
|
|
This variable is used as temporary buffer in order to do checking
before copying the content to current_categories variable.
Switch it as local variable in setlocale function. Adapts some functions.
the commit collapse 3 proposed diffs on tech@, and all OK stsp@
|
|
Diff from Sebastien Marie. objdump foo help from uwe
|
|
character codeset for the POSIX/C default locale. This is the
preferred IANA name and also used by FreeBSD.
The previous value "646" was an obscure reference to ISO 646 (= ASCII)
and was not recognized by GNU iconv out of the box.
ok millert@, stsp@
|
|
|
|
by Kaspars Bankovskis. ok jmc@
|
|
|
|
|
|
As pointed out by stsp@, LC_CTYPE *does* affect the ctype.h functions.
Use a wording similar to a suggestion by deraadt@.
Feedback and OK jmc@, OK stsp@.
|
|
|
|
|
|
ok espie@ deraadt@ millert@ tedu@
|
|
of the resulting FILE *), then pass fopen() the 'e' mode letter to
mark it close-on-exec.
ok miod@
|
|
required for libc++
ok guenther afresh1
|
|
|
|
For inet(3), go the other way, remove some bogus symlinks.
Found while testing the new makewhatis(8).
ok jmc@
|
|
(namespace pollution!) or talking about its opinion on code.
ok krw@
|
|
|
|
|
