Age | Commit message (Collapse) | Author |
|
Based on a patch from enh@google. OK tb@
|
|
Explicitly mention that most programs do not need to call tzset() directly.
OK deraadt@ jmc@ benno@
|
|
Other absolutes paths are still rejected.
|
|
Noted by pjanzen@ with input from deraadt@.
|
|
Reading time zone files from user-controlled paths can result in
pledge(2) or unveil(2) violations. We also ignore files that contain
a '.' character to avoid paths containing ".." or hidden files.
Work with and OK deraadt@
|
|
from josiah frentsos, tweaked by schwarze
ok schwarze
|
|
|
|
ok jmc@ schwarze@
|
|
Upstream removed it in 2004. From Jan Stary.
|
|
reported by Gordon Bergling <gbergling at gmail dot com>
|
|
The tzcode package marked it dprecated in the late 1980ies
but it is universally supported and here to stay.
Triggered by a question from Rodrigo <hruodr at gmail dot com> on misc@.
William Ahern <william at 25thandclement dot com> listed a number of
sound arguments why it shouldn't be considered deprecated, in
particular that there is no better alternative, in particular none
that is thread-safe.
While here, fix the non-standard section name "NOTES", add the
missing STANDARDS section and provide additional information in the
HISTORY section, based on inspection of C89, C11, POSIX 2008, UNIX
v4 and v5 at TUHS, Tahoe and Reno at the CSRG archives, amd the
SunOS 3.5 and 4.0 manuals on bitsavers.
Reasearch on tzcode and SunOS history done by millert@.
OK millert@ on an earlier version of this patch,
and deraadt@ agrees with the general direction.
|
|
conversion specifications that are extensions; issues reported by
Andras Farkas <deepbluemistake at gmail dot com> on misc@.
While here, note that alternative conversion modifiers have no effect
and that flags and field width specifications are not supported.
|
|
|
|
|
|
value < 0. errno is only updated in this case. Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.
|
|
i.e. those other than LC_CTYPE, into the CAVEATS section, and
standardize wording somewhat.
OK jmc@
|
|
No binary change when compiled with -g0.
Note that wcsftime.c did not even compile without TM_ZONE.
OK millert@
|
|
and also delete spaces before tabs;
no object change
|
|
bug reported by Hiltjo Posthuma <hiltjo at codemadness dot org>;
feedback and OK millert@, OK tedu@
|
|
patch from Hiltjo Posthuma <hiltjo at codemadness dot org>;
OK tedu@ millert@
|
|
They were originally defined in one way, then RFC822 erroneously
redefined them the opposite way, then RFC5322 said they can no
longer be used reliably.
So return NULL like FreeBSD, DragonFly, glibc, and musl do.
Issue reported by Hiltjo Posthuma <hiltjo at codemadness dot org>.
Deletion suggested by tedu@ and deraadt@.
Feedback and OK on the patch from tedu@.
|
|
Since strftime(3)'s %e conversion specification preceeds single digits by a
blank, do the converse here to allow safe data round trips through these
functions with the same format string.
Positive feedback tedu deraadt,
OK millert jca
|
|
POSIX allows for one extra second in a minute, i.e. "23:59:60", so that leap
seconds can be parsed. They don't allow for *two* extra seconds, i.e.
"23:59:61", though.
Typo introduced in NetBSD lib/libc/time/strptime.c,v1.3.
ok krw@ bcook@ tedu@
|
|
ok cheloha
|
|
|
|
Complete in the sense that all POSIX *locale(3) and *_l(3) functions
are included, but in OpenBSD, we of course only really care about
LC_CTYPE and we only support ASCII and UTF-8.
With important help from kettenis@, guenther@, and jca@.
Repeated testing in ports bulk builds by naddy@.
Additional testing by jca@, sebastia@, dcoppa@, and others.
OK kettenis@ dcoppa@, and guenther@ on an earlier version.
Riding guenther@'s libc/librthread major bump.
|
|
or prototypes. Ditto for some of the char* and void* casts too.
verified no change to instructions on ILP32 (i386) and LP64 (amd64)
ok natano@ abluhm@ deraadt@ millert@
|
|
parameter that was passed in. From Carlin Bingham.
|
|
locale implementation: _{Current,Default}*Locale, __[mn]locale_changed,
__mb_len_max_runtime
ok millert@ schwarze@ deraadt@
|
|
correctly - logically complete that now by removing MLINKS from base;
authors need only to ensure there is an entry in NAME for any function/
util being added. MLINKS will still work, and remain for perl to ease
upgrades;
ok nicm (curses) bcook (ssl)
ok schwarze, who provided a lot of feedback and assistance
ok tb natano jung
|
|
applications like zdump(8) because pledge(2) doesn't allow access(2) to
/usr/share/zoneinfo.
millert@ better described why this call can go away:
"This looks like an attempt to do access checks based on the real uid instead
of the effective uid. Basically for setuid programs we don't want to allow a
user to set TZ to a path they should not be able to otherwise access.
However, we already have a check for issetugid() above so I think the doaccess
bits can just be removed and we can rely on open()."
After discussion with tb@, deraadt@ and millert@, this was also OK'ed by them
|
|
|
|
|
|
ok tedu@
|
|
|
|
|
|
|
|
several. Switch from FILENAME_MAX to PATH_MAX (it's for open(), not fopen()).
ok deraadt@ tedu@ krw@
|
|
except at the one place where it is indeed helpful.
Add some missing .Cm macros.
Remove some useless escaping, one needless .Xo, and an empty .No.
Triggered by a much smaller patch from guenther@.
OK jmc@ guenther@
|
|
on arm and m88k
problems with optind observed by jsg@
|
|
|
|
Add prototypes to localtime.c for offtime(), time2posix(), posix2time() to
reduce noise with -Wmissing-prototypes
Eliminate unnecessary #includes
|
|
|
|
Add timezone and daylight symbols for XSI compatibility.
|
|
Be clear that "standard" byte order means big endian.
Update struct ttinfo.
|
|
|
|
While here, correctly mark up time_t as a variable type and use prettier
double quotes.
ok schwarze@
|
|
|
|
|
|
from continuation lines, of which there are many
|