Age | Commit message (Collapse) | Author |
|
Since strftime(3)'s %e conversion specification preceeds single digits by a
blank, do the converse here to allow safe data round trips through these
functions with the same format string.
Positive feedback tedu deraadt,
OK millert jca
|
|
This implementation reduces contention because threads no longer need
to spin calling sched_yield(2) before going to sleep.
Tested by many, thanks!
ok visa@, pirofti@
|
|
Pointed out by pirofti@ while reviewing my rwlock impl. based on this one.
|
|
OK claudio@ and jca@
|
|
|
|
This lets witness(4) save a stack trace on each lock acquisition.
The saved traces can be viewed in ddb(4) when showing the currently
held locks, which may help when debugging incorrect locking.
Sample output:
ddb{0}> show all locks
Process 63836 (rm) thread 0xffff8000221e52c8 (435004)
exclusive rrwlock inode r = 0 (0xfffffd8119a092c0) locked @ /usr/src/sys/ufs/ufs/ufs_vnops.c:1547
#0 witness_lock+0x419
#1 _rw_enter+0x2bb
#2 _rrw_enter+0x42
#3 VOP_LOCK+0x3f
#4 vn_lock+0x36
#5 vfs_lookup+0xa1
#6 namei+0x2b3
#7 dounlinkat+0x85
#8 syscall+0x338
#9 Xsyscall+0x128
exclusive kernel_lock &kernel_lock r = 1 (0xffffffff81e6a5f0) locked @ /usr/src/sys/arch/amd64/amd64/intr.c:525
#0 witness_lock+0x419
#1 syscall+0x2b6
#2 Xsyscall+0x128
The saving adds overhead, so it is not enabled by default. It can be
taken into use by setting sysctl kern.witness.locktrace=1 at runtime
or by defining WITNESS_LOCKTRACE in the kernel configuration.
Feedback and OK anton@
|
|
We use these all over the tree so they ought to be documented on a
separate page; move them out of getitimer.2 into timeradd.3. While
moving, clean up the language and markup here and there.
Still needs to be added to share/man/man3/Makefile, pending any further
cleanup in-tree.
With input from schwarze@, jmc@, and millert@.
"looks great" deraadt@, "(ok)" jmc@, ok tedu@,
"we'll spruce it up in-tree" schwarze@
|
|
|
|
When an invalid regular expression is passed, seterr() is called which
sets p->error to the appropriate error code and sets p->next and
p->end to nuls[]. However, p->next is decremented in the default
case in p_ere_exp() and p_simp_re() which makes it point to one
byte before nuls[]. From FreeBSD. OK tedu@ deraadt@
|
|
This requires a libc major version bump. OK deraadt@
|
|
|
|
dereferencing it.
ok kettenis@, visa@
|
|
The new node contains the subsystem's main control variable,
kern.witness.watch. It is aliased by the old name, kern.witnesswatch.
The alias will be removed in the future.
OK anton@ mpi@
|
|
|
|
POSIX allows for one extra second in a minute, i.e. "23:59:60", so that leap
seconds can be parsed. They don't allow for *two* extra seconds, i.e.
"23:59:61", though.
Typo introduced in NetBSD lib/libc/time/strptime.c,v1.3.
ok krw@ bcook@ tedu@
|
|
|
|
|
|
net.inet.ipcomp.enable.
ok deraadt@ bluhm@
|
|
ok cheloha
|
|
|
|
the wrong idiom. ok tedu@ but probably needs some tweakin
|
|
looks fine to jmc@
|
|
the macros, and simplify one wording;
OK millert@, tweak and OK jmc@
|
|
ok tedu@
|
|
ok deraadt@ tedu@
|
|
Make it less likely you miss a zero when typing out 100000 or 100000000.
Document them in getitimer.2 for the masses. These may be of use in
library code as well as the kernel.
Comparable inline functions exist in Linux but are not available to
userspace like these.
"OK." deraadt@
|
|
* mention LC_COLLATE;
* clarify that all these functions are infested, including the *_l() versions;
* avoid ENVIRONMENT, these functions don't inspect it;
* and point to the C library functions that change the locale.
OK millert@
|
|
clearly stating which arguments have to be avoided, and mention the
header files defining the constants required for the checks.
Feedback and OK guenther@, OK bluhm@.
|
|
* correctly mark up NULL
* avoid gratuitous future tense
* replace one wrong .Nm macro
|
|
|
|
Linux does validation.
Document this new failure case as an EINVAL, like Linux.
"stop waiting" deraadt
|
|
Add documentation for the new EINVAL cases for adjtime(2) and
settimeofday(2).
adjtime.2 docs ok schwarze@,
settimeofday(2)/clock_settime(2) stuff ok tedu@,
"stop waiting" deraadt@
|
|
CAVEATS pointing to the new CAVEATS section in setlocale(3).
Make those in wprintf(3) and wscanf(3) more concise
since duplicate information is a bad idea.
Incompleteness of information originally pointed out by millert@.
OK millert@
|
|
|
|
Checking Disabled flag. Introduce a RES flag to do so. ok krw@
deraadt@ eric@
|
|
list many (hopefully the most important) functions affected by the
locale, such that the CAVEATS sections in individual manual pages
can be kept shorter in the future;
basic idea from millert@; feedback and OK jmc@; OK deraadt@.
|
|
Pointed out by naddy@
|
|
POSIX wants it in libc, that's where the function can be found on other
systems. Reported by naddy@, input from naddy@ and guenther@.
"looks ok" guenther@, ok deraadt@
Note: riding the libc/libpthread major cranks earlier today.
|
|
about shared resources which no program should see. only a few pieces of
software use it, generally poorly thought out. they are being fixed, so
mincore() can be deleted.
ok guenther tedu jca sthen, others
|
|
to wprintf(3) with OK cheloha@ tedu@; also triggered by a
smaller diff from Jan Stary <hans at stare dot cz>.
|
|
and explain best practice for portable programs below CAVEATS.
Triggered by a smaller diff from Jan Stary <hans at stare dot cz>.
Emphatic OKs from cheloha@ and tedu@.
|
|
in 4.1c
ok schwarze@
|
|
by me and others indicate that it is the optimum.
|
|
making the number of pools variable. Do not document the malloc
conf settings atm, don't know yet if they will stay. Thanks to all
the testers. ok deraadt@
|
|
|
|
OK claudio@
|
|
* Use .Vt for struct names and other type names like in_port_t.
* Use .Dv for #define'd constants like CPUSTATES and KERN_SYSVIPC_INFO.
* Use .Va for sysctl variable names like "machdep".
Not touching some of the .Li use related to networking; that stuff
looks suspicious in more than one way and a diff would need review.
|
|
ok kn
|
|
understand with the three-operand instructions.
No binary change with gas.
|
|
tsleep(9)'s maximum timeout shrinks as HZ grows, so this ensures we do
not return early from longer timeouts on alpha or on custom kernels.
POSIX says you cannot return early unless a signal is delivered, so
this makes us more compliant with the standard.
While here, remove the 100 million second upper bound. It is an
artifact from itimerfix() and it serves no discernible purpose.
ok tedu@ visa@
|