Age | Commit message (Collapse) | Author |
|
assembly.
ok bcook@
|
|
and drop an unnecessary return from a void function.
ok bcook@ doug@
|
|
using ASN1err() instead of ASN1_MAC_H_err().
ok miod@
|
|
#ifndef LIBRESSL_INTERNAL - we're not using these anymore!
|
|
is due to line numbering.
|
|
macros - the generated assembly only differs by changes to line numbers.
|
|
by changes to line numbers.
|
|
Make sure ASN1_primitive_new() will return NULL in *pval in all error
situations.
ok bcook@ doug@
|
|
|
|
do not forgot to nevertheless keep freeing the other fields.
ok doug@ guenther@
|
|
error stack, not only the first one.
ok guenther@ doug@
|
|
not 16-bit MS-DOS anymore.
ok bcook@ tedu@
|
|
memory. Coverity CID 24810, 24846.
ok bcook@ doug@
|
|
from OpenSSL (RT #3683)
ok doug@ jsing@
|
|
this would promote it to int for the shift, and then cast to unsigned long,
sign-extending it if sizeof(long) > sizeof(int).
This was not a problem because the computed value was explicitely range
checked afterwards, with an upper bound way smaller than 1U<<31, but it's
better practice to cast correctly.
ok beck@
|
|
have seriously corrupted your memory; Coverity CID 21708 and 21721.
While there, plug a memory leak upon error in x509_name_canon().
ok bcook@ beck@
|
|
i2d_X509_PKEY is a "needs to implement" and d2i_X509_PKEY is broken.
Removed upstream in commit b1f3442857c1fd76e91941141bf671d19e90a79d.
ok deraadt@, jsing@
|
|
These include:
CVE-2015-0209 - Use After Free following d2i_ECPrivatekey error
CVE-2015-0286 - Segmentation fault in ASN1_TYPE_cmp
CVE-2015-0287 - ASN.1 structure reuse memory corruption
CVE-2015-0289 - PKCS7 NULL pointer dereferences
Several other issues did not apply or were already fixed.
Refer to https://www.openssl.org/news/secadv_20150319.txt
joint work with beck, doug, guenther, jsing, miod
|
|
|
|
|
|
reminded by bcook@
|
|
ok doug@ jsing@
|
|
ok doug@
|
|
Only change to generated assembly is due to line numbers.
|
|
libcrypto/libssl, and nothing seems to use it in the wild, apart from embedded
copies of OpenSSL.
ok jsing@
|
|
|
|
ok doug@ jsing@
|
|
ok doug@ jsing@
|
|
data structures visible and easier to review, without having to wade
through layers and layers of asn1t.h macros.
Change has been scripted and there is no change to the generated assembly.
Discussed with beck@ miod@ tedu@
|
|
initialise during declaration and drop the else statement.
ok doug@ miod@
|
|
aka ASN1_generate_nconf("FORMAT", NULL)
ok krw@ beck@ jsing@
|
|
Minor changes in generated assembly due to the compiler swapping from
.quad 0/.long 0 to .zero, along with changes due to line numbering.
|
|
structures visible and easier to review, without having to wade through
layers and layers of asn1t.h macros.
Change has been scripted and the generated assembly only differs by changes
to line numbers.
Discussed with beck@ miod@ tedu@
|
|
If you didn't enable deprecated code, there were missing err.h and
bn.h includes. This commit allows building with or without deprecated
code.
This was not derived from an OpenSSL commit. However, they recently
enabled OPENSSL_NO_DEPRECATED in git and fixed these header problems
in a different way.
Verified with clang that this only changes line numbers in the generated
asm.
ok miod@
|
|
be enabled, mostly since people use SANs instead.
ok beck@ guenther@
|
|
15 years.
|
|
Careful review, feedback & ok doug@ jsing@
|
|
assembly due to switches between .quad and .zero for structs.
|
|
|
|
noops around 15 years ago. Remove multiple occurances of both that still
exist in the code today.
|
|
LIBRESSL_INTERNAL - we do not need them any more.
|
|
|
|
the IMPLEMENT_ASN1_DUP_FUNCTION macro.
|
|
the code is visible and functions can be readily located.
Change has been scripted and there is no change to the generated assembly.
Discussed with beck@ miod@ tedu@
|
|
and functions can be readily located.
Change has been scripted and the generated assembly only differs by changes
to line numbers.
Discussed with beck@ miod@ tedu@
|
|
code is visible and functions can be readily located.
Change has been scripted and the generated assembly only differs by changes
to line numbers.
Discussed with beck@ miod@ tedu@
|
|
functions can be readily located.
Change has been scripted and the generated assembly only differs by changes
to line numbers.
Discussed with beck@ miod@ tedu@
|
|
Also fix a memory leak in one of the error paths of SMIME_read_ASN1(), spotted
by doug@
tweaks&ok doug@ jsing@
|
|
|
|
There are a few instances where #if 1 is removed but the code remains.
Based on the following OpenSSL commits. Some of the commits weren't
strictly deletions so they are going to be split up into separate commits.
6f91b017bbb7140f816721141ac156d1b828a6b3
3d47c1d331fdc7574d2275cda1a630ccdb624b08
dfb56425b68314b2b57e17c82c1df42e7a015132
c8fa2356a00cbaada8963f739e5570298311a060
f16a64d11f55c01f56baa62ebf1dec7f8fe718cb
9ccc00ef6ea65567622e40c49aca43f2c6d79cdb
02a938c953b3e1ced71d9a832de1618f907eb96d
75d0ebef2aef7a2c77b27575b8da898e22f3ccd5
d6fbb194095312f4722c81c9362dbd0de66cb656
6f1a93ad111c7dfe36a09a976c4c009079b19ea1
1a5adcfb5edfe23908b350f8757df405b0f5f71f
8de24b792743d11e1d5a0dcd336a49368750c577
a2b18e657ea1a932d125154f4e13ab2258796d90
8e964419603d2478dfb391c66e7ccb2dcc9776b4
32dfde107636ac9bc62a5b3233fe2a54dbc27008
input + ok jsing@, miod@, tedu@
|